| Message ID | 20250204201948.2883452-1-luiz.dentz@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 26ef5a951e8111d360586f1169b8fac2dc2cb613 |
| Headers | show |
| Series | [BlueZ,v2,1/2] build: Enable -Wstringop-overflow and -D_FORTIFY_SOURCE=3 | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/ScanBuild | success | Scan Build PASS |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=930572 ---Test result--- Test Summary: CheckPatch PENDING 0.22 seconds GitLint PENDING 0.17 seconds BuildEll PASS 20.48 seconds BluezMake PASS 1493.53 seconds MakeCheck PASS 12.73 seconds MakeDistcheck PASS 156.64 seconds CheckValgrind PASS 212.23 seconds CheckSmatch PASS 281.84 seconds bluezmakeextell PASS 97.57 seconds IncrementalBuild PENDING 0.27 seconds ScanBuild PASS 847.66 seconds Details ############################## Test: CheckPatch - PENDING Desc: Run checkpatch.pl script Output: ############################## Test: GitLint - PENDING Desc: Run gitlint Output: ############################## Test: IncrementalBuild - PENDING Desc: Incremental build with the patches in the series Output: --- Regards, Linux Bluetooth
Hello: This series was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Tue, 4 Feb 2025 15:19:47 -0500 you wrote: > From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> > > This enables -Wstringop-overflow compiler warnings: > > 'Warn for calls to string manipulation functions such as "memcpy" and > "strcpy" that are determined to overflow the destination buffer.' > > [...] Here is the summary with links: - [BlueZ,v2,1/2] build: Enable -Wstringop-overflow and -D_FORTIFY_SOURCE=3 https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=26ef5a951e81 - [BlueZ,v2,2/2] emulator: Fix Werror=stringop-overflow https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=de2773b659d0 You are awesome, thank you!
diff --git a/acinclude.m4 b/acinclude.m4 index 4b73a5bfc38f..9f2dc302e7bc 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -61,9 +61,11 @@ AC_DEFUN([COMPILER_FLAGS], [ with_cflags="$with_cflags -Wcast-align" with_cflags="$with_cflags -Wswitch-enum" with_cflags="$with_cflags -Wformat -Wformat-security" + with_cflags="$with_cflags -Wstringop-overflow" with_cflags="$with_cflags -DG_DISABLE_DEPRECATED" with_cflags="$with_cflags -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_28" with_cflags="$with_cflags -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_32" + with_cflags="$with_cflags -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3" fi AC_SUBST([WARNING_CFLAGS], $with_cflags) ])
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> This enables -Wstringop-overflow compiler warnings: 'Warn for calls to string manipulation functions such as "memcpy" and "strcpy" that are determined to overflow the destination buffer.' Along with -D_FORTIFY_SOURCE=3 so the errors like the following can be captured: In function ‘read’, inlined from ‘serial_read_callback’ at emulator/serial.c:90:8: /usr/include/bits/unistd.h:32:10: error: ‘__read_alias’ specified size between 18446744073709490177 and 18446744073709551615 exceeds maximum object size 9223372036854775807 [-Werror=stringop-overflow=] 32 | return __glibc_fortify (read, __nbytes, sizeof (char), | ^~~~~~~~~~~~~~~ --- acinclude.m4 | 2 ++ 1 file changed, 2 insertions(+)