Message ID | 20250203-dt-lan9115-fix-v1-4-eb35389a7365@kernel.org (mailing list archive) |
---|---|
State | Not Applicable |
Delegated to: | Netdev Maintainers |
Headers | show |
Series | dt-bindings: Ensure all smsc,lan9115 properties are evaluated | expand |
Context | Check | Description |
---|---|---|
netdev/tree_selection | success | Not a local patch |
On Mon, 03 Feb 2025 15:29:16 -0600 Rob Herring (Arm) wrote: > Device specific schemas should not allow undefined properties which is > what 'additionalProperties: true' allows. Add a reference to > mc-peripheral-props.yaml which has the additional properties used, and > fix this constraint. > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org> Acked-by: Jakub Kicinski <kuba@kernel.org>
On Mon, Feb 03, 2025 at 03:29:16PM -0600, Rob Herring (Arm) wrote: > Device specific schemas should not allow undefined properties which is > what 'additionalProperties: true' allows. Add a reference to > mc-peripheral-props.yaml which has the additional properties used, and > fix this constraint. > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org> > --- > Please ack and I'll take the series. > --- > Documentation/devicetree/bindings/net/smsc,lan9115.yaml | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/smsc,lan9115.yaml b/Documentation/devicetree/bindings/net/smsc,lan9115.yaml index f86667cbcca8..42279ae8c2b9 100644 --- a/Documentation/devicetree/bindings/net/smsc,lan9115.yaml +++ b/Documentation/devicetree/bindings/net/smsc,lan9115.yaml @@ -11,6 +11,7 @@ maintainers: allOf: - $ref: ethernet-controller.yaml# + - $ref: /schemas/memory-controllers/mc-peripheral-props.yaml# properties: compatible: @@ -89,10 +90,7 @@ required: - reg - interrupts -# There are lots of bus-specific properties ("qcom,*", "samsung,*", "fsl,*", -# "gpmc,*", ...) to be found, that actually depend on the compatible value of -# the parent node. -additionalProperties: true +unevaluatedProperties: false examples: - |
Device specific schemas should not allow undefined properties which is what 'additionalProperties: true' allows. Add a reference to mc-peripheral-props.yaml which has the additional properties used, and fix this constraint. Signed-off-by: Rob Herring (Arm) <robh@kernel.org> --- Please ack and I'll take the series. --- Documentation/devicetree/bindings/net/smsc,lan9115.yaml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)