diff mbox series

[4/4] dt-bindings: net: smsc,lan9115: Ensure all properties are defined

Message ID 20250203-dt-lan9115-fix-v1-4-eb35389a7365@kernel.org (mailing list archive)
State New
Headers show
Series dt-bindings: Ensure all smsc,lan9115 properties are evaluated | expand

Commit Message

Rob Herring (Arm) Feb. 3, 2025, 9:29 p.m. UTC
Device specific schemas should not allow undefined properties which is
what 'additionalProperties: true' allows. Add a reference to
mc-peripheral-props.yaml which has the additional properties used, and
fix this constraint.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
Please ack and I'll take the series.
---
 Documentation/devicetree/bindings/net/smsc,lan9115.yaml | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Jakub Kicinski Feb. 4, 2025, 10:09 p.m. UTC | #1
On Mon, 03 Feb 2025 15:29:16 -0600 Rob Herring (Arm) wrote:
> Device specific schemas should not allow undefined properties which is
> what 'additionalProperties: true' allows. Add a reference to
> mc-peripheral-props.yaml which has the additional properties used, and
> fix this constraint.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>

Acked-by: Jakub Kicinski <kuba@kernel.org>
Krzysztof Kozlowski Feb. 5, 2025, 10:06 a.m. UTC | #2
On Mon, Feb 03, 2025 at 03:29:16PM -0600, Rob Herring (Arm) wrote:
> Device specific schemas should not allow undefined properties which is
> what 'additionalProperties: true' allows. Add a reference to
> mc-peripheral-props.yaml which has the additional properties used, and
> fix this constraint.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> Please ack and I'll take the series.
> ---
>  Documentation/devicetree/bindings/net/smsc,lan9115.yaml | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/smsc,lan9115.yaml b/Documentation/devicetree/bindings/net/smsc,lan9115.yaml
index f86667cbcca8..42279ae8c2b9 100644
--- a/Documentation/devicetree/bindings/net/smsc,lan9115.yaml
+++ b/Documentation/devicetree/bindings/net/smsc,lan9115.yaml
@@ -11,6 +11,7 @@  maintainers:
 
 allOf:
   - $ref: ethernet-controller.yaml#
+  - $ref: /schemas/memory-controllers/mc-peripheral-props.yaml#
 
 properties:
   compatible:
@@ -89,10 +90,7 @@  required:
   - reg
   - interrupts
 
-# There are lots of bus-specific properties ("qcom,*", "samsung,*", "fsl,*",
-# "gpmc,*", ...) to be found, that actually depend on the compatible value of
-# the parent node.
-additionalProperties: true
+unevaluatedProperties: false
 
 examples:
   - |