| Message ID | 173870406214.546134.16846124942782280576.stgit@frogsfrogsfrogs (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [01/34] generic/476: fix fsstress process management | expand |
On Tue, Feb 04, 2025 at 01:24:07PM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@kernel.org> > > In the next patch we'll run tests in a pid namespace, which means that > the test process will have a very low pid. This low pid situation > causes problems with the dump tests because they unconditionally replace > it with the word "PID", which causes unnecessary test failures. > > Initially I was going to fix it by bracketing the regexp with a > whitespace/punctuation/eol/sol detector, but then I decided to remove it > see how many sheep came barreling through. None did, so I removed it > entirely. The commit adding it (linked below) was not insightful at > all. > > Fixes: 19beb54c96e363 ("Extra filtering as part of IRIX/Linux xfstests reconciliation for dump.") > Signed-off-by: "Darrick J. Wong" <djwong@kernel.org> > --- > common/dump | 1 - > 1 file changed, 1 deletion(-) > > > diff --git a/common/dump b/common/dump > index 3761c16100d808..6dcd6250c33147 100644 > --- a/common/dump > +++ b/common/dump > @@ -907,7 +907,6 @@ _dir_filter() > -e "s#$SCRATCH_MNT#SCRATCH_MNT#g" \ > -e "s#$dump_sdir#DUMP_SUBDIR#g" \ > -e "s#$restore_sdir#RESTORE_SUBDIR#g" \ > - -e "s#$$#PID#g" \ > -e "/Only in SCRATCH_MNT: .use_space/d" \ > -e "s#$RESULT_DIR/##g" \ Looks fine, if it causes problems further down the line then we can implement a better filter. Reviewed-by: Dave Chinner <dchinner@redhat.com>
diff --git a/common/dump b/common/dump index 3761c16100d808..6dcd6250c33147 100644 --- a/common/dump +++ b/common/dump @@ -907,7 +907,6 @@ _dir_filter() -e "s#$SCRATCH_MNT#SCRATCH_MNT#g" \ -e "s#$dump_sdir#DUMP_SUBDIR#g" \ -e "s#$restore_sdir#RESTORE_SUBDIR#g" \ - -e "s#$$#PID#g" \ -e "/Only in SCRATCH_MNT: .use_space/d" \ -e "s#$RESULT_DIR/##g" \