| Message ID | 173870406549.546134.4341905130116308600.stgit@frogsfrogsfrogs (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [01/34] generic/476: fix fsstress process management | expand |
On Tue, Feb 04, 2025 at 01:29:52PM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@kernel.org> > > Someone forgot to free the iovec that readv_f allocates. > > Fixes: 80499d8f5f251e ("fsstress: new writev and readv operations test") > Signed-off-by: "Darrick J. Wong" <djwong@kernel.org> > --- > ltp/fsstress.c | 1 + > 1 file changed, 1 insertion(+) > > > diff --git a/ltp/fsstress.c b/ltp/fsstress.c > index 9e8eaa6d8656da..14c29921e8b0f8 100644 > --- a/ltp/fsstress.c > +++ b/ltp/fsstress.c > @@ -4652,6 +4652,7 @@ readv_f(opnum_t opno, long r) > } > > e = readv(fd, iov, iovcnt) < 0 ? errno : 0; > + free(iov); > free(buf); > if (v) > printf("%d/%lld: readv %s%s [%lld,%d,%d] %d\n", looks good - writev_f() frees the iov, so this now matches. Reviewed-by: Dave Chinner <dchinner@redhat.com>
diff --git a/ltp/fsstress.c b/ltp/fsstress.c index 9e8eaa6d8656da..14c29921e8b0f8 100644 --- a/ltp/fsstress.c +++ b/ltp/fsstress.c @@ -4652,6 +4652,7 @@ readv_f(opnum_t opno, long r) } e = readv(fd, iov, iovcnt) < 0 ? errno : 0; + free(iov); free(buf); if (v) printf("%d/%lld: readv %s%s [%lld,%d,%d] %d\n",