| Message ID | 20250204005841.223511-3-xiyou.wangcong@gmail.com (mailing list archive) |
|---|---|
| State | Under Review |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net_sched: two security bug fixes and test cases | expand |
On Mon, Feb 03, 2025 at 04:58:39PM -0800, Cong Wang wrote: > From: Quang Le <quanglex97@gmail.com> > > When limit == 0, pfifo_tail_enqueue() must drop new packet and > increase dropped packets count of the qdisc. > > All test results: > > 1..16 > ok 1 a519 - Add bfifo qdisc with system default parameters on egress > ok 2 585c - Add pfifo qdisc with system default parameters on egress > ok 3 a86e - Add bfifo qdisc with system default parameters on egress with handle of maximum value > ok 4 9ac8 - Add bfifo qdisc on egress with queue size of 3000 bytes > ok 5 f4e6 - Add pfifo qdisc on egress with queue size of 3000 packets > ok 6 b1b1 - Add bfifo qdisc with system default parameters on egress with invalid handle exceeding maximum value > ok 7 8d5e - Add bfifo qdisc on egress with unsupported argument > ok 8 7787 - Add pfifo qdisc on egress with unsupported argument > ok 9 c4b6 - Replace bfifo qdisc on egress with new queue size > ok 10 3df6 - Replace pfifo qdisc on egress with new queue size > ok 11 7a67 - Add bfifo qdisc on egress with queue size in invalid format > ok 12 1298 - Add duplicate bfifo qdisc on egress > ok 13 45a0 - Delete nonexistent bfifo qdisc > ok 14 972b - Add prio qdisc on egress with invalid format for handles > ok 15 4d39 - Delete bfifo qdisc twice > ok 16 d774 - Check pfifo_head_drop qdisc enqueue behaviour when limit == 0 > > Signed-off-by: Quang Le <quanglex97@gmail.com> > Signed-off-by: Cong Wang <cong.wang@bytedance.com> Hi Cong, Unfortunately this test still seems to be failing in the CI. # not ok 577 d774 - Check pfifo_head_drop qdisc enqueue behaviour when limit == 0 # Could not match regex pattern. Verify command output: # qdisc pfifo_head_drop 1: root refcnt 2 limit 0p # Sent 0 bytes 0 pkt (dropped 0, overlimits 0 requeues 0) # backlog 0b 0p requeues 0 https://github.com/p4tc-dev/tc-executor/blob/storage/artifacts/977485/1-tdc-sh/stdout
On Tue, 4 Feb 2025 11:37:03 +0000 Simon Horman wrote: > On Mon, Feb 03, 2025 at 04:58:39PM -0800, Cong Wang wrote: > > From: Quang Le <quanglex97@gmail.com> > > > > When limit == 0, pfifo_tail_enqueue() must drop new packet and > > increase dropped packets count of the qdisc. > > > > All test results: > > > > 1..16 > > ok 1 a519 - Add bfifo qdisc with system default parameters on egress > > ok 2 585c - Add pfifo qdisc with system default parameters on egress > > ok 3 a86e - Add bfifo qdisc with system default parameters on egress with handle of maximum value > > ok 4 9ac8 - Add bfifo qdisc on egress with queue size of 3000 bytes > > ok 5 f4e6 - Add pfifo qdisc on egress with queue size of 3000 packets > > ok 6 b1b1 - Add bfifo qdisc with system default parameters on egress with invalid handle exceeding maximum value > > ok 7 8d5e - Add bfifo qdisc on egress with unsupported argument > > ok 8 7787 - Add pfifo qdisc on egress with unsupported argument > > ok 9 c4b6 - Replace bfifo qdisc on egress with new queue size > > ok 10 3df6 - Replace pfifo qdisc on egress with new queue size > > ok 11 7a67 - Add bfifo qdisc on egress with queue size in invalid format > > ok 12 1298 - Add duplicate bfifo qdisc on egress > > ok 13 45a0 - Delete nonexistent bfifo qdisc > > ok 14 972b - Add prio qdisc on egress with invalid format for handles > > ok 15 4d39 - Delete bfifo qdisc twice > > ok 16 d774 - Check pfifo_head_drop qdisc enqueue behaviour when limit == 0 > > > > Signed-off-by: Quang Le <quanglex97@gmail.com> > > Signed-off-by: Cong Wang <cong.wang@bytedance.com> > > Hi Cong, > > Unfortunately this test still seems to be failing in the CI. > > # not ok 577 d774 - Check pfifo_head_drop qdisc enqueue behaviour when limit == 0 > # Could not match regex pattern. Verify command output: > # qdisc pfifo_head_drop 1: root refcnt 2 limit 0p > # Sent 0 bytes 0 pkt (dropped 0, overlimits 0 requeues 0) > # backlog 0b 0p requeues 0 > > https://github.com/p4tc-dev/tc-executor/blob/storage/artifacts/977485/1-tdc-sh/stdout This is starting to feel too much like a setup issue. Pedro, would you be able to take this series and investigate why it fails on the TDC runner?
On 04/02/2025 13:46, Jakub Kicinski wrote: > On Tue, 4 Feb 2025 11:37:03 +0000 Simon Horman wrote: >> On Mon, Feb 03, 2025 at 04:58:39PM -0800, Cong Wang wrote: >>> From: Quang Le <quanglex97@gmail.com> >>> >>> When limit == 0, pfifo_tail_enqueue() must drop new packet and >>> increase dropped packets count of the qdisc. >>> >>> All test results: >>> >>> 1..16 >>> ok 1 a519 - Add bfifo qdisc with system default parameters on egress >>> ok 2 585c - Add pfifo qdisc with system default parameters on egress >>> ok 3 a86e - Add bfifo qdisc with system default parameters on egress with handle of maximum value >>> ok 4 9ac8 - Add bfifo qdisc on egress with queue size of 3000 bytes >>> ok 5 f4e6 - Add pfifo qdisc on egress with queue size of 3000 packets >>> ok 6 b1b1 - Add bfifo qdisc with system default parameters on egress with invalid handle exceeding maximum value >>> ok 7 8d5e - Add bfifo qdisc on egress with unsupported argument >>> ok 8 7787 - Add pfifo qdisc on egress with unsupported argument >>> ok 9 c4b6 - Replace bfifo qdisc on egress with new queue size >>> ok 10 3df6 - Replace pfifo qdisc on egress with new queue size >>> ok 11 7a67 - Add bfifo qdisc on egress with queue size in invalid format >>> ok 12 1298 - Add duplicate bfifo qdisc on egress >>> ok 13 45a0 - Delete nonexistent bfifo qdisc >>> ok 14 972b - Add prio qdisc on egress with invalid format for handles >>> ok 15 4d39 - Delete bfifo qdisc twice >>> ok 16 d774 - Check pfifo_head_drop qdisc enqueue behaviour when limit == 0 >>> >>> Signed-off-by: Quang Le <quanglex97@gmail.com> >>> Signed-off-by: Cong Wang <cong.wang@bytedance.com> >> >> Hi Cong, >> >> Unfortunately this test still seems to be failing in the CI. >> >> # not ok 577 d774 - Check pfifo_head_drop qdisc enqueue behaviour when limit == 0 >> # Could not match regex pattern. Verify command output: >> # qdisc pfifo_head_drop 1: root refcnt 2 limit 0p >> # Sent 0 bytes 0 pkt (dropped 0, overlimits 0 requeues 0) >> # backlog 0b 0p requeues 0 >> >> https://github.com/p4tc-dev/tc-executor/blob/storage/artifacts/977485/1-tdc-sh/stdout > > This is starting to feel too much like a setup issue. > Pedro, would you be able to take this series and investigate > why it fails on the TDC runner? It should be OK now
On Tue, 4 Feb 2025 23:21:07 -0300 Pedro Tammela wrote: > > This is starting to feel too much like a setup issue. > > Pedro, would you be able to take this series and investigate > > why it fails on the TDC runner? > > It should be OK now Thank you! Revived in PW, should get into the run 22 min from now.
diff --git a/tools/testing/selftests/tc-testing/tc-tests/qdiscs/fifo.json b/tools/testing/selftests/tc-testing/tc-tests/qdiscs/fifo.json index ae3d286a32b2..6f20d033670d 100644 --- a/tools/testing/selftests/tc-testing/tc-tests/qdiscs/fifo.json +++ b/tools/testing/selftests/tc-testing/tc-tests/qdiscs/fifo.json @@ -313,6 +313,29 @@ "matchPattern": "qdisc bfifo 1: root", "matchCount": "0", "teardown": [ + ] + }, + { + "id": "d774", + "name": "Check pfifo_head_drop qdisc enqueue behaviour when limit == 0", + "category": [ + "qdisc", + "pfifo_head_drop" + ], + "plugins": { + "requires": "nsPlugin" + }, + "setup": [ + "$IP addr add 10.10.10.10/24 dev $DUMMY || true", + "$TC qdisc add dev $DUMMY root handle 1: pfifo_head_drop limit 0", + "$IP link set dev $DUMMY up || true" + ], + "cmdUnderTest": "ping -c2 -W0.01 -I $DUMMY 10.10.10.1", + "expExitCode": "1", + "verifyCmd": "$TC -s qdisc show dev $DUMMY", + "matchPattern": "dropped 2", + "matchCount": "1", + "teardown": [ ] } ]