| Message ID | 20250131112849.120078-2-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | Add RZ/G3E SDHI support | expand |
Hi all, I need to send a patch for fixing the build issue for r9a09g057h48-kakip.dts as this board is introduced in latest renesas-devel/linux-next[1]. I will send next version, after getting some feedback on the current series. arch/arm64/boot/dts/renesas/r9a09g057h48-kakip.dts:42.36-50.4: ERROR (duplicate_label): /regulator-vccq-sdhi0: Duplicate label 'vqmmc_sdhi0' on /regulator-vccq-sdhi0 and /soc/mmc@15c00000/vqmmc-regulator Cheers, Biju > -----Original Message----- > From: Biju Das <biju.das.jz@bp.renesas.com> > Sent: 31 January 2025 11:29 > Subject: [PATCH v2 5/8] arm64: dts: renesas: r9a09g057: Add support for enabling SDHI internal > regulator > > Add support for enabling SDHI internal regulator, by overriding the status on the board DTS, when > needed. > > While at it, rename the gpio regulator label vqmmc_sdhi1->vqmmc_sdhi1_gpio to avoid conflicts with > internal regulator node names. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > --- > v2: > * New patch. > --- > arch/arm64/boot/dts/renesas/r9a09g057.dtsi | 21 +++++++++++++++++++ > .../dts/renesas/r9a09g057h44-rzv2h-evk.dts | 4 ++-- > 2 files changed, 23 insertions(+), 2 deletions(-) >
Hi Biju, 2025年2月4日(火) 18:48 Biju Das <biju.das.jz@bp.renesas.com>: > > Hi all, > > I need to send a patch for fixing the build issue for r9a09g057h48-kakip.dts > as this board is introduced in latest renesas-devel/linux-next[1]. > > I will send next version, after getting some feedback on the current series. > > arch/arm64/boot/dts/renesas/r9a09g057h48-kakip.dts:42.36-50.4: ERROR (duplicate_label): /regulator-vccq-sdhi0: Duplicate label 'vqmmc_sdhi0' on /regulator-vccq-sdhi0 and /soc/mmc@15c00000/vqmmc-regulator > You may have already made a patch, but I also created a patch and confirmed working. diff --git a/arch/arm64/boot/dts/renesas/r9a09g057h48-kakip.dts b/arch/arm64/boot/dts/renesas/r9a09g057h48-kakip.dts index d2586d278769e2..090d9c69fd75ec 100644 --- a/arch/arm64/boot/dts/renesas/r9a09g057h48-kakip.dts +++ b/arch/arm64/boot/dts/renesas/r9a09g057h48-kakip.dts @@ -39,7 +39,7 @@ reg_3p3v: regulator-3v3 { regulator-always-on; }; - vqmmc_sdhi0: regulator-vccq-sdhi0 { + vqmmc_sdhi0_gpio: regulator-vccq-sdhi0 { compatible = "regulator-gpio"; regulator-name = "SDHI0 VccQ"; gpios = <&pinctrl RZV2H_GPIO(A, 0) GPIO_ACTIVE_HIGH>; @@ -129,7 +129,7 @@ &sdhi0 { pinctrl-0 = <&sdhi0_pins>; pinctrl-names = "default"; vmmc-supply = <®_3p3v>; - vqmmc-supply = <&vqmmc_sdhi0>; + vqmmc-supply = <&vqmmc_sdhi0_gpio>; bus-width = <4>; status = "okay"; > Cheers, > Biju Best regards, Nobuhiro
Hi Nobuhiro Iwamatsu, > -----Original Message----- > From: Nobuhiro Iwamatsu <iwamatsu@nigauri.org> > Sent: 05 February 2025 07:01 > Subject: Re: [PATCH v2 5/8] arm64: dts: renesas: r9a09g057: Add support for enabling SDHI internal > regulator > > Hi Biju, > > > 2025年2月4日(火) 18:48 Biju Das <biju.das.jz@bp.renesas.com>: > > > > Hi all, > > > > I need to send a patch for fixing the build issue for > > r9a09g057h48-kakip.dts as this board is introduced in latest renesas-devel/linux-next[1]. > > > > I will send next version, after getting some feedback on the current series. > > > > arch/arm64/boot/dts/renesas/r9a09g057h48-kakip.dts:42.36-50.4: ERROR > > (duplicate_label): /regulator-vccq-sdhi0: Duplicate label > > 'vqmmc_sdhi0' on /regulator-vccq-sdhi0 and > > /soc/mmc@15c00000/vqmmc-regulator > > > > You may have already made a patch, but I also created a patch and confirmed working. Yes, In this case I will add your Tested by tag while sending new version. Cheers, Biju
diff --git a/arch/arm64/boot/dts/renesas/r9a09g057.dtsi b/arch/arm64/boot/dts/renesas/r9a09g057.dtsi index f7a2f8ca864f..3b8dae0b2eb6 100644 --- a/arch/arm64/boot/dts/renesas/r9a09g057.dtsi +++ b/arch/arm64/boot/dts/renesas/r9a09g057.dtsi @@ -602,6 +602,13 @@ sdhi0: mmc@15c00000 { resets = <&cpg 0xa7>; power-domains = <&cpg>; status = "disabled"; + + vqmmc_sdhi0: vqmmc-regulator { + regulator-name = "SDHI0-VQMMC"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3300000>; + status = "disabled"; + }; }; sdhi1: mmc@15c10000 { @@ -615,6 +622,13 @@ sdhi1: mmc@15c10000 { resets = <&cpg 0xa8>; power-domains = <&cpg>; status = "disabled"; + + vqmmc_sdhi1: vqmmc-regulator { + regulator-name = "SDHI1-VQMMC"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3300000>; + status = "disabled"; + }; }; sdhi2: mmc@15c20000 { @@ -628,6 +642,13 @@ sdhi2: mmc@15c20000 { resets = <&cpg 0xa9>; power-domains = <&cpg>; status = "disabled"; + + vqmmc_sdhi2: vqmmc-regulator { + regulator-name = "SDHI2-VQMMC"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3300000>; + status = "disabled"; + }; }; }; diff --git a/arch/arm64/boot/dts/renesas/r9a09g057h44-rzv2h-evk.dts b/arch/arm64/boot/dts/renesas/r9a09g057h44-rzv2h-evk.dts index 0b705c987b6c..1ecea3872e94 100644 --- a/arch/arm64/boot/dts/renesas/r9a09g057h44-rzv2h-evk.dts +++ b/arch/arm64/boot/dts/renesas/r9a09g057h44-rzv2h-evk.dts @@ -53,7 +53,7 @@ reg_3p3v: regulator1 { regulator-always-on; }; - vqmmc_sdhi1: regulator-vccq-sdhi1 { + vqmmc_sdhi1_gpio: regulator-vccq-sdhi1 { compatible = "regulator-gpio"; regulator-name = "SDHI1 VccQ"; gpios = <&pinctrl RZV2H_GPIO(A, 2) GPIO_ACTIVE_HIGH>; @@ -244,7 +244,7 @@ &sdhi1 { pinctrl-1 = <&sdhi1_pins>; pinctrl-names = "default", "state_uhs"; vmmc-supply = <®_3p3v>; - vqmmc-supply = <&vqmmc_sdhi1>; + vqmmc-supply = <&vqmmc_sdhi1_gpio>; bus-width = <4>; sd-uhs-sdr50; sd-uhs-sdr104;
Add support for enabling SDHI internal regulator, by overriding the status on the board DTS, when needed. While at it, rename the gpio regulator label vqmmc_sdhi1->vqmmc_sdhi1_gpio to avoid conflicts with internal regulator node names. Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- v2: * New patch. --- arch/arm64/boot/dts/renesas/r9a09g057.dtsi | 21 +++++++++++++++++++ .../dts/renesas/r9a09g057h44-rzv2h-evk.dts | 4 ++-- 2 files changed, 23 insertions(+), 2 deletions(-)