| Message ID | 20250113-jag-bringup_fixes-v1-11-fb28030b1f26@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | kdevops: Various fixes | expand |
On Mon, Jan 13, 2025 at 12:53:09PM +0100, Joel Granados wrote: > Avoid "file not found" failures related to relative paths in pool paths. > > Signed-off-by: Joel Granados <joel.granados@kernel.org> Reviewed-by: Daniel Gomez <da.gomez@samsung.com> > --- > scripts/get_libvirsh_pool_path.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/get_libvirsh_pool_path.sh b/scripts/get_libvirsh_pool_path.sh > index 92901a8..c036777 100755 > --- a/scripts/get_libvirsh_pool_path.sh > +++ b/scripts/get_libvirsh_pool_path.sh > @@ -17,7 +17,7 @@ POOL_LIST="" > get_pool_vars > VIRSH_WORKS=$(virsh_works) > if [[ "$VIRSH_WORKS" == "n" ]]; then > - echo "default" > + echo "$(pwd)/default" > exit > fi > > > -- > 2.44.2 > >
On Thu, Jan 30, 2025 at 10:19:38AM +0100, Daniel Gomez wrote: > On Mon, Jan 13, 2025 at 12:53:09PM +0100, Joel Granados wrote: > > Avoid "file not found" failures related to relative paths in pool paths. > > > > Signed-off-by: Joel Granados <joel.granados@kernel.org> > > Reviewed-by: Daniel Gomez <da.gomez@samsung.com> Do you think this one can go into mainline without the rest? It looks like it is doing a service by selecting the current dir > > > --- > > scripts/get_libvirsh_pool_path.sh | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/scripts/get_libvirsh_pool_path.sh b/scripts/get_libvirsh_pool_path.sh > > index 92901a8..c036777 100755 > > --- a/scripts/get_libvirsh_pool_path.sh > > +++ b/scripts/get_libvirsh_pool_path.sh > > @@ -17,7 +17,7 @@ POOL_LIST="" > > get_pool_vars > > VIRSH_WORKS=$(virsh_works) > > if [[ "$VIRSH_WORKS" == "n" ]]; then > > - echo "default" > > + echo "$(pwd)/default" > > exit > > fi > > > > > > -- > > 2.44.2 > > > >
On Fri, Jan 31, 2025 at 05:49:56PM +0100, Joel Granados wrote: > On Thu, Jan 30, 2025 at 10:19:38AM +0100, Daniel Gomez wrote: > > On Mon, Jan 13, 2025 at 12:53:09PM +0100, Joel Granados wrote: > > > Avoid "file not found" failures related to relative paths in pool paths. > > > > > > Signed-off-by: Joel Granados <joel.granados@kernel.org> > > > > Reviewed-by: Daniel Gomez <da.gomez@samsung.com> > Do you think this one can go into mainline without the rest? It looks like it is > doing a service by selecting the current dir Agree. And applied! > > > > > --- > > > scripts/get_libvirsh_pool_path.sh | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/scripts/get_libvirsh_pool_path.sh b/scripts/get_libvirsh_pool_path.sh > > > index 92901a8..c036777 100755 > > > --- a/scripts/get_libvirsh_pool_path.sh > > > +++ b/scripts/get_libvirsh_pool_path.sh > > > @@ -17,7 +17,7 @@ POOL_LIST="" > > > get_pool_vars > > > VIRSH_WORKS=$(virsh_works) > > > if [[ "$VIRSH_WORKS" == "n" ]]; then > > > - echo "default" > > > + echo "$(pwd)/default" > > > exit > > > fi > > > > > > > > > -- > > > 2.44.2 > > > > > > > > -- > > Joel Granados
On Fri, Jan 31, 2025 at 10:34:51PM +0100, Daniel Gomez wrote: > On Fri, Jan 31, 2025 at 05:49:56PM +0100, Joel Granados wrote: > > On Thu, Jan 30, 2025 at 10:19:38AM +0100, Daniel Gomez wrote: > > > On Mon, Jan 13, 2025 at 12:53:09PM +0100, Joel Granados wrote: > > > > Avoid "file not found" failures related to relative paths in pool paths. > > > > > > > > Signed-off-by: Joel Granados <joel.granados@kernel.org> > > > > > > Reviewed-by: Daniel Gomez <da.gomez@samsung.com> > > Do you think this one can go into mainline without the rest? It looks like it is > > doing a service by selecting the current dir > > Agree. And applied! And thanks! Also, Debian testing (trixie) host needs a networking fix [1]. If it's okay with you, I'll split your patch [2] to install guestfs-tools and isc-dhcp-client [1] in a separate bringup/guestfs task. I think we can also merge the dependencies in your patch [3]. What do you think? These fixes will not solve any current kdevops CI issues but users setting up a Debian testing host for kdevops. [1] https://lore.kernel.org/kdevops/4298260a-03d4-4d50-a89e-087b74e0be79@oracle.com/T/#m71e67f36a13c59f8161949b83e1a280000fe7eae [2] ansible: libvirt_user: Install additional pkgs for debian [3] Makefile: Add virsh and libvirtd to minimum dependenciesj > > > > > > > > --- > > > > scripts/get_libvirsh_pool_path.sh | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/scripts/get_libvirsh_pool_path.sh b/scripts/get_libvirsh_pool_path.sh > > > > index 92901a8..c036777 100755 > > > > --- a/scripts/get_libvirsh_pool_path.sh > > > > +++ b/scripts/get_libvirsh_pool_path.sh > > > > @@ -17,7 +17,7 @@ POOL_LIST="" > > > > get_pool_vars > > > > VIRSH_WORKS=$(virsh_works) > > > > if [[ "$VIRSH_WORKS" == "n" ]]; then > > > > - echo "default" > > > > + echo "$(pwd)/default" > > > > exit > > > > fi > > > > > > > > > > > > -- > > > > 2.44.2 > > > > > > > > > > > > -- > > > > Joel Granados
On Fri, Jan 31, 2025 at 10:34:50PM +0100, Daniel Gomez wrote: > On Fri, Jan 31, 2025 at 05:49:56PM +0100, Joel Granados wrote: > > On Thu, Jan 30, 2025 at 10:19:38AM +0100, Daniel Gomez wrote: > > > On Mon, Jan 13, 2025 at 12:53:09PM +0100, Joel Granados wrote: > > > > Avoid "file not found" failures related to relative paths in pool paths. > > > > > > > > Signed-off-by: Joel Granados <joel.granados@kernel.org> > > > > > > Reviewed-by: Daniel Gomez <da.gomez@samsung.com> > > Do you think this one can go into mainline without the rest? It looks like it is > > doing a service by selecting the current dir > > Agree. And applied! Awesome. Thx! > > > > > > > > --- > > > > scripts/get_libvirsh_pool_path.sh | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/scripts/get_libvirsh_pool_path.sh b/scripts/get_libvirsh_pool_path.sh > > > > index 92901a8..c036777 100755 > > > > --- a/scripts/get_libvirsh_pool_path.sh > > > > +++ b/scripts/get_libvirsh_pool_path.sh > > > > @@ -17,7 +17,7 @@ POOL_LIST="" > > > > get_pool_vars > > > > VIRSH_WORKS=$(virsh_works) > > > > if [[ "$VIRSH_WORKS" == "n" ]]; then > > > > - echo "default" > > > > + echo "$(pwd)/default" > > > > exit > > > > fi > > > > > > > > > > > > -- > > > > 2.44.2 > > > > > > > > > > > > -- > > > > Joel Granados
On Mon, Feb 03, 2025 at 10:36:42AM +0100, Daniel Gomez wrote: > On Fri, Jan 31, 2025 at 10:34:51PM +0100, Daniel Gomez wrote: > > On Fri, Jan 31, 2025 at 05:49:56PM +0100, Joel Granados wrote: > > > On Thu, Jan 30, 2025 at 10:19:38AM +0100, Daniel Gomez wrote: > > > > On Mon, Jan 13, 2025 at 12:53:09PM +0100, Joel Granados wrote: > > > > > Avoid "file not found" failures related to relative paths in pool paths. > > > > > > > > > > Signed-off-by: Joel Granados <joel.granados@kernel.org> > > > > > > > > Reviewed-by: Daniel Gomez <da.gomez@samsung.com> > > > Do you think this one can go into mainline without the rest? It looks like it is > > > doing a service by selecting the current dir > > > > Agree. And applied! > > And thanks! > > Also, Debian testing (trixie) host needs a networking fix [1]. If it's > okay with you, I'll split your patch [2] to install guestfs-tools and > isc-dhcp-client [1] in a separate bringup/guestfs task. I think we can > also merge the dependencies in your patch [3]. What do you think? > > These fixes will not solve any current kdevops CI issues but users > setting up a Debian testing host for kdevops. > Sure. Go for it! I'll remove those 2 patches [2] and [3] from my radar and let you push them through. Best > [1] https://lore.kernel.org/kdevops/4298260a-03d4-4d50-a89e-087b74e0be79@oracle.com/T/#m71e67f36a13c59f8161949b83e1a280000fe7eae > [2] ansible: libvirt_user: Install additional pkgs for debian > [3] Makefile: Add virsh and libvirtd to minimum dependenciesj > > > > > > > > > > > --- > > > > > scripts/get_libvirsh_pool_path.sh | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > diff --git a/scripts/get_libvirsh_pool_path.sh b/scripts/get_libvirsh_pool_path.sh > > > > > index 92901a8..c036777 100755 > > > > > --- a/scripts/get_libvirsh_pool_path.sh > > > > > +++ b/scripts/get_libvirsh_pool_path.sh > > > > > @@ -17,7 +17,7 @@ POOL_LIST="" > > > > > get_pool_vars > > > > > VIRSH_WORKS=$(virsh_works) > > > > > if [[ "$VIRSH_WORKS" == "n" ]]; then > > > > > - echo "default" > > > > > + echo "$(pwd)/default" > > > > > exit > > > > > fi > > > > > > > > > > > > > > > -- > > > > > 2.44.2 > > > > > > > > > > > > > > > > -- > > > > > > Joel Granados
diff --git a/scripts/get_libvirsh_pool_path.sh b/scripts/get_libvirsh_pool_path.sh index 92901a8..c036777 100755 --- a/scripts/get_libvirsh_pool_path.sh +++ b/scripts/get_libvirsh_pool_path.sh @@ -17,7 +17,7 @@ POOL_LIST="" get_pool_vars VIRSH_WORKS=$(virsh_works) if [[ "$VIRSH_WORKS" == "n" ]]; then - echo "default" + echo "$(pwd)/default" exit fi
Avoid "file not found" failures related to relative paths in pool paths. Signed-off-by: Joel Granados <joel.granados@kernel.org> --- scripts/get_libvirsh_pool_path.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)