| Message ID | 20250113-jag-bringup_fixes-v1-3-fb28030b1f26@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | kdevops: Various fixes | expand |
On Mon, Jan 13, 2025 at 12:53:01PM +0100, Joel Granados wrote: > Install the following additional packages for debian > * libvirt-daemon-config-network: So we have networks/defaults.xml on the > system and are sure we are able to generate the virtual network if > needed. > * guestfs-tools: For when we use guestfs directory. > > Signed-off-by: Joel Granados <joel.granados@kernel.org> > --- > playbooks/roles/libvirt_user/tasks/install-deps/debian/main.yml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/playbooks/roles/libvirt_user/tasks/install-deps/debian/main.yml b/playbooks/roles/libvirt_user/tasks/install-deps/debian/main.yml > index 792597f..98d0007 100644 > --- a/playbooks/roles/libvirt_user/tasks/install-deps/debian/main.yml > +++ b/playbooks/roles/libvirt_user/tasks/install-deps/debian/main.yml > @@ -13,10 +13,12 @@ > name: > - libvirt-daemon > - libvirt-daemon-system > + - libvirt-daemon-config-network > - libvirt-clients > - qemu-kvm > - qemu-system-x86 > - qemu-utils > + - guestfs-tools My suggestion in this thread [1] is to have a separate task to install libguestfs dependencies. They are technically not libvirt dependencies. [1] https://lore.kernel.org/kdevops/20250130072216.h6rjjglhf2kgr5ad@AALNPWDAGOMEZ1.aal.scsc.local/T/#u > state: present > tags: install > > > -- > 2.44.2 > >
On Thu, Jan 30, 2025 at 10:18:32AM +0100, Daniel Gomez wrote: > On Mon, Jan 13, 2025 at 12:53:01PM +0100, Joel Granados wrote: > > Install the following additional packages for debian > > * libvirt-daemon-config-network: So we have networks/defaults.xml on the > > system and are sure we are able to generate the virtual network if > > needed. > > * guestfs-tools: For when we use guestfs directory. > > > > Signed-off-by: Joel Granados <joel.granados@kernel.org> > > --- > > playbooks/roles/libvirt_user/tasks/install-deps/debian/main.yml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/playbooks/roles/libvirt_user/tasks/install-deps/debian/main.yml b/playbooks/roles/libvirt_user/tasks/install-deps/debian/main.yml > > index 792597f..98d0007 100644 > > --- a/playbooks/roles/libvirt_user/tasks/install-deps/debian/main.yml > > +++ b/playbooks/roles/libvirt_user/tasks/install-deps/debian/main.yml > > @@ -13,10 +13,12 @@ > > name: > > - libvirt-daemon > > - libvirt-daemon-system > > + - libvirt-daemon-config-network > > - libvirt-clients > > - qemu-kvm > > - qemu-system-x86 > > - qemu-utils > > + - guestfs-tools > > My suggestion in this thread [1] is to have a separate task to install > libguestfs dependencies. They are technically not libvirt dependencies. > > [1] https://lore.kernel.org/kdevops/20250130072216.h6rjjglhf2kgr5ad@AALNPWDAGOMEZ1.aal.scsc.local/T/#u I'll drop this one. > > > state: present > > tags: install > > > > > > -- > > 2.44.2 > > > >
diff --git a/playbooks/roles/libvirt_user/tasks/install-deps/debian/main.yml b/playbooks/roles/libvirt_user/tasks/install-deps/debian/main.yml index 792597f..98d0007 100644 --- a/playbooks/roles/libvirt_user/tasks/install-deps/debian/main.yml +++ b/playbooks/roles/libvirt_user/tasks/install-deps/debian/main.yml @@ -13,10 +13,12 @@ name: - libvirt-daemon - libvirt-daemon-system + - libvirt-daemon-config-network - libvirt-clients - qemu-kvm - qemu-system-x86 - qemu-utils + - guestfs-tools state: present tags: install
Install the following additional packages for debian * libvirt-daemon-config-network: So we have networks/defaults.xml on the system and are sure we are able to generate the virtual network if needed. * guestfs-tools: For when we use guestfs directory. Signed-off-by: Joel Granados <joel.granados@kernel.org> --- playbooks/roles/libvirt_user/tasks/install-deps/debian/main.yml | 2 ++ 1 file changed, 2 insertions(+)