| Message ID | 20250207-prime_numbers-kunit-convert-v1-1-6067f2b7c713@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | lib/prime_numbers: convert self-test to KUnit | expand |
On Sat, 8 Feb 2025 at 06:33, Tamir Duberstein <tamird@gmail.com> wrote: > > This Makefile has been dead code since it was added in commit > 7fcc9b53216c ("lib/math: Add int_pow test suite"); the tests worked > because of the duplicated rules in the parent directory's Makefile. Wire > up tests/Makefile and remove the duplication. > > Fixes: 7fcc9b53216c ("lib/math: Add int_pow test suite") > Signed-off-by: Tamir Duberstein <tamird@gmail.com> > --- Thanks for fixing this. Reviewed-by: David Gow <davidgow@google.com> -- David > lib/math/Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/math/Makefile b/lib/math/Makefile > index 853f023ae537..d390da9a59fe 100644 > --- a/lib/math/Makefile > +++ b/lib/math/Makefile > @@ -5,8 +5,8 @@ obj-$(CONFIG_CORDIC) += cordic.o > obj-$(CONFIG_PRIME_NUMBERS) += prime_numbers.o > obj-$(CONFIG_RATIONAL) += rational.o > > -obj-$(CONFIG_INT_POW_TEST) += tests/int_pow_kunit.o > obj-$(CONFIG_TEST_DIV64) += test_div64.o > obj-$(CONFIG_TEST_MULDIV64) += test_mul_u64_u64_div_u64.o > obj-$(CONFIG_RATIONAL_KUNIT_TEST) += rational-test.o > -obj-$(CONFIG_INT_SQRT_KUNIT_TEST) += tests/int_sqrt_kunit.o > \ No newline at end of file > + > +obj-y += tests/ > > -- > 2.48.1 >
diff --git a/lib/math/Makefile b/lib/math/Makefile index 853f023ae537..d390da9a59fe 100644 --- a/lib/math/Makefile +++ b/lib/math/Makefile @@ -5,8 +5,8 @@ obj-$(CONFIG_CORDIC) += cordic.o obj-$(CONFIG_PRIME_NUMBERS) += prime_numbers.o obj-$(CONFIG_RATIONAL) += rational.o -obj-$(CONFIG_INT_POW_TEST) += tests/int_pow_kunit.o obj-$(CONFIG_TEST_DIV64) += test_div64.o obj-$(CONFIG_TEST_MULDIV64) += test_mul_u64_u64_div_u64.o obj-$(CONFIG_RATIONAL_KUNIT_TEST) += rational-test.o -obj-$(CONFIG_INT_SQRT_KUNIT_TEST) += tests/int_sqrt_kunit.o \ No newline at end of file + +obj-y += tests/
This Makefile has been dead code since it was added in commit 7fcc9b53216c ("lib/math: Add int_pow test suite"); the tests worked because of the duplicated rules in the parent directory's Makefile. Wire up tests/Makefile and remove the duplication. Fixes: 7fcc9b53216c ("lib/math: Add int_pow test suite") Signed-off-by: Tamir Duberstein <tamird@gmail.com> --- lib/math/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)