| Message ID | 20250209145708.106914-1-marek.vasut+renesas@mailbox.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7284922f3e4fa285dff1b8bb593aa9a0b8458f30 |
| Headers | show |
| Series | USB: cdc-acm: Fill in Renesas R-Car D3 USB Download mode quirk | expand |
On Sun, Feb 09, 2025 at 03:56:11PM +0100, Marek Vasut wrote: > Add Renesas R-Car D3 USB Download mode quirk and update comments > on all the other Renesas R-Car USB Download mode quirks to discern > them from each other. This follows R-Car Series, 3rd Generation > reference manual Rev.2.00 chapter 19.2.8 USB download mode . > > Fixes: 6d853c9e4104 ("usb: cdc-acm: Add DISABLE_ECHO for Renesas USB Download mode") > Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> > --- > Cc: Chris Brandt <chris.brandt@renesas.com> > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Oliver Neukum <oneukum@suse.com> > Cc: linux-renesas-soc@vger.kernel.org > Cc: linux-usb@vger.kernel.org > Cc: stable@vger.kernel.org > --- > drivers/usb/class/cdc-acm.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c > index 6b37d1c47fce1..06c7d86c5449e 100644 > --- a/drivers/usb/class/cdc-acm.c > +++ b/drivers/usb/class/cdc-acm.c > @@ -1727,13 +1727,16 @@ static const struct usb_device_id acm_ids[] = { > { USB_DEVICE(0x0870, 0x0001), /* Metricom GS Modem */ > .driver_info = NO_UNION_NORMAL, /* has no union descriptor */ > }, > - { USB_DEVICE(0x045b, 0x023c), /* Renesas USB Download mode */ > + { USB_DEVICE(0x045b, 0x023c), /* Renesas R-Car H3 USB Download mode */ > .driver_info = DISABLE_ECHO, /* Don't echo banner */ > }, > - { USB_DEVICE(0x045b, 0x0248), /* Renesas USB Download mode */ > + { USB_DEVICE(0x045b, 0x0247), /* Renesas R-Car D3 USB Download mode */ > .driver_info = DISABLE_ECHO, /* Don't echo banner */ > }, > - { USB_DEVICE(0x045b, 0x024D), /* Renesas USB Download mode */ > + { USB_DEVICE(0x045b, 0x0248), /* Renesas R-Car M3-N USB Download mode */ > + .driver_info = DISABLE_ECHO, /* Don't echo banner */ > + }, > + { USB_DEVICE(0x045b, 0x024D), /* Renesas R-Car E3 USB Download mode */ > .driver_info = DISABLE_ECHO, /* Don't echo banner */ > }, > { USB_DEVICE(0x0e8d, 0x0003), /* FIREFLY, MediaTek Inc; andrey.arapov@gmail.com */ > -- > 2.47.2 > > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You have marked a patch with a "Fixes:" tag for a commit that is in an older released kernel, yet you do not have a cc: stable line in the signed-off-by area at all, which means that the patch will not be applied to any older kernel releases. To properly fix this, please follow the documented rules in the Documentation/process/stable-kernel-rules.rst file for how to resolve this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot
On 2/9/25 4:44 PM, Greg Kroah-Hartman wrote: > On Sun, Feb 09, 2025 at 03:56:11PM +0100, Marek Vasut wrote: >> Add Renesas R-Car D3 USB Download mode quirk and update comments >> on all the other Renesas R-Car USB Download mode quirks to discern >> them from each other. This follows R-Car Series, 3rd Generation >> reference manual Rev.2.00 chapter 19.2.8 USB download mode . >> >> Fixes: 6d853c9e4104 ("usb: cdc-acm: Add DISABLE_ECHO for Renesas USB Download mode") >> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> >> --- >> Cc: Chris Brandt <chris.brandt@renesas.com> >> Cc: Geert Uytterhoeven <geert+renesas@glider.be> >> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> >> Cc: Oliver Neukum <oneukum@suse.com> >> Cc: linux-renesas-soc@vger.kernel.org >> Cc: linux-usb@vger.kernel.org >> Cc: stable@vger.kernel.org ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [...] > You are receiving this message because of the following common error(s) > as indicated below: > > - You have marked a patch with a "Fixes:" tag for a commit that is in an > older released kernel, yet you do not have a cc: stable line in the > signed-off-by area at all, which means that the patch will not be > applied to any older kernel releases. To properly fix this, please > follow the documented rules in the > Documentation/process/stable-kernel-rules.rst file for how to resolve > this. Cc: stable is right there, below --- so it wouldn't become part of the commit message when the patch is applied. Is that OK too ?
On Sun, Feb 09, 2025 at 07:10:47PM +0100, Marek Vasut wrote: > On 2/9/25 4:44 PM, Greg Kroah-Hartman wrote: > > On Sun, Feb 09, 2025 at 03:56:11PM +0100, Marek Vasut wrote: > > > Add Renesas R-Car D3 USB Download mode quirk and update comments > > > on all the other Renesas R-Car USB Download mode quirks to discern > > > them from each other. This follows R-Car Series, 3rd Generation > > > reference manual Rev.2.00 chapter 19.2.8 USB download mode . > > > > > > Fixes: 6d853c9e4104 ("usb: cdc-acm: Add DISABLE_ECHO for Renesas USB Download mode") > > > Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> > > > --- > > > Cc: Chris Brandt <chris.brandt@renesas.com> > > > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > Cc: Oliver Neukum <oneukum@suse.com> > > > Cc: linux-renesas-soc@vger.kernel.org > > > Cc: linux-usb@vger.kernel.org > > > Cc: stable@vger.kernel.org > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > [...] > > > You are receiving this message because of the following common error(s) > > as indicated below: > > > > - You have marked a patch with a "Fixes:" tag for a commit that is in an > > older released kernel, yet you do not have a cc: stable line in the > > signed-off-by area at all, which means that the patch will not be > > applied to any older kernel releases. To properly fix this, please > > follow the documented rules in the > > Documentation/process/stable-kernel-rules.rst file for how to resolve > > this. > > Cc: stable is right there, below --- so it wouldn't become part of the > commit message when the patch is applied. Is that OK too ? No that is not, it needs to become part of the commit message, as per the kernel documentation. thanks, greg k-h
Hi Marek, On Sun, 9 Feb 2025 at 15:57, Marek Vasut <marek.vasut+renesas@mailbox.org> wrote: > Add Renesas R-Car D3 USB Download mode quirk and update comments > on all the other Renesas R-Car USB Download mode quirks to discern > them from each other. This follows R-Car Series, 3rd Generation > reference manual Rev.2.00 chapter 19.2.8 USB download mode . > > Fixes: 6d853c9e4104 ("usb: cdc-acm: Add DISABLE_ECHO for Renesas USB Download mode") > Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> Thanks for your patch! Still true in Rev.2.40 of the documentation ;-) Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index 6b37d1c47fce1..06c7d86c5449e 100644 --- a/drivers/usb/class/cdc-acm.c +++ b/drivers/usb/class/cdc-acm.c @@ -1727,13 +1727,16 @@ static const struct usb_device_id acm_ids[] = { { USB_DEVICE(0x0870, 0x0001), /* Metricom GS Modem */ .driver_info = NO_UNION_NORMAL, /* has no union descriptor */ }, - { USB_DEVICE(0x045b, 0x023c), /* Renesas USB Download mode */ + { USB_DEVICE(0x045b, 0x023c), /* Renesas R-Car H3 USB Download mode */ .driver_info = DISABLE_ECHO, /* Don't echo banner */ }, - { USB_DEVICE(0x045b, 0x0248), /* Renesas USB Download mode */ + { USB_DEVICE(0x045b, 0x0247), /* Renesas R-Car D3 USB Download mode */ .driver_info = DISABLE_ECHO, /* Don't echo banner */ }, - { USB_DEVICE(0x045b, 0x024D), /* Renesas USB Download mode */ + { USB_DEVICE(0x045b, 0x0248), /* Renesas R-Car M3-N USB Download mode */ + .driver_info = DISABLE_ECHO, /* Don't echo banner */ + }, + { USB_DEVICE(0x045b, 0x024D), /* Renesas R-Car E3 USB Download mode */ .driver_info = DISABLE_ECHO, /* Don't echo banner */ }, { USB_DEVICE(0x0e8d, 0x0003), /* FIREFLY, MediaTek Inc; andrey.arapov@gmail.com */
Add Renesas R-Car D3 USB Download mode quirk and update comments on all the other Renesas R-Car USB Download mode quirks to discern them from each other. This follows R-Car Series, 3rd Generation reference manual Rev.2.00 chapter 19.2.8 USB download mode . Fixes: 6d853c9e4104 ("usb: cdc-acm: Add DISABLE_ECHO for Renesas USB Download mode") Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> --- Cc: Chris Brandt <chris.brandt@renesas.com> Cc: Geert Uytterhoeven <geert+renesas@glider.be> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Oliver Neukum <oneukum@suse.com> Cc: linux-renesas-soc@vger.kernel.org Cc: linux-usb@vger.kernel.org Cc: stable@vger.kernel.org --- drivers/usb/class/cdc-acm.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)