| Message ID | 20250203162511.911946-2-Basavaraj.Natikar@amd.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Fixes to the AE4DMA | expand |
On 03-02-25, 21:55, Basavaraj Natikar wrote: > Two previously used PCI IDs are deprecated and should not be used for > AE4DMA. Hence, remove as they are unsupported for AE4DMA. > > Fixes: 90a30e268d9b ("dmaengine: ae4dma: Add AMD ae4dma controller driver") Why is this a fix? > Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com> > --- > drivers/dma/amd/ae4dma/ae4dma-pci.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/dma/amd/ae4dma/ae4dma-pci.c b/drivers/dma/amd/ae4dma/ae4dma-pci.c > index aad0dc4294a3..7f96843f5215 100644 > --- a/drivers/dma/amd/ae4dma/ae4dma-pci.c > +++ b/drivers/dma/amd/ae4dma/ae4dma-pci.c > @@ -137,8 +137,6 @@ static void ae4_pci_remove(struct pci_dev *pdev) > } > > static const struct pci_device_id ae4_pci_table[] = { > - { PCI_VDEVICE(AMD, 0x14C8), }, > - { PCI_VDEVICE(AMD, 0x14DC), }, > { PCI_VDEVICE(AMD, 0x149B), }, > /* Last entry must be zero */ > { 0, } > -- > 2.25.1
On 2/10/2025 7:29 PM, Vinod Koul wrote: > On 03-02-25, 21:55, Basavaraj Natikar wrote: >> Two previously used PCI IDs are deprecated and should not be used for >> AE4DMA. Hence, remove as they are unsupported for AE4DMA. >> >> Fixes: 90a30e268d9b ("dmaengine: ae4dma: Add AMD ae4dma controller driver") > Why is this a fix? Yes, as these changes are needed to work only on supported devices. If it loads on those PCI IDs now, since they are unsupported, the probe will fail. Thanks, -- Basavaraj > >> Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com> >> --- >> drivers/dma/amd/ae4dma/ae4dma-pci.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/dma/amd/ae4dma/ae4dma-pci.c b/drivers/dma/amd/ae4dma/ae4dma-pci.c >> index aad0dc4294a3..7f96843f5215 100644 >> --- a/drivers/dma/amd/ae4dma/ae4dma-pci.c >> +++ b/drivers/dma/amd/ae4dma/ae4dma-pci.c >> @@ -137,8 +137,6 @@ static void ae4_pci_remove(struct pci_dev *pdev) >> } >> >> static const struct pci_device_id ae4_pci_table[] = { >> - { PCI_VDEVICE(AMD, 0x14C8), }, >> - { PCI_VDEVICE(AMD, 0x14DC), }, >> { PCI_VDEVICE(AMD, 0x149B), }, >> /* Last entry must be zero */ >> { 0, } >> -- >> 2.25.1
diff --git a/drivers/dma/amd/ae4dma/ae4dma-pci.c b/drivers/dma/amd/ae4dma/ae4dma-pci.c index aad0dc4294a3..7f96843f5215 100644 --- a/drivers/dma/amd/ae4dma/ae4dma-pci.c +++ b/drivers/dma/amd/ae4dma/ae4dma-pci.c @@ -137,8 +137,6 @@ static void ae4_pci_remove(struct pci_dev *pdev) } static const struct pci_device_id ae4_pci_table[] = { - { PCI_VDEVICE(AMD, 0x14C8), }, - { PCI_VDEVICE(AMD, 0x14DC), }, { PCI_VDEVICE(AMD, 0x149B), }, /* Last entry must be zero */ { 0, }
Two previously used PCI IDs are deprecated and should not be used for AE4DMA. Hence, remove as they are unsupported for AE4DMA. Fixes: 90a30e268d9b ("dmaengine: ae4dma: Add AMD ae4dma controller driver") Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com> --- drivers/dma/amd/ae4dma/ae4dma-pci.c | 2 -- 1 file changed, 2 deletions(-)