| Message ID | 20250207140918.7814-6-antoniu.miclaus@analog.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add support for AD485x DAS Family | expand |
On Fri, 7 Feb 2025 16:09:14 +0200 Antoniu Miclaus <antoniu.miclaus@analog.com> wrote: > Add a new compatible and related bindings for the fpga-based > AD485x AXI IP core, a variant of the generic AXI ADC IP. > > The AXI AD485x IP is a very similar HDL (fpga) variant of the > generic AXI ADC IP, intended to control ad485x familiy. Hmm. Should we name this after a specific part? Very unlikely the wildcard will go wrong here because of how specific this binding is anyway but we should perhaps stick to normal rules of no wild cards. > > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> > --- > Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml b/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml > index e1f450b80db2..f1b470f74069 100644 > --- a/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml > @@ -19,11 +19,13 @@ description: | > memory via DMA. > > https://wiki.analog.com/resources/fpga/docs/axi_adc_ip > + https://analogdevicesinc.github.io/hdl/library/axi_ad485x/index.html > > properties: > compatible: > enum: > - adi,axi-adc-10.0.a > + - adi,axi-ad485x > > reg: > maxItems: 1
On Sat, Feb 08, 2025 at 04:20:58PM +0000, Jonathan Cameron wrote: > On Fri, 7 Feb 2025 16:09:14 +0200 > Antoniu Miclaus <antoniu.miclaus@analog.com> wrote: > > > Add a new compatible and related bindings for the fpga-based > > AD485x AXI IP core, a variant of the generic AXI ADC IP. > > > > The AXI AD485x IP is a very similar HDL (fpga) variant of the > > generic AXI ADC IP, intended to control ad485x familiy. > > Hmm. Should we name this after a specific part? Very unlikely > the wildcard will go wrong here because of how specific this > binding is anyway but we should perhaps stick to normal rules > of no wild cards. I am pretty sure we had this discussion about this or other block already and we reached some sort of concensus... which is undocumented in commit msg, so we are doomed to repeat the discussion. Best regards, Krzysztof
On Tue, 11 Feb 2025 09:16:31 +0100 Krzysztof Kozlowski <krzk@kernel.org> wrote: > On Sat, Feb 08, 2025 at 04:20:58PM +0000, Jonathan Cameron wrote: > > On Fri, 7 Feb 2025 16:09:14 +0200 > > Antoniu Miclaus <antoniu.miclaus@analog.com> wrote: > > > > > Add a new compatible and related bindings for the fpga-based > > > AD485x AXI IP core, a variant of the generic AXI ADC IP. > > > > > > The AXI AD485x IP is a very similar HDL (fpga) variant of the > > > generic AXI ADC IP, intended to control ad485x familiy. > > > > Hmm. Should we name this after a specific part? Very unlikely > > the wildcard will go wrong here because of how specific this > > binding is anyway but we should perhaps stick to normal rules > > of no wild cards. > > I am pretty sure we had this discussion about this or other block > already and we reached some sort of concensus... which is undocumented > in commit msg, so we are doomed to repeat the discussion. > Having just seen similar the axi-ad7606x support. I think the key bit I was missing here is that ADI has published the firmware under the name with wild card. If they shoot themselves in the foot in future then fair enough. I'm fine with the wild card though a statement in the commit to make me notice that detail would have been great! Jonathan > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml b/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml index e1f450b80db2..f1b470f74069 100644 --- a/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml +++ b/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml @@ -19,11 +19,13 @@ description: | memory via DMA. https://wiki.analog.com/resources/fpga/docs/axi_adc_ip + https://analogdevicesinc.github.io/hdl/library/axi_ad485x/index.html properties: compatible: enum: - adi,axi-adc-10.0.a + - adi,axi-ad485x reg: maxItems: 1
Add a new compatible and related bindings for the fpga-based AD485x AXI IP core, a variant of the generic AXI ADC IP. The AXI AD485x IP is a very similar HDL (fpga) variant of the generic AXI ADC IP, intended to control ad485x familiy. Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> --- Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml | 2 ++ 1 file changed, 2 insertions(+)