| Message ID | 20250211181356.580800-6-kuba@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0ec023282a9d9487d5f80fd785b0c2e80a40ba43 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | eth: fbnic: report software queue stats | expand |
On Tue, Feb 11, 2025 at 10:13:56AM -0800, Jakub Kicinski wrote: > Looks like recent commit broke the sort order, fix it. > > Signed-off-by: Jakub Kicinski <kuba@kernel.org> > --- > drivers/net/ethernet/meta/fbnic/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/meta/fbnic/Makefile b/drivers/net/ethernet/meta/fbnic/Makefile > index 239b2258ec65..0dbc634adb4b 100644 > --- a/drivers/net/ethernet/meta/fbnic/Makefile > +++ b/drivers/net/ethernet/meta/fbnic/Makefile > @@ -20,6 +20,7 @@ fbnic-y := fbnic_csr.o \ > fbnic_pci.o \ > fbnic_phylink.o \ > fbnic_rpc.o \ > + fbnic_time.o \ > fbnic_tlv.o \ > fbnic_txrx.o \ > - fbnic_time.o > +# End of objects Incredibly minor nit, do you want to remove the trailing '\' after fbnic_txrx.o which is the new last line to keep the format consistent with how it was previously? Your call, but I definitely feel bad pointing that out and potentially causing a re-spin, so: Acked-by: Joe Damato <jdamato@fastly.com>
On Tue, 11 Feb 2025 11:54:37 -0800 Joe Damato wrote: > Incredibly minor nit, do you want to remove the trailing '\' after > fbnic_txrx.o which is the new last line to keep the format > consistent with how it was previously? The point of having the comment is that the last real line can have the trailing \ and therefore will not need to be modified when an object is added after it :) Thanks for the reviews!
From: Jakub Kicinski <kuba@kernel.org> Date: Tue, 11 Feb 2025 14:32:34 -0800 > On Tue, 11 Feb 2025 11:54:37 -0800 Joe Damato wrote: >> Incredibly minor nit, do you want to remove the trailing '\' after >> fbnic_txrx.o which is the new last line to keep the format >> consistent with how it was previously? > > The point of having the comment is that the last real line can have the > trailing \ and therefore will not need to be modified when an object is > added after it :) Nice idea :D > > Thanks for the reviews! Series: Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com> Thanks, Olek
diff --git a/drivers/net/ethernet/meta/fbnic/Makefile b/drivers/net/ethernet/meta/fbnic/Makefile index 239b2258ec65..0dbc634adb4b 100644 --- a/drivers/net/ethernet/meta/fbnic/Makefile +++ b/drivers/net/ethernet/meta/fbnic/Makefile @@ -20,6 +20,7 @@ fbnic-y := fbnic_csr.o \ fbnic_pci.o \ fbnic_phylink.o \ fbnic_rpc.o \ + fbnic_time.o \ fbnic_tlv.o \ fbnic_txrx.o \ - fbnic_time.o +# End of objects
Looks like recent commit broke the sort order, fix it. Signed-off-by: Jakub Kicinski <kuba@kernel.org> --- drivers/net/ethernet/meta/fbnic/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)