| Message ID | 20250212-main-v1-1-6bc84cef5e32@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | pynfs: install packaged xdrlib3 module on Debian-derived distros | expand |
On 2/12/25 9:14 AM, Jeff Layton wrote: > Daniel Gomez reported that Debian distros have this module packaged and > that it should be preferred over a pip install. Move the install to > install-deps and change Debian distros to use the packaged module > instead. Fedora and SuSE distros still use pip. > > Signed-off-by: Jeff Layton <jlayton@kernel.org> > --- > playbooks/roles/pynfs/tasks/install-deps/debian/main.yml | 1 + > playbooks/roles/pynfs/tasks/install-deps/redhat/main.yml | 4 ++++ > playbooks/roles/pynfs/tasks/install-deps/suse/main.yml | 4 ++++ > playbooks/roles/pynfs/tasks/main.yml | 5 ----- > 4 files changed, 9 insertions(+), 5 deletions(-) > > diff --git a/playbooks/roles/pynfs/tasks/install-deps/debian/main.yml b/playbooks/roles/pynfs/tasks/install-deps/debian/main.yml > index 812de1d5f8b105d8d4987451e56d115166a138d2..e4c3c30e7bdb01d4864d541f28f3358f981af934 100644 > --- a/playbooks/roles/pynfs/tasks/install-deps/debian/main.yml > +++ b/playbooks/roles/pynfs/tasks/install-deps/debian/main.yml > @@ -12,6 +12,7 @@ > - swig > - python3-gssapi > - python3-ply > + - python3-standard-xdr-lib > state: present > update_cache: yes > tags: [ 'pynfs', 'deps' ] > diff --git a/playbooks/roles/pynfs/tasks/install-deps/redhat/main.yml b/playbooks/roles/pynfs/tasks/install-deps/redhat/main.yml > index 93513c42626350e0096e8a9db90b6d6f180e7e5f..8aa2ba1288092945c6d3e57a63e44dacc0d0ef87 100644 > --- a/playbooks/roles/pynfs/tasks/install-deps/redhat/main.yml > +++ b/playbooks/roles/pynfs/tasks/install-deps/redhat/main.yml > @@ -23,3 +23,7 @@ > - swig > - python3-gssapi > - python3-ply > + > +- name: Install xdrlib3 > + ansible.builtin.pip: > + name: xdrlib3 > diff --git a/playbooks/roles/pynfs/tasks/install-deps/suse/main.yml b/playbooks/roles/pynfs/tasks/install-deps/suse/main.yml > index 657dd7e0e170f86ec4fa2c47c1c7f29297317951..8321c064f9b00a4db9fdef35877ff180fad0b229 100644 > --- a/playbooks/roles/pynfs/tasks/install-deps/suse/main.yml > +++ b/playbooks/roles/pynfs/tasks/install-deps/suse/main.yml > @@ -13,3 +13,7 @@ > - python3-gssapi > - python3-ply > state: present > + > +- name: Install xdrlib3 > + ansible.builtin.pip: > + name: xdrlib3 > diff --git a/playbooks/roles/pynfs/tasks/main.yml b/playbooks/roles/pynfs/tasks/main.yml > index d3b8832409b17fbc03a2a3e625e0d319a45af919..c6add8e47fec298e2c7351805a42307ee8398e3c 100644 > --- a/playbooks/roles/pynfs/tasks/main.yml > +++ b/playbooks/roles/pynfs/tasks/main.yml > @@ -70,11 +70,6 @@ > when: > - not kdevops_workflows_dedicated_workflow|bool > > -- name: Install xdrlib3 > - tags: [ 'pynfs' ] > - ansible.builtin.pip: > - name: xdrlib3 > - > - name: Build pynfs > tags: [ 'pynfs' ] > command: ./setup.py build > > --- > base-commit: ccf731c4cf1f964e7e8a5fc2a8779ff10d306d64 > change-id: 20250212-main-da16bedce7dc > > Best regards, LGTM Reviewed-by: Chuck Lever <chuck.lever@oracle.com>
On Wed, Feb 12, 2025 at 09:14:41AM +0100, Jeff Layton wrote: > Daniel Gomez reported that Debian distros have this module packaged and > that it should be preferred over a pip install. Move the install to > install-deps and change Debian distros to use the packaged module > instead. Fedora and SuSE distros still use pip. > > Signed-off-by: Jeff Layton <jlayton@kernel.org> > --- > playbooks/roles/pynfs/tasks/install-deps/debian/main.yml | 1 + > playbooks/roles/pynfs/tasks/install-deps/redhat/main.yml | 4 ++++ > playbooks/roles/pynfs/tasks/install-deps/suse/main.yml | 4 ++++ > playbooks/roles/pynfs/tasks/main.yml | 5 ----- > 4 files changed, 9 insertions(+), 5 deletions(-) > > diff --git a/playbooks/roles/pynfs/tasks/install-deps/debian/main.yml b/playbooks/roles/pynfs/tasks/install-deps/debian/main.yml > index 812de1d5f8b105d8d4987451e56d115166a138d2..e4c3c30e7bdb01d4864d541f28f3358f981af934 100644 > --- a/playbooks/roles/pynfs/tasks/install-deps/debian/main.yml > +++ b/playbooks/roles/pynfs/tasks/install-deps/debian/main.yml > @@ -12,6 +12,7 @@ > - swig > - python3-gssapi > - python3-ply > + - python3-standard-xdr-lib > state: present > update_cache: yes > tags: [ 'pynfs', 'deps' ] > diff --git a/playbooks/roles/pynfs/tasks/install-deps/redhat/main.yml b/playbooks/roles/pynfs/tasks/install-deps/redhat/main.yml > index 93513c42626350e0096e8a9db90b6d6f180e7e5f..8aa2ba1288092945c6d3e57a63e44dacc0d0ef87 100644 > --- a/playbooks/roles/pynfs/tasks/install-deps/redhat/main.yml > +++ b/playbooks/roles/pynfs/tasks/install-deps/redhat/main.yml > @@ -23,3 +23,7 @@ > - swig > - python3-gssapi > - python3-ply > + > +- name: Install xdrlib3 > + ansible.builtin.pip: > + name: xdrlib3 > diff --git a/playbooks/roles/pynfs/tasks/install-deps/suse/main.yml b/playbooks/roles/pynfs/tasks/install-deps/suse/main.yml > index 657dd7e0e170f86ec4fa2c47c1c7f29297317951..8321c064f9b00a4db9fdef35877ff180fad0b229 100644 > --- a/playbooks/roles/pynfs/tasks/install-deps/suse/main.yml > +++ b/playbooks/roles/pynfs/tasks/install-deps/suse/main.yml > @@ -13,3 +13,7 @@ > - python3-gssapi > - python3-ply > state: present > + > +- name: Install xdrlib3 > + ansible.builtin.pip: > + name: xdrlib3 > diff --git a/playbooks/roles/pynfs/tasks/main.yml b/playbooks/roles/pynfs/tasks/main.yml > index d3b8832409b17fbc03a2a3e625e0d319a45af919..c6add8e47fec298e2c7351805a42307ee8398e3c 100644 > --- a/playbooks/roles/pynfs/tasks/main.yml > +++ b/playbooks/roles/pynfs/tasks/main.yml > @@ -70,11 +70,6 @@ > when: > - not kdevops_workflows_dedicated_workflow|bool > > -- name: Install xdrlib3 > - tags: [ 'pynfs' ] > - ansible.builtin.pip: > - name: xdrlib3 > - > - name: Build pynfs > tags: [ 'pynfs' ] > command: ./setup.py build > > --- > base-commit: ccf731c4cf1f964e7e8a5fc2a8779ff10d306d64 > change-id: 20250212-main-da16bedce7dc > > Best regards, LGTM, Reviewed-by: Daniel Gomez <da.gomez@samsung.com> > -- > Jeff Layton <jlayton@kernel.org> >
diff --git a/playbooks/roles/pynfs/tasks/install-deps/debian/main.yml b/playbooks/roles/pynfs/tasks/install-deps/debian/main.yml index 812de1d5f8b105d8d4987451e56d115166a138d2..e4c3c30e7bdb01d4864d541f28f3358f981af934 100644 --- a/playbooks/roles/pynfs/tasks/install-deps/debian/main.yml +++ b/playbooks/roles/pynfs/tasks/install-deps/debian/main.yml @@ -12,6 +12,7 @@ - swig - python3-gssapi - python3-ply + - python3-standard-xdr-lib state: present update_cache: yes tags: [ 'pynfs', 'deps' ] diff --git a/playbooks/roles/pynfs/tasks/install-deps/redhat/main.yml b/playbooks/roles/pynfs/tasks/install-deps/redhat/main.yml index 93513c42626350e0096e8a9db90b6d6f180e7e5f..8aa2ba1288092945c6d3e57a63e44dacc0d0ef87 100644 --- a/playbooks/roles/pynfs/tasks/install-deps/redhat/main.yml +++ b/playbooks/roles/pynfs/tasks/install-deps/redhat/main.yml @@ -23,3 +23,7 @@ - swig - python3-gssapi - python3-ply + +- name: Install xdrlib3 + ansible.builtin.pip: + name: xdrlib3 diff --git a/playbooks/roles/pynfs/tasks/install-deps/suse/main.yml b/playbooks/roles/pynfs/tasks/install-deps/suse/main.yml index 657dd7e0e170f86ec4fa2c47c1c7f29297317951..8321c064f9b00a4db9fdef35877ff180fad0b229 100644 --- a/playbooks/roles/pynfs/tasks/install-deps/suse/main.yml +++ b/playbooks/roles/pynfs/tasks/install-deps/suse/main.yml @@ -13,3 +13,7 @@ - python3-gssapi - python3-ply state: present + +- name: Install xdrlib3 + ansible.builtin.pip: + name: xdrlib3 diff --git a/playbooks/roles/pynfs/tasks/main.yml b/playbooks/roles/pynfs/tasks/main.yml index d3b8832409b17fbc03a2a3e625e0d319a45af919..c6add8e47fec298e2c7351805a42307ee8398e3c 100644 --- a/playbooks/roles/pynfs/tasks/main.yml +++ b/playbooks/roles/pynfs/tasks/main.yml @@ -70,11 +70,6 @@ when: - not kdevops_workflows_dedicated_workflow|bool -- name: Install xdrlib3 - tags: [ 'pynfs' ] - ansible.builtin.pip: - name: xdrlib3 - - name: Build pynfs tags: [ 'pynfs' ] command: ./setup.py build
Daniel Gomez reported that Debian distros have this module packaged and that it should be preferred over a pip install. Move the install to install-deps and change Debian distros to use the packaged module instead. Fedora and SuSE distros still use pip. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- playbooks/roles/pynfs/tasks/install-deps/debian/main.yml | 1 + playbooks/roles/pynfs/tasks/install-deps/redhat/main.yml | 4 ++++ playbooks/roles/pynfs/tasks/install-deps/suse/main.yml | 4 ++++ playbooks/roles/pynfs/tasks/main.yml | 5 ----- 4 files changed, 9 insertions(+), 5 deletions(-) --- base-commit: ccf731c4cf1f964e7e8a5fc2a8779ff10d306d64 change-id: 20250212-main-da16bedce7dc Best regards,