[v2,0/3] prandom: remove next_pseudo_random32

Message

Markus Theil Feb. 11, 2025, 6:33 a.m. UTC

next_pseudo_random32 implements a LCG with known bad statistical
properties and is only used in two pieces of testing code. Remove and
convert the remaining two users to the single PRNG interface in
prandom.h

This removes another option of using an insecure PRNG.

Markus Theil (3):
  drm/i915/selftests: use prandom in selftest
  media: vivid: use prandom
  prandom: remove next_pseudo_random32

 drivers/gpu/drm/i915/selftests/i915_gem.c        | 7 ++++---
 drivers/media/test-drivers/vivid/vivid-vid-cap.c | 4 +++-
 include/linux/prandom.h                          | 6 ------
 3 files changed, 7 insertions(+), 10 deletions(-)

Comments

Krzysztof Karas Feb. 13, 2025, 2:27 p.m. UTC | #1

Hi Markus,

> next_pseudo_random32 implements a LCG with known bad statistical
> properties and is only used in two pieces of testing code. Remove and
> convert the remaining two users to the single PRNG interface in
> prandom.h
> 
> This removes another option of using an insecure PRNG.
> 
> Markus Theil (3):
>   drm/i915/selftests: use prandom in selftest
>   media: vivid: use prandom
>   prandom: remove next_pseudo_random32
> 
>  drivers/gpu/drm/i915/selftests/i915_gem.c        | 7 ++++---
>  drivers/media/test-drivers/vivid/vivid-vid-cap.c | 4 +++-
>  include/linux/prandom.h                          | 6 ------
>  3 files changed, 7 insertions(+), 10 deletions(-)
>

The series looks good:
Reviewed-by: Krzysztof Karas <[e-mail]>
on all the patches.

Best Regards,
Krzysztof