| Message ID | 20250203050828.1049370-1-anshuman.khandual@arm.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | arm64/boot: Enable EL2 requirements for FEAT_PMUv3p9 | expand |
On 2/3/25 10:38, Anshuman Khandual wrote: > This series adds fine grained trap control in EL2 required for FEAT_PMUv3p9 > registers like PMICNTR_EL0, PMICFILTR_EL0, and PMUACR_EL1 which are already > being used in the kernel. This is required to prevent their EL1 access trap > into EL2. > > PMZR_EL0 register trap control i.e HDFGWTR2_EL2.nPMZR_EL0 remains unchanged > for now as it does not get accessed in the kernel, and there is no plan for > its access from user space. > > I have taken the liberty to pick up all the review tags for patches related > to tools sysreg update from the KVM FGT2 V2 patch series posted earlier. > > https://lore.kernel.org/all/20241210055311.780688-1-anshuman.khandual@arm.com/ > > Rob had earler mentioned about FEAT_FGT2 based trap control requirement for > FEAT_PMUv3p9 registers that are currently being used in kernel. The context > can be found here. > > https://lore.kernel.org/all/20241216234251.GA629562-robh@kernel.org/ > > This series is based on v6.14-rc1 > > Changes in V2: > > - Rebased on v6.14-rc1 > - Updated tools sysreg patches with latest DDI0601 2024-12 definitions > - Updated document version as DDI0601 2024-12 in all commit messages > - Added latest tags from Rob Herring for the last patch > Hello Catalin/Will/Rob, I hope this series looks okay. Please do let me know in case anything needs changing. Thank you. - Anshuman > Changes in V1: > > https://lore.kernel.org/all/20241220072240.1003352-1-anshuman.khandual@arm.com/ > > Cc: Catalin Marinas <catalin.marinas@arm.com> > Cc: Will Deacon <will@kernel.org> > Cc: Marc Zyngier <maz@kernel.org> > Cc: Ryan Roberts <ryan.roberts@arm.com> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: Mark Brown <robh@kernel.org> > Cc: Rob Herring <robh@kernel.org> > Cc: Oliver Upton <oliver.upton@linux.dev> > Cc: Jonathan Corbet <corbet@lwn.net> > Cc: Eric Auger <eric.auger@redhat.com> > Cc: kvmarm@lists.linux.dev > Cc: linux-doc@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > > Anshuman Khandual (7): > arm64/sysreg: Update register fields for ID_AA64MMFR0_EL1 > arm64/sysreg: Add register fields for HDFGRTR2_EL2 > arm64/sysreg: Add register fields for HDFGWTR2_EL2 > arm64/sysreg: Add register fields for HFGITR2_EL2 > arm64/sysreg: Add register fields for HFGRTR2_EL2 > arm64/sysreg: Add register fields for HFGWTR2_EL2 > arm64/boot: Enable EL2 requirements for FEAT_PMUv3p9 > > Documentation/arch/arm64/booting.rst | 18 +++++ > arch/arm64/include/asm/el2_setup.h | 25 +++++++ > arch/arm64/tools/sysreg | 103 +++++++++++++++++++++++++++ > 3 files changed, 146 insertions(+) >
On Mon, 03 Feb 2025 10:38:21 +0530, Anshuman Khandual wrote: > This series adds fine grained trap control in EL2 required for FEAT_PMUv3p9 > registers like PMICNTR_EL0, PMICFILTR_EL0, and PMUACR_EL1 which are already > being used in the kernel. This is required to prevent their EL1 access trap > into EL2. > > PMZR_EL0 register trap control i.e HDFGWTR2_EL2.nPMZR_EL0 remains unchanged > for now as it does not get accessed in the kernel, and there is no plan for > its access from user space. > > [...] Applied to arm64 (for-next/el2-enable-feat-pmuv3p9), thanks! [7/7] arm64/boot: Enable EL2 requirements for FEAT_PMUv3p9 https://git.kernel.org/arm64/c/f134bbc054ae
On Tue, Feb 18, 2025 at 07:03:49PM +0000, Catalin Marinas wrote: > On Mon, 03 Feb 2025 10:38:21 +0530, Anshuman Khandual wrote: > > This series adds fine grained trap control in EL2 required for FEAT_PMUv3p9 > > registers like PMICNTR_EL0, PMICFILTR_EL0, and PMUACR_EL1 which are already > > being used in the kernel. This is required to prevent their EL1 access trap > > into EL2. > > > > PMZR_EL0 register trap control i.e HDFGWTR2_EL2.nPMZR_EL0 remains unchanged > > for now as it does not get accessed in the kernel, and there is no plan for > > its access from user space. > > > > [...] > > Applied to arm64 (for-next/el2-enable-feat-pmuv3p9), thanks! > > [7/7] arm64/boot: Enable EL2 requirements for FEAT_PMUv3p9 > https://git.kernel.org/arm64/c/f134bbc054ae "b4 ty" ignored the other patches. I applied the sysreg ones to the arm64 for-next/sysreg branch in case they need to get pulled into other trees (e.g. KVM). The above patch is on top of the other sysreg patches.
On Mon, Feb 03, 2025 at 10:38:21AM +0530, Anshuman Khandual wrote: > This series adds fine grained trap control in EL2 required for FEAT_PMUv3p9 > registers like PMICNTR_EL0, PMICFILTR_EL0, and PMUACR_EL1 which are already > being used in the kernel. This is required to prevent their EL1 access trap > into EL2. > > PMZR_EL0 register trap control i.e HDFGWTR2_EL2.nPMZR_EL0 remains unchanged > for now as it does not get accessed in the kernel, and there is no plan for > its access from user space. > > I have taken the liberty to pick up all the review tags for patches related > to tools sysreg update from the KVM FGT2 V2 patch series posted earlier. > > https://lore.kernel.org/all/20241210055311.780688-1-anshuman.khandual@arm.com/ > > Rob had earler mentioned about FEAT_FGT2 based trap control requirement for > FEAT_PMUv3p9 registers that are currently being used in kernel. The context > can be found here. > > https://lore.kernel.org/all/20241216234251.GA629562-robh@kernel.org/ > > This series is based on v6.14-rc1 > > Changes in V2: > > - Rebased on v6.14-rc1 > - Updated tools sysreg patches with latest DDI0601 2024-12 definitions > - Updated document version as DDI0601 2024-12 in all commit messages > - Added latest tags from Rob Herring for the last patch I know these have been applied already but, fwiw, patches 1-6 look correct when compared against the .xml: Acked-by: Will Deacon <will@kernel.org> I presume Catalin will drop/replace the last patch. Will
On Sat, Mar 01, 2025 at 07:58:50AM +0000, Will Deacon wrote: > On Mon, Feb 03, 2025 at 10:38:21AM +0530, Anshuman Khandual wrote: > > This series adds fine grained trap control in EL2 required for FEAT_PMUv3p9 > > registers like PMICNTR_EL0, PMICFILTR_EL0, and PMUACR_EL1 which are already > > being used in the kernel. This is required to prevent their EL1 access trap > > into EL2. > > > > PMZR_EL0 register trap control i.e HDFGWTR2_EL2.nPMZR_EL0 remains unchanged > > for now as it does not get accessed in the kernel, and there is no plan for > > its access from user space. > > > > I have taken the liberty to pick up all the review tags for patches related > > to tools sysreg update from the KVM FGT2 V2 patch series posted earlier. > > > > https://lore.kernel.org/all/20241210055311.780688-1-anshuman.khandual@arm.com/ > > > > Rob had earler mentioned about FEAT_FGT2 based trap control requirement for > > FEAT_PMUv3p9 registers that are currently being used in kernel. The context > > can be found here. > > > > https://lore.kernel.org/all/20241216234251.GA629562-robh@kernel.org/ > > > > This series is based on v6.14-rc1 > > > > Changes in V2: > > > > - Rebased on v6.14-rc1 > > - Updated tools sysreg patches with latest DDI0601 2024-12 definitions > > - Updated document version as DDI0601 2024-12 in all commit messages > > - Added latest tags from Rob Herring for the last patch > > I know these have been applied already but, fwiw, patches 1-6 look correct > when compared against the .xml: > > Acked-by: Will Deacon <will@kernel.org> Thanks Will. > I presume Catalin will drop/replace the last patch. I dropped it already, I'll queue the new one.