mbox series

[net-next,v2,0/3] Add native mode XDP support

Message ID 20250210103352.541052-1-m-malladi@ti.com (mailing list archive)
Headers show
Series Add native mode XDP support | expand

Message

Meghana Malladi Feb. 10, 2025, 10:33 a.m. UTC
This series adds native XDP support using page_pool.
XDP zero copy support is not included in this patch series.

Patch 1/3: Replaces skb with page pool for Rx buffer allocation
Patch 2/3: Adds prueth_swdata struct for SWDATA for all swdata cases
Patch 3/3: Introduces native mode XDP support

v1: https://lore.kernel.org/all/20250122124951.3072410-1-m-malladi@ti.com/

Changes since v1 (v2-v1):
- Add missing SoBs for all patches
1/3:
- Recycle pages wherever necessary using skb_mark_for_recycle()
- Use napi_build_skb() instead of build_skb()
- Update with correct frag_size argument in napi_build_skb()
- Use napi_gro_receive() instead of netif_receive_skb()
- Use PP_FLAG_DMA_SYNC_DEV to enable DMA sync with device
- Use page_pool_dma_sync_for_cpu() to sync Rx page pool for CPU
3/3:
- Fix XDP typo in the commit message
- Add XDP feature flags using xdp_set_features_flag()
- Use xdp_build_skb_from_buff() when XDP ran
All the above changes have been suggested by Ido Schimmel <idosch@idosch.org>

Roger Quadros (3):
  net: ti: icssg-prueth: Use page_pool API for RX buffer allocation
  net: ti: icssg-prueth: introduce and use prueth_swdata struct for
    SWDATA
  net: ti: icssg-prueth: Add XDP support

 drivers/net/ethernet/ti/Kconfig               |   1 +
 drivers/net/ethernet/ti/icssg/icssg_common.c  | 427 ++++++++++++++----
 drivers/net/ethernet/ti/icssg/icssg_config.h  |   2 +-
 drivers/net/ethernet/ti/icssg/icssg_prueth.c  | 129 +++++-
 drivers/net/ethernet/ti/icssg/icssg_prueth.h  |  50 +-
 .../net/ethernet/ti/icssg/icssg_prueth_sr1.c  |  23 +-
 6 files changed, 540 insertions(+), 92 deletions(-)


base-commit: acdefab0dcbc3833b5a734ab80d792bb778517a0

Comments

Jesper Dangaard Brouer Feb. 18, 2025, 4:02 p.m. UTC | #1
On 10/02/2025 11.33, Meghana Malladi wrote:
> This series adds native XDP support using page_pool.

Please also describe *what driver* to adds XDP support for.

This cover letter will (by netdev maintainers) be part of the merge
commit text.  Thus, please mention the driver name in the text.

This also applies for the Subject line.  It should either be prefix with
"net: ti: icssg-prueth:" like you did for other patches, or be renamed
to e.g.: "Add native mode XDP support for driver ti/icssg-prueth".

Thanks,
--Jesper
Meghana Malladi Feb. 18, 2025, 5:55 p.m. UTC | #2
On 2/18/2025 9:32 PM, Jesper Dangaard Brouer wrote:
> 
> On 10/02/2025 11.33, Meghana Malladi wrote:
>> This series adds native XDP support using page_pool.
> 
> Please also describe *what driver* to adds XDP support for.
> 
> This cover letter will (by netdev maintainers) be part of the merge
> commit text.  Thus, please mention the driver name in the text.
> 
> This also applies for the Subject line.  It should either be prefix with
> "net: ti: icssg-prueth:" like you did for other patches, or be renamed
> to e.g.: "Add native mode XDP support for driver ti/icssg-prueth".
> 

Oh ok got it. Will update the subject line accordingly in v3 and follow 
the same for my upcoming patches. Thanks.

> Thanks,
> --Jesper