| Message ID | 20250218194113.26589-5-kuurtb@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | platform-x86: Use *-y instead of *-objs in Makefiles | expand |
On 2/18/2025 11:41 AM, Kurt Borja wrote: > The `objs` suffix is reserved for user-space tools. Use the `y` suffix > instead, which is usually used for kernel drivers. > > Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Signed-off-by: Kurt Borja <kuurtb@gmail.com> > --- > drivers/platform/x86/intel/ifs/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Looks good to me (and verified that driver is getting built) Reviewed-by: Jithu Joseph <jithu.joseph@intel.com> > > diff --git a/drivers/platform/x86/intel/ifs/Makefile b/drivers/platform/x86/intel/ifs/Makefile > index 30f035ef5581..c3e417bce9b6 100644 > --- a/drivers/platform/x86/intel/ifs/Makefile > +++ b/drivers/platform/x86/intel/ifs/Makefile > @@ -1,3 +1,3 @@ > obj-$(CONFIG_INTEL_IFS) += intel_ifs.o > > -intel_ifs-objs := core.o load.o runtest.o sysfs.o > +intel_ifs-y := core.o load.o runtest.o sysfs.o Thanks Jithu
On Tue, Feb 18, 2025 at 02:41:11PM -0500, Kurt Borja wrote: > The `objs` suffix is reserved for user-space tools. Use the `y` suffix > instead, which is usually used for kernel drivers. Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> for all 4.
diff --git a/drivers/platform/x86/intel/ifs/Makefile b/drivers/platform/x86/intel/ifs/Makefile index 30f035ef5581..c3e417bce9b6 100644 --- a/drivers/platform/x86/intel/ifs/Makefile +++ b/drivers/platform/x86/intel/ifs/Makefile @@ -1,3 +1,3 @@ obj-$(CONFIG_INTEL_IFS) += intel_ifs.o -intel_ifs-objs := core.o load.o runtest.o sysfs.o +intel_ifs-y := core.o load.o runtest.o sysfs.o
The `objs` suffix is reserved for user-space tools. Use the `y` suffix instead, which is usually used for kernel drivers. Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Kurt Borja <kuurtb@gmail.com> --- drivers/platform/x86/intel/ifs/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)