diff mbox series

[09/12] xfs/122: disable this test for any codebase that knows about metadir

Message ID 173992588226.4078751.3774851302421682128.stgit@frogsfrogsfrogs (mailing list archive)
State New
Headers show
Series [01/12] various: fix finding metadata inode numbers when metadir is enabled | expand

Commit Message

Darrick J. Wong Feb. 19, 2025, 12:55 a.m. UTC 
From: Darrick J. Wong <djwong@kernel.org>

All of the ondisk structure size checks from this test were copied to
the build time checks in xfs_ondisk.h.  This means that the kernel and
xfsprogs build processes check the structure sizes, which means that
fstests no longer needs to do that.

Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
---
 tests/xfs/122 |    6 ++++++
 1 file changed, 6 insertions(+)

Comments

Christoph Hellwig Feb. 19, 2025, 6:06 a.m. UTC | #1 
On Tue, Feb 18, 2025 at 04:55:47PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> All of the ondisk structure size checks from this test were copied to
> the build time checks in xfs_ondisk.h.  This means that the kernel and
> xfsprogs build processes check the structure sizes, which means that
> fstests no longer needs to do that.

Looks good;

Reviewed-by: Christoph Hellwig <hch@lst.de>
diff mbox series

Patch

diff --git a/tests/xfs/122 b/tests/xfs/122
index a968948841de14..e96ef2fe93042b 100755
--- a/tests/xfs/122
+++ b/tests/xfs/122
@@ -15,6 +15,12 @@  _begin_fstest other auto quick clone realtime
 
 _require_command "$INDENT_PROG" indent
 
+# We ported all the ondisk size checks to xfs_ondisk.h in both the kernel and
+# xfsprogs libxfs when we added the metadir feature.  If mkfs supports metadir
+# then we don't have to run this test anymore.
+$MKFS_XFS_PROG --help 2>&1 | grep -q metadir && \
+	_notrun "struct size checks moved to libxfs/xfs_ondisk.h"
+
 # Starting in Linux 6.1, the EFI log formats were adjusted away from using
 # single-element arrays as flex arrays.
 _wants_kernel_commit 03a7485cd701 \