diff mbox series

[v2] drm/nouveau/pmu: Fix gp10b firmware guard

Message ID 20250218-nouveau-gm10b-guard-v2-1-a4de71500d48@gmail.com (mailing list archive)
State New
Headers show
Series [v2] drm/nouveau/pmu: Fix gp10b firmware guard | expand

Commit Message

Aaron Kling via B4 Relay Feb. 18, 2025, 9:28 a.m. UTC 
From: Aaron Kling <webgeek1234@gmail.com>

Most kernel configs enable multiple Tegra SoC generations, causing this
typo to go unnoticed. But in the case where a kernel config is strictly
for Tegra186, this is a problem.

Fixes: 989863d7cbe5 ("drm/nouveau/pmu: select implementation based on available firmware")
Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
---
Changes in v2:
- Updated commit message to include a body
- Link to v1: https://lore.kernel.org/r/20250217-nouveau-gm10b-guard-v1-1-0d96f0068570@gmail.com
---
 drivers/gpu/drm/nouveau/nvkm/subdev/pmu/gp10b.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


---
base-commit: 2408a807bfc3f738850ef5ad5e3fd59d66168996
change-id: 20250217-nouveau-gm10b-guard-a438402b5022

Best regards,

Comments

Danilo Krummrich Feb. 19, 2025, 12:53 p.m. UTC | #1 
On Tue, Feb 18, 2025 at 03:28:03AM -0600, Aaron Kling via B4 Relay wrote:
> From: Aaron Kling <webgeek1234@gmail.com>
> 
> Most kernel configs enable multiple Tegra SoC generations, causing this
> typo to go unnoticed. But in the case where a kernel config is strictly
> for Tegra186, this is a problem.
> 
> Fixes: 989863d7cbe5 ("drm/nouveau/pmu: select implementation based on available firmware")
> Signed-off-by: Aaron Kling <webgeek1234@gmail.com>

Applied to drm-misc-fixes, thanks!
diff mbox series

Patch

diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/gp10b.c b/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/gp10b.c
index a6f410ba60bc94ec9d52fc78868acddfc6770e19..d393bc540f8628812990dffe4c2f7e9014be07c5 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/gp10b.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/gp10b.c
@@ -75,7 +75,7 @@  gp10b_pmu_acr = {
 	.bootstrap_multiple_falcons = gp10b_pmu_acr_bootstrap_multiple_falcons,
 };
 
-#if IS_ENABLED(CONFIG_ARCH_TEGRA_210_SOC)
+#if IS_ENABLED(CONFIG_ARCH_TEGRA_186_SOC)
 MODULE_FIRMWARE("nvidia/gp10b/pmu/desc.bin");
 MODULE_FIRMWARE("nvidia/gp10b/pmu/image.bin");
 MODULE_FIRMWARE("nvidia/gp10b/pmu/sig.bin");