| Message ID | 20250219234956.520599-4-kuba@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | bab59dcf71fbe8f3e710a441f74dc9b76937c3e3 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | selftests: drv-net: improve the queue test for XSK | expand |
On Wed Feb 19 2025, Jakub Kicinski wrote: > Kurt and Joe report missing new line at the end of Usage. > > Signed-off-by: Jakub Kicinski <kuba@kernel.org> Reviewed-by: Kurt Kanzenbach <kurt@linutronix.de>
On Wed, Feb 19, 2025 at 03:49:52PM -0800, Jakub Kicinski wrote: > Kurt and Joe report missing new line at the end of Usage. > > Signed-off-by: Jakub Kicinski <kuba@kernel.org> > --- > v2: new > --- > tools/testing/selftests/drivers/net/xdp_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/drivers/net/xdp_helper.c b/tools/testing/selftests/drivers/net/xdp_helper.c > index cf06a88b830b..80f86c2fe1a5 100644 > --- a/tools/testing/selftests/drivers/net/xdp_helper.c > +++ b/tools/testing/selftests/drivers/net/xdp_helper.c > @@ -35,7 +35,7 @@ int main(int argc, char **argv) > char byte; > > if (argc != 3) { > - fprintf(stderr, "Usage: %s ifindex queue_id", argv[0]); > + fprintf(stderr, "Usage: %s ifindex queue_id\n", argv[0]); > return 1; > } Reviewed-by: Joe Damato <jdamato@fastly.com>
diff --git a/tools/testing/selftests/drivers/net/xdp_helper.c b/tools/testing/selftests/drivers/net/xdp_helper.c index cf06a88b830b..80f86c2fe1a5 100644 --- a/tools/testing/selftests/drivers/net/xdp_helper.c +++ b/tools/testing/selftests/drivers/net/xdp_helper.c @@ -35,7 +35,7 @@ int main(int argc, char **argv) char byte; if (argc != 3) { - fprintf(stderr, "Usage: %s ifindex queue_id", argv[0]); + fprintf(stderr, "Usage: %s ifindex queue_id\n", argv[0]); return 1; }
Kurt and Joe report missing new line at the end of Usage. Signed-off-by: Jakub Kicinski <kuba@kernel.org> --- v2: new --- tools/testing/selftests/drivers/net/xdp_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)