| Message ID | 20250219113354.529611-2-mkl@pengutronix.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | fd2a0c47fbae257bc7ff9c8d66aa7f039eb367b1 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,01/12] can: c_can: Drop useless final probe failure message | expand |
Hello: This series was applied to netdev/net-next.git (main) by Marc Kleine-Budde <mkl@pengutronix.de>: On Wed, 19 Feb 2025 12:21:06 +0100 you wrote: > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Generic probe failure message is useless: does not give information what > failed and it duplicates messages provided by the core, e.g. from memory > allocation or platform_get_irq(). It also floods dmesg in case of > deferred probe, e.g. resulting from devm_clk_get(). > > [...] Here is the summary with links: - [net-next,01/12] can: c_can: Drop useless final probe failure message https://git.kernel.org/netdev/net-next/c/fd2a0c47fbae - [net-next,02/12] can: c_can: Simplify handling syscon error path https://git.kernel.org/netdev/net-next/c/6c00b580d1c9 - [net-next,03/12] can: c_can: Use of_property_present() to test existence of DT property https://git.kernel.org/netdev/net-next/c/ab1bc2290fd8 - [net-next,04/12] can: c_can: Use syscon_regmap_lookup_by_phandle_args https://git.kernel.org/netdev/net-next/c/9f0f0345d040 - [net-next,05/12] dt-bindings: can: fsl,flexcan: add S32G2/S32G3 SoC support https://git.kernel.org/netdev/net-next/c/51723790b718 - [net-next,06/12] can: flexcan: Add quirk to handle separate interrupt lines for mailboxes https://git.kernel.org/netdev/net-next/c/8c652cf030a7 - [net-next,07/12] can: flexcan: add NXP S32G2/S32G3 SoC support https://git.kernel.org/netdev/net-next/c/8503a4b1a24d - [net-next,08/12] dt-binding: can: mcp251xfd: remove duplicate word https://git.kernel.org/netdev/net-next/c/bcb13d33221d - [net-next,09/12] can: j1939: Extend stack documentation with buffer size behavior https://git.kernel.org/netdev/net-next/c/6b89d89f2147 - [net-next,10/12] can: canxl: support Remote Request Substitution bit access https://git.kernel.org/netdev/net-next/c/e1b2c7e902f7 - [net-next,11/12] can: gs_usb: add VID/PID for the CANnectivity firmware https://git.kernel.org/netdev/net-next/c/32f08b22f3b8 - [net-next,12/12] can: rockchip_canfd: rkcanfd_chip_fifo_setup(): remove duplicated setup of RX FIFO https://git.kernel.org/netdev/net-next/c/d9e1cc087a55 You are awesome, thank you!
diff --git a/drivers/net/can/c_can/c_can_platform.c b/drivers/net/can/c_can/c_can_platform.c index 399844809bbe..8968b6288ac7 100644 --- a/drivers/net/can/c_can/c_can_platform.c +++ b/drivers/net/can/c_can/c_can_platform.c @@ -269,30 +269,22 @@ static int c_can_plat_probe(struct platform_device *pdev) /* get the appropriate clk */ clk = devm_clk_get(&pdev->dev, NULL); - if (IS_ERR(clk)) { - ret = PTR_ERR(clk); - goto exit; - } + if (IS_ERR(clk)) + return PTR_ERR(clk); /* get the platform data */ irq = platform_get_irq(pdev, 0); - if (irq < 0) { - ret = irq; - goto exit; - } + if (irq < 0) + return irq; addr = devm_platform_get_and_ioremap_resource(pdev, 0, &mem); - if (IS_ERR(addr)) { - ret = PTR_ERR(addr); - goto exit; - } + if (IS_ERR(addr)) + return PTR_ERR(addr); /* allocate the c_can device */ dev = alloc_c_can_dev(drvdata->msg_obj_num); - if (!dev) { - ret = -ENOMEM; - goto exit; - } + if (!dev) + return -ENOMEM; priv = netdev_priv(dev); switch (drvdata->id) { @@ -396,8 +388,6 @@ static int c_can_plat_probe(struct platform_device *pdev) pm_runtime_disable(priv->device); exit_free_device: free_c_can_dev(dev); -exit: - dev_err(&pdev->dev, "probe failed\n"); return ret; }