diff mbox series

[v5,1/2] dt-bindings: net: bluetooth: nxp: Add support to set BD address

Message ID 20250220114157.232997-1-neeraj.sanjaykale@nxp.com (mailing list archive)
State New
Headers show
Series [v5,1/2] dt-bindings: net: bluetooth: nxp: Add support to set BD address | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/SubjectPrefix fail "Bluetooth: " prefix is not specified in the subject
tedd_an/BuildKernel success BuildKernel PASS
tedd_an/CheckAllWarning success CheckAllWarning PASS
tedd_an/CheckSparse success CheckSparse PASS
tedd_an/BuildKernel32 success BuildKernel32 PASS
tedd_an/TestRunnerSetup success TestRunnerSetup PASS
tedd_an/TestRunner_l2cap-tester success TestRunner PASS
tedd_an/TestRunner_iso-tester success TestRunner PASS
tedd_an/TestRunner_bnep-tester success TestRunner PASS
tedd_an/TestRunner_mgmt-tester fail TestRunner_mgmt-tester: Total: 490, Passed: 482 (98.4%), Failed: 4, Not Run: 4
tedd_an/TestRunner_rfcomm-tester success TestRunner PASS
tedd_an/TestRunner_sco-tester success TestRunner PASS
tedd_an/TestRunner_ioctl-tester success TestRunner PASS
tedd_an/TestRunner_mesh-tester success TestRunner PASS
tedd_an/TestRunner_smp-tester success TestRunner PASS
tedd_an/TestRunner_userchan-tester success TestRunner PASS

Commit Message

Neeraj Sanjay Kale Feb. 20, 2025, 11:41 a.m. UTC 
Allow user to set custom BD address for NXP chipsets.

Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
v2: Add allOf and unevaluatedProperties: false (Krzysztof)
v3: Drop local-bd-address: true (Krzysztof)
---
 .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml   | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comments

Paul Menzel Feb. 20, 2025, 11:45 a.m. UTC | #1 
Dear Neeraj,


Thank you for your patch.


Am 20.02.25 um 12:41 schrieb Neeraj Sanjay Kale:
> Allow user to set custom BD address for NXP chipsets.
> 
> Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> v2: Add allOf and unevaluatedProperties: false (Krzysztof)
> v3: Drop local-bd-address: true (Krzysztof)
> ---
>   .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml   | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> index 0a2d7baf5db3..a84c1c21b024 100644
> --- a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> @@ -17,6 +17,9 @@ description:
>   maintainers:
>     - Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
>   
> +allOf:
> +  - $ref: bluetooth-controller.yaml#
> +
>   properties:
>     compatible:
>       enum:
> @@ -43,7 +46,7 @@ properties:
>   required:
>     - compatible
>   
> -additionalProperties: false
> +unevaluatedProperties: false

How is this diff related to the change mentioned in the commit message?

>   
>   examples:
>     - |
> @@ -54,5 +57,6 @@ examples:
>               fw-init-baudrate = <3000000>;
>               firmware-name = "uartuart8987_bt_v0.bin";
>               device-wakeup-gpios = <&gpio 11 GPIO_ACTIVE_HIGH>;
> +            local-bd-address = [66 55 44 33 22 11];
>           };
>       };


Kind regards,

Paul
Neeraj Sanjay Kale Feb. 20, 2025, 11:59 a.m. UTC | #2 
Hi Paul,

Thank you your review comment.
 
> 
> Dear Neeraj,
> 
> 
> Thank you for your patch.
> 
> 
> Am 20.02.25 um 12:41 schrieb Neeraj Sanjay Kale:
> > Allow user to set custom BD address for NXP chipsets.
> >
> > Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > ---
> > v2: Add allOf and unevaluatedProperties: false (Krzysztof)
> > v3: Drop local-bd-address: true (Krzysztof)
> > ---
> >   .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml   | 6 +++++-
> >   1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git
> a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> > index 0a2d7baf5db3..a84c1c21b024 100644
> > --- a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-
> bt.yaml
> > +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-
> bt.yaml
> > @@ -17,6 +17,9 @@ description:
> >   maintainers:
> >     - Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
> >
> > +allOf:
> > +  - $ref: bluetooth-controller.yaml#
> > +
> >   properties:
> >     compatible:
> >       enum:
> > @@ -43,7 +46,7 @@ properties:
> >   required:
> >     - compatible
> >
> > -additionalProperties: false
> > +unevaluatedProperties: false
> 
> How is this diff related to the change mentioned in the commit message?

This is based on review comment from Krzysztof in V1 DT patch.
allOf ref will import all properties defined in bluetooth-controller.yaml, including local-bd-address:
https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/net/bluetooth/bluetooth-controller.yaml#L18

> 
> >
> >   examples:
> >     - |
> > @@ -54,5 +57,6 @@ examples:
> >               fw-init-baudrate = <3000000>;
> >               firmware-name = "uartuart8987_bt_v0.bin";
> >               device-wakeup-gpios = <&gpio 11 GPIO_ACTIVE_HIGH>;
> > +            local-bd-address = [66 55 44 33 22 11];
> >           };
> >       };
> 

Thanks,
Neeraj
Paul Menzel Feb. 20, 2025, 12:11 p.m. UTC | #3 
Dear Neeraj,


Thank you for your prompt reply.

Am 20.02.25 um 12:59 schrieb Neeraj Sanjay Kale:

>> Am 20.02.25 um 12:41 schrieb Neeraj Sanjay Kale:
>>> Allow user to set custom BD address for NXP chipsets.
>>>
>>> Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> ---
>>> v2: Add allOf and unevaluatedProperties: false (Krzysztof)
>>> v3: Drop local-bd-address: true (Krzysztof)
>>> ---
>>>    .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml   | 6 +++++-
>>>    1 file changed, 5 insertions(+), 1 deletion(-)
>>>
>>> diff --git
>> a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
>> b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
>>> index 0a2d7baf5db3..a84c1c21b024 100644
>>> --- a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
>>> +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
>>> @@ -17,6 +17,9 @@ description:
>>>    maintainers:
>>>      - Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
>>>
>>> +allOf:
>>> +  - $ref: bluetooth-controller.yaml#
>>> +
>>>    properties:
>>>      compatible:
>>>        enum:
>>> @@ -43,7 +46,7 @@ properties:
>>>    required:
>>>      - compatible
>>>
>>> -additionalProperties: false
>>> +unevaluatedProperties: false
>>
>> How is this diff related to the change mentioned in the commit message?
> 
> This is based on review comment from Krzysztof in V1 DT patch.
> allOf ref will import all properties defined in bluetooth-controller.yaml, including local-bd-address:
> https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/net/bluetooth/bluetooth-controller.yaml#L18

Thank you. I’d include this in the commit message, but my comment was 
about the replacement of `additionalProperties` by `unevaluatedProperties`.

>>>
>>>    examples:
>>>      - |
>>> @@ -54,5 +57,6 @@ examples:
>>>                fw-init-baudrate = <3000000>;
>>>                firmware-name = "uartuart8987_bt_v0.bin";
>>>                device-wakeup-gpios = <&gpio 11 GPIO_ACTIVE_HIGH>;
>>> +            local-bd-address = [66 55 44 33 22 11];
>>>            };
>>>        };

Kind regards,

Paul
Neeraj Sanjay Kale Feb. 20, 2025, 12:30 p.m. UTC | #4 
Hi Paul,
 
> >> Am 20.02.25 um 12:41 schrieb Neeraj Sanjay Kale:
> >>> Allow user to set custom BD address for NXP chipsets.
> >>>
> >>> Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
> >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >>> ---
> >>> v2: Add allOf and unevaluatedProperties: false (Krzysztof)
> >>> v3: Drop local-bd-address: true (Krzysztof)
> >>> ---
> >>>    .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml   | 6 +++++-
> >>>    1 file changed, 5 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git
> >> a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-
> bt.yaml
> >> b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-
> bt.yaml
> >>> index 0a2d7baf5db3..a84c1c21b024 100644
> >>> ---
> >>> a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-
> bt.yam
> >>> l
> >>> +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-
> bt
> >>> +++ .yaml
> >>> @@ -17,6 +17,9 @@ description:
> >>>    maintainers:
> >>>      - Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
> >>>
> >>> +allOf:
> >>> +  - $ref: bluetooth-controller.yaml#
> >>> +
> >>>    properties:
> >>>      compatible:
> >>>        enum:
> >>> @@ -43,7 +46,7 @@ properties:
> >>>    required:
> >>>      - compatible
> >>>
> >>> -additionalProperties: false
> >>> +unevaluatedProperties: false
> >>
> >> How is this diff related to the change mentioned in the commit message?
> >
> > This is based on review comment from Krzysztof in V1 DT patch.
> > allOf ref will import all properties defined in bluetooth-controller.yaml,
> including local-bd-address:
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
> >
> ub.com%2Ftorvalds%2Flinux%2Fblob%2Fmaster%2FDocumentation%2Fdevic
> etree
> > %2Fbindings%2Fnet%2Fbluetooth%2Fbluetooth-
> controller.yaml%23L18&data=0
> >
> 5%7C02%7Cneeraj.sanjaykale%40nxp.com%7Cea6b9bba11954062a8ab08dd5
> 1a7c28
> >
> 9%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638756503156741
> 597%7CUn
> >
> known%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAw
> MCIsIlAiOi
> >
> JXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=Nf
> 5EkxiY
> > rHPZQjCBa1XFeu8Y5T8cXpQwXHZ757YvGFw%3D&reserved=0
> 
> Thank you. I'd include this in the commit message, but my comment was
> about the replacement of `additionalProperties` by `unevaluatedProperties`.
As per DT documentation, if we include other schemas, we must use "unevaluatedProperties:false" instead of "additionalProperties:false"

https://docs.kernel.org/devicetree/bindings/writing-bindings.html

With "additionalProperties:false", make dt_binding_check fails as it is unable to find the 'local-bd-address' property.

> 
> >>>
> >>>    examples:
> >>>      - |
> >>> @@ -54,5 +57,6 @@ examples:
> >>>                fw-init-baudrate = <3000000>;
> >>>                firmware-name = "uartuart8987_bt_v0.bin";
> >>>                device-wakeup-gpios = <&gpio 11 GPIO_ACTIVE_HIGH>;
> >>> +            local-bd-address = [66 55 44 33 22 11];
> >>>            };
> >>>        };
> 

Thanks,
Neeraj
bluez.test.bot@gmail.com Feb. 20, 2025, 12:43 p.m. UTC | #5 
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=935985

---Test result---

Test Summary:
CheckPatch                    PENDING   0.27 seconds
GitLint                       PENDING   0.20 seconds
SubjectPrefix                 FAIL      0.47 seconds
BuildKernel                   PASS      26.85 seconds
CheckAllWarning               PASS      27.61 seconds
CheckSparse                   PASS      31.31 seconds
BuildKernel32                 PASS      25.18 seconds
TestRunnerSetup               PASS      441.12 seconds
TestRunner_l2cap-tester       PASS      21.47 seconds
TestRunner_iso-tester         PASS      42.44 seconds
TestRunner_bnep-tester        PASS      5.14 seconds
TestRunner_mgmt-tester        FAIL      125.21 seconds
TestRunner_rfcomm-tester      PASS      8.12 seconds
TestRunner_sco-tester         PASS      9.85 seconds
TestRunner_ioctl-tester       PASS      8.74 seconds
TestRunner_mesh-tester        PASS      6.25 seconds
TestRunner_smp-tester         PASS      7.58 seconds
TestRunner_userchan-tester    PASS      5.20 seconds
IncrementalBuild              PENDING   0.84 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: SubjectPrefix - FAIL
Desc: Check subject contains "Bluetooth" prefix
Output:
"Bluetooth: " prefix is not specified in the subject
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 490, Passed: 482 (98.4%), Failed: 4, Not Run: 4

Failed Test Cases
LL Privacy - Add Device 2 (2 Devices to AL)          Failed       0.159 seconds
LL Privacy - Set Flags 3 (2 Devices to RL)           Failed       0.190 seconds
LL Privacy - Start Discovery 1 (Disable RL)          Failed       0.170 seconds
LL Privacy - Set Device Flag 1 (Device Privacy)      Failed       0.142 seconds
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth
Conor Dooley Feb. 20, 2025, 5:08 p.m. UTC | #6 
On Thu, Feb 20, 2025 at 01:11:41PM +0100, Paul Menzel wrote:
> Dear Neeraj,
> 
> 
> Thank you for your prompt reply.
> 
> Am 20.02.25 um 12:59 schrieb Neeraj Sanjay Kale:
> 
> > > Am 20.02.25 um 12:41 schrieb Neeraj Sanjay Kale:
> > > > Allow user to set custom BD address for NXP chipsets.
> > > > 
> > > > Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
> > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > > > ---
> > > > v2: Add allOf and unevaluatedProperties: false (Krzysztof)
> > > > v3: Drop local-bd-address: true (Krzysztof)
> > > > ---
> > > >    .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml   | 6 +++++-
> > > >    1 file changed, 5 insertions(+), 1 deletion(-)
> > > > 
> > > > diff --git
> > > a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> > > b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> > > > index 0a2d7baf5db3..a84c1c21b024 100644
> > > > --- a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> > > > +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> > > > @@ -17,6 +17,9 @@ description:
> > > >    maintainers:
> > > >      - Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
> > > > 
> > > > +allOf:
> > > > +  - $ref: bluetooth-controller.yaml#
> > > > +
> > > >    properties:
> > > >      compatible:
> > > >        enum:
> > > > @@ -43,7 +46,7 @@ properties:
> > > >    required:
> > > >      - compatible
> > > > 
> > > > -additionalProperties: false
> > > > +unevaluatedProperties: false
> > > 
> > > How is this diff related to the change mentioned in the commit message?
> > 
> > This is based on review comment from Krzysztof in V1 DT patch.
> > allOf ref will import all properties defined in bluetooth-controller.yaml, including local-bd-address:
> > https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/net/bluetooth/bluetooth-controller.yaml#L18
> 
> Thank you. I’d include this in the commit message, but my comment was about
> the replacement of `additionalProperties` by `unevaluatedProperties`.

The change is needed to permit the property defined in
bluetooth-controller.yaml to be used.
Krzysztof Kozlowski Feb. 20, 2025, 5:59 p.m. UTC | #7 
On 20/02/2025 12:45, Paul Menzel wrote:
> Dear Neeraj,
> 
> 
> Thank you for your patch.
> 
> 
> Am 20.02.25 um 12:41 schrieb Neeraj Sanjay Kale:
>> Allow user to set custom BD address for NXP chipsets.
>>
>> Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> v2: Add allOf and unevaluatedProperties: false (Krzysztof)
>> v3: Drop local-bd-address: true (Krzysztof)
>> ---
>>   .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml   | 6 +++++-
>>   1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
>> index 0a2d7baf5db3..a84c1c21b024 100644
>> --- a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
>> +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
>> @@ -17,6 +17,9 @@ description:
>>   maintainers:
>>     - Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
>>   
>> +allOf:
>> +  - $ref: bluetooth-controller.yaml#
>> +
>>   properties:
>>     compatible:
>>       enum:
>> @@ -43,7 +46,7 @@ properties:
>>   required:
>>     - compatible
>>   
>> -additionalProperties: false
>> +unevaluatedProperties: false
> 
> How is this diff related to the change mentioned in the commit message?

It is exactly related, because otherwise custom BD address would not be
allowed.

Read previous discussions and example schema before questioning, because
otherwise this is nitpicking.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
index 0a2d7baf5db3..a84c1c21b024 100644
--- a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
+++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
@@ -17,6 +17,9 @@  description:
 maintainers:
   - Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
 
+allOf:
+  - $ref: bluetooth-controller.yaml#
+
 properties:
   compatible:
     enum:
@@ -43,7 +46,7 @@  properties:
 required:
   - compatible
 
-additionalProperties: false
+unevaluatedProperties: false
 
 examples:
   - |
@@ -54,5 +57,6 @@  examples:
             fw-init-baudrate = <3000000>;
             firmware-name = "uartuart8987_bt_v0.bin";
             device-wakeup-gpios = <&gpio 11 GPIO_ACTIVE_HIGH>;
+            local-bd-address = [66 55 44 33 22 11];
         };
     };