diff mbox series

[v1] dt-bindings: qcom: geni-se: Rename qcom,geni-se.yaml to qcom,geni-se-qup.yaml

Message ID 20250221085439.235821-1-quic_vdadhani@quicinc.com (mailing list archive)
State New
Headers show
Series [v1] dt-bindings: qcom: geni-se: Rename qcom,geni-se.yaml to qcom,geni-se-qup.yaml | expand

Commit Message

Viken Dadhaniya Feb. 21, 2025, 8:54 a.m. UTC
The qcom,geni-se.yaml file describes the Qualcomm Universal Peripheral
(QUP) wrapper and the common entities required by QUP to run any Serial
Engine (SE) as I2C, SPI, UART, or I3C protocol.

Rename qcom,geni-se.yaml to qcom,geni-se-qup.yaml to better reflect its
association with QUP (Qualcomm Universal Peripheral) and the compatible
string.

Signed-off-by: Viken Dadhaniya <quic_vdadhani@quicinc.com>
---
 .../soc/qcom/{qcom,geni-se.yaml => qcom,geni-se-qup.yaml}       | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 rename Documentation/devicetree/bindings/soc/qcom/{qcom,geni-se.yaml => qcom,geni-se-qup.yaml} (98%)

Comments

Rob Herring (Arm) Feb. 21, 2025, 10:28 a.m. UTC | #1
On Fri, 21 Feb 2025 14:24:39 +0530, Viken Dadhaniya wrote:
> The qcom,geni-se.yaml file describes the Qualcomm Universal Peripheral
> (QUP) wrapper and the common entities required by QUP to run any Serial
> Engine (SE) as I2C, SPI, UART, or I3C protocol.
> 
> Rename qcom,geni-se.yaml to qcom,geni-se-qup.yaml to better reflect its
> association with QUP (Qualcomm Universal Peripheral) and the compatible
> string.
> 
> Signed-off-by: Viken Dadhaniya <quic_vdadhani@quicinc.com>
> ---
>  .../soc/qcom/{qcom,geni-se.yaml => qcom,geni-se-qup.yaml}       | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>  rename Documentation/devicetree/bindings/soc/qcom/{qcom,geni-se.yaml => qcom,geni-se-qup.yaml} (98%)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:


doc reference errors (make refcheckdocs):
Warning: Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml references a file that doesn't exist: Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml
Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml: Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250221085439.235821-1-quic_vdadhani@quicinc.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
Krzysztof Kozlowski Feb. 21, 2025, 11:35 a.m. UTC | #2
On 21/02/2025 09:54, Viken Dadhaniya wrote:
> The qcom,geni-se.yaml file describes the Qualcomm Universal Peripheral
> (QUP) wrapper and the common entities required by QUP to run any Serial
> Engine (SE) as I2C, SPI, UART, or I3C protocol.
> 
> Rename qcom,geni-se.yaml to qcom,geni-se-qup.yaml to better reflect its
> association with QUP (Qualcomm Universal Peripheral) and the compatible
> string.
> 
> Signed-off-by: Viken Dadhaniya <quic_vdadhani@quicinc.com>
> ---
>  .../soc/qcom/{qcom,geni-se.yaml => qcom,geni-se-qup.yaml}       | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>  rename Documentation/devicetree/bindings/soc/qcom/{qcom,geni-se.yaml => qcom,geni-se-qup.yaml} (98%)
> 

That's just churn for no real gain. Not even tested churn.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se-qup.yaml
similarity index 98%
rename from Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml
rename to Documentation/devicetree/bindings/soc/qcom/qcom,geni-se-qup.yaml
index 7b031ef09669..26f806fd627a 100644
--- a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml
+++ b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se-qup.yaml
@@ -1,7 +1,7 @@ 
 # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
 %YAML 1.2
 ---
-$id: http://devicetree.org/schemas/soc/qcom/qcom,geni-se.yaml#
+$id: http://devicetree.org/schemas/soc/qcom/qcom,geni-se-qup.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: GENI Serial Engine QUP Wrapper Controller