diff mbox series

fbtft: Remove access to page->index

Message ID 20250221173131.3470667-1-willy@infradead.org (mailing list archive)
State New
Headers show
Series fbtft: Remove access to page->index | expand

Commit Message

Matthew Wilcox Feb. 21, 2025, 5:31 p.m. UTC
There is no need to print out page->index as part of the debug message.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
 drivers/staging/fbtft/fbtft-core.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Lorenzo Stoakes Feb. 21, 2025, 5:53 p.m. UTC | #1
On Fri, Feb 21, 2025 at 05:31:29PM +0000, Matthew Wilcox (Oracle) wrote:
> There is no need to print out page->index as part of the debug message.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>

LGTM from my side,

Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>

> ---
>  drivers/staging/fbtft/fbtft-core.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
> index 4cfa494243b9..da9c64152a60 100644
> --- a/drivers/staging/fbtft/fbtft-core.c
> +++ b/drivers/staging/fbtft/fbtft-core.c
> @@ -337,9 +337,7 @@ static void fbtft_deferred_io(struct fb_info *info, struct list_head *pagereflis
>  	list_for_each_entry(pageref, pagereflist, list) {
>  		y_low = pageref->offset / info->fix.line_length;
>  		y_high = (pageref->offset + PAGE_SIZE - 1) / info->fix.line_length;
> -		dev_dbg(info->device,
> -			"page->index=%lu y_low=%d y_high=%d\n",
> -			pageref->page->index, y_low, y_high);
> +		dev_dbg(info->device, "y_low=%d y_high=%d\n", y_low, y_high);
>  		if (y_high > info->var.yres - 1)
>  			y_high = info->var.yres - 1;
>  		if (y_low < dirty_lines_start)
> --
> 2.47.2
>
diff mbox series

Patch

diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
index 4cfa494243b9..da9c64152a60 100644
--- a/drivers/staging/fbtft/fbtft-core.c
+++ b/drivers/staging/fbtft/fbtft-core.c
@@ -337,9 +337,7 @@  static void fbtft_deferred_io(struct fb_info *info, struct list_head *pagereflis
 	list_for_each_entry(pageref, pagereflist, list) {
 		y_low = pageref->offset / info->fix.line_length;
 		y_high = (pageref->offset + PAGE_SIZE - 1) / info->fix.line_length;
-		dev_dbg(info->device,
-			"page->index=%lu y_low=%d y_high=%d\n",
-			pageref->page->index, y_low, y_high);
+		dev_dbg(info->device, "y_low=%d y_high=%d\n", y_low, y_high);
 		if (y_high > info->var.yres - 1)
 			y_high = info->var.yres - 1;
 		if (y_low < dirty_lines_start)