mbox series

[v6,0/5] Add support for IPQ5018 tsens

Message ID DS7PR19MB88838833C0A3BFC3C7FC481F9DC02@DS7PR19MB8883.namprd19.prod.outlook.com (mailing list archive)
Headers show
Series Add support for IPQ5018 tsens | expand

Message

George Moussalem Feb. 24, 2025, 6:12 a.m. UTC 
IPQ5018 has tsens V1.0 IP with 4 sensors and 1 interrupt.
There is no RPM present in the soc to do tsens early enable.
Adding support for the same here.

[v6]
	*) Include (this) cover letter
	*) Picked up Dmitry's Reviewed-by tag on patch 5

[v5]
	*) Adjusted commit messages to indicate IPQ5018 has 5 sensors of
	   which 4 are described and in use as per downstream driver and dts.
	*) Padded addresses of tsens and qfprom nodes with leading zeros.

[v4]
	*) Documented ipq5018 in qcom,qfprom bindings
	*) Constrained ipq5018-tsens to one interrupt with description
	*) Added Rob's Acked-by tag
	*) Added Dmitry's Reviewed-by tag
	*) Fixed modpost warning: added __init to init_common
	*) Sorted tsens nodes by address
	*) Sorted thermal-zones nodes by name
	*) Link to v3: https://lore.kernel.org/all/20230922115116.2748804-1-srichara@win-platform-upstream01.qualcomm.com/

[v3]
	*) Added the tsens-ipq5018 as  new binding without rpm
        *) Added Dmitry's Reviewed tag
        *) Fixed Dmitry's comments for error checks in init_ipq5018
        *) Ordered the qfprom device node properties
	*) Link to v2: https://lore.kernel.org/all/20230915121504.806672-1-quic_srichara@quicinc.com/

[v2]
	*) Sorted the compatible and removed example
	*) Fixed the name for new tsens_feature
	*) Used tsend_calibrate_common instead of legacy
	   and addressed comments from Dmitry.
	*) Squashed patch 3 & 4
	*) Fixed node names, order and added qfprom cells
            for points seprately
	*) Squashed patch 6 & 7
	*) Link to v1: https://lore.kernel.org/all/1693250307-8910-1-git-send-email-quic_srichara@quicinc.com/


Sricharan Ramabadhran (5):
  dt-bindings: nvmem: Add compatible for IPQ5018
  dt-bindings: thermal: qcom-tsens: Add ipq5018 compatible
  thermal: drivers: qcom: Add new feat for soc without rpm
  thermal: qcom: tsens: Add support for IPQ5018 tsens
  arm64: dts: qcom: ipq5018: Add tsens node

 .../bindings/nvmem/qcom,qfprom.yaml           |   1 +
 .../bindings/thermal/qcom-tsens.yaml          |   2 +
 arch/arm64/boot/dts/qcom/ipq5018.dtsi         | 169 ++++++++++++++++++
 drivers/thermal/qcom/tsens-v1.c               |  60 +++++++
 drivers/thermal/qcom/tsens.c                  |   5 +-
 drivers/thermal/qcom/tsens.h                  |   5 +-
 6 files changed, 240 insertions(+), 2 deletions(-)

Comments

Krzysztof Kozlowski Feb. 24, 2025, 9:22 a.m. UTC | #1 
On 24/02/2025 07:12, George Moussalem wrote:
> IPQ5018 has tsens V1.0 IP with 4 sensors and 1 interrupt.
> There is no RPM present in the soc to do tsens early enable.
> Adding support for the same here.
> 
v4 received this comment:

"That's fine, but should be mentioned in cover letter. Anytime you take
someone else's patchset, please say shortly why, so maintainers won't
deal with duplicated submissions for example."

You never responded to it and I do not see how this was implemented.

Best regards,
Krzysztof
George Moussalem Feb. 24, 2025, 10:14 a.m. UTC | #2 
Thanks Krzysztof, circling back to acknowledge the feedback.
Missed it, but will add the reasoning in the next version.

Best regards,
George
Krzysztof Kozlowski Feb. 24, 2025, 10:16 a.m. UTC | #3 
On 24/02/2025 11:14, George Moussalem wrote:
> Thanks Krzysztof, circling back to acknowledge the feedback.
> Missed it, but will add the reasoning in the next version.
Respond inline, I have no clue what is this about.

Best regards,
Krzysztof