| Message ID | 20250224062927.2829186-1-hchaudhari@marvell.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2,1/1] net: mvpp2: cls: Fixed Non IP flow, with vlan tag flow defination. | expand |
Hello, On Sun, 23 Feb 2025 22:29:27 -0800 Harshal Chaudhari <hchaudhari@marvell.com> wrote: > Fixes: 1274daede3ef ("net: mvpp2: cls: Add steering based on vlan Id and priority.") > > Non IP flow, with vlan tag not working as expected while > running below command for vlan-priority. fixed that. > > ethtool -N eth1 flow-type ether vlan 0x8000 vlan-mask 0x1fff action 0 loc 0 > > Change from v1: > * Added the fixes tag > > Signed-off-by: Harshal Chaudhari <hchaudhari@marvell.com> Well spotted, thanks for fixing this Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com> Maxime
On Sun, 23 Feb 2025 22:29:27 -0800 Harshal Chaudhari <hchaudhari@marvell.com> wrote: > Fixes: 1274daede3ef ("net: mvpp2: cls: Add steering based on vlan Id and priority.") Well, that tag should be alongside your SoB (just before it) > Non IP flow, with vlan tag not working as expected while > running below command for vlan-priority. fixed that. > > ethtool -N eth1 flow-type ether vlan 0x8000 vlan-mask 0x1fff action 0 loc 0 > > Change from v1: > * Added the fixes tag This should be below the "---", as it won't be in the final commit log. > Signed-off-by: Harshal Chaudhari <hchaudhari@marvell.com> > --- here > drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c > index 1641791a2d5b..8ed83fb98862 100644 > --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c > +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c > @@ -324,7 +324,7 @@ static const struct mvpp2_cls_flow cls_flows[MVPP2_N_PRS_FLOWS] = { > MVPP2_PRS_RI_VLAN_MASK), > /* Non IP flow, with vlan tag */ > MVPP2_DEF_FLOW(MVPP22_FLOW_ETHERNET, MVPP2_FL_NON_IP_TAG, > - MVPP22_CLS_HEK_OPT_VLAN, > + MVPP22_CLS_HEK_TAGGED, > 0, 0), > }; > Maxime
diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c index 1641791a2d5b..8ed83fb98862 100644 --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c @@ -324,7 +324,7 @@ static const struct mvpp2_cls_flow cls_flows[MVPP2_N_PRS_FLOWS] = { MVPP2_PRS_RI_VLAN_MASK), /* Non IP flow, with vlan tag */ MVPP2_DEF_FLOW(MVPP22_FLOW_ETHERNET, MVPP2_FL_NON_IP_TAG, - MVPP22_CLS_HEK_OPT_VLAN, + MVPP22_CLS_HEK_TAGGED, 0, 0), };
Fixes: 1274daede3ef ("net: mvpp2: cls: Add steering based on vlan Id and priority.") Non IP flow, with vlan tag not working as expected while running below command for vlan-priority. fixed that. ethtool -N eth1 flow-type ether vlan 0x8000 vlan-mask 0x1fff action 0 loc 0 Change from v1: * Added the fixes tag Signed-off-by: Harshal Chaudhari <hchaudhari@marvell.com> --- drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)