mbox series

[iwl-net,0/4] ice: improve validation of virtchnl parameters

Message ID 20250217102744.300357-2-martyna.szapar-mudlaw@linux.intel.com (mailing list archive)
Headers show
Series ice: improve validation of virtchnl parameters | expand

Message

Martyna Szapar-Mudlaw Feb. 17, 2025, 10:27 a.m. UTC
This patch series introduces improvements to the `ice` driver and `virtchnl`
interface by adding stricter validation checks and preventing potential
out-of-bounds scenarios.

Jan Glaza (3):
  virtchnl: make proto and filter action count unsigned
  ice: stop truncating queue ids when checking
  ice: validate queue quanta parameters to prevent OOB access

Lukasz Czapnik (1):
  ice: fix input validation for virtchnl BW

 drivers/net/ethernet/intel/ice/ice_virtchnl.c | 39 +++++++++++++++----
 include/linux/avf/virtchnl.h                  |  4 +-
 2 files changed, 33 insertions(+), 10 deletions(-)

Comments

Simon Horman Feb. 18, 2025, 7:44 p.m. UTC | #1
On Mon, Feb 17, 2025 at 11:27:41AM +0100, Martyna Szapar-Mudlaw wrote:
> This patch series introduces improvements to the `ice` driver and `virtchnl`
> interface by adding stricter validation checks and preventing potential
> out-of-bounds scenarios.

Hi Martyna,

The above talks about this patchset in terms of improvements rather than
bug fixes (that manifest). If so, I think this should be targeted at
iwl-next (i.e. net-next) rather than iwl-net (net). And the Fixes tags
should be dropped.

...
Martyna Szapar-Mudlaw Feb. 25, 2025, 9:24 a.m. UTC | #2
On 2/18/2025 8:44 PM, Simon Horman wrote:
> On Mon, Feb 17, 2025 at 11:27:41AM +0100, Martyna Szapar-Mudlaw wrote:
>> This patch series introduces improvements to the `ice` driver and `virtchnl`
>> interface by adding stricter validation checks and preventing potential
>> out-of-bounds scenarios.
> 
> Hi Martyna,
> 
> The above talks about this patchset in terms of improvements rather than
> bug fixes (that manifest). If so, I think this should be targeted at
> iwl-next (i.e. net-next) rather than iwl-net (net). And the Fixes tags
> should be dropped.
> 

Hi Simon,

Thank for looking into this. I believe these patches provide fixes and 
would fit better with iwl-net since they correct improper value 
checking, ensuring that the driver can properly handle and reject 
invalid inputs from potentially malicious VFs.
I sent v2 with rephrased cover letter and some commit messages.

Thanks.
Martyna

> ...
>