| Message ID | 20250225-expressatt-tsens-v1-1-024bee5f2047@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | ARM: dts: qcom: msm8960: add tsens | expand |
On Tue, Feb 25, 2025 at 01:19:44AM -0800, Rudraksha Gupta wrote: > Copy tsens node from ap8064 and adjust some values > > Co-developed-by: wctrl <wctrl@proton.me> > Signed-off-by: wctrl <wctrl@proton.me> > Signed-off-by: Rudraksha Gupta <guptarud@gmail.com> > --- > arch/arm/boot/dts/qcom/qcom-msm8960.dtsi | 62 +++++++++++++++++++++++++++++++- > 1 file changed, 61 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi > index 865fe7cc39511d7cb9ec5c4b12100404f77e2989..167953605447bfaa0d33b0e41b581220f86c72e6 100644 > --- a/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi > +++ b/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi > @@ -52,6 +52,40 @@ memory@80000000 { > reg = <0x80000000 0>; > }; > > + thermal-zones { > + cpu0-thermal { > + polling-delay-passive = <250>; > + polling-delay = <1000>; > + > + thermal-sensors = <&tsens 0>; > + coefficients = <1199 0>; Doesn't tsens driver read the slope and offset from the EEPROM? > + > + > + tsens_calib: calib@404 { > + reg = <0x404 0x10>; > + }; > + tsens_backup: backup-calib@414 { > + reg = <0x414 0x10>; > + }; missing empty line between nodes > + }; > + > msmgpio: pinctrl@800000 { > compatible = "qcom,msm8960-pinctrl"; > gpio-controller; > @@ -127,7 +175,7 @@ msmgpio: pinctrl@800000 { > }; > > gcc: clock-controller@900000 { > - compatible = "qcom,gcc-msm8960"; > + compatible = "qcom,gcc-msm8960", "syscon"; > #clock-cells = <1>; > #reset-cells = <1>; > reg = <0x900000 0x4000>; > @@ -135,6 +183,18 @@ gcc: clock-controller@900000 { > <&pxo_board>, > <&lcc PLL4>; > clock-names = "cxo", "pxo", "pll4"; > + > + tsens: thermal-sensor { > + compatible = "qcom,msm8960-tsens"; > + > + nvmem-cells = <&tsens_calib>, <&tsens_backup>; > + nvmem-cell-names = "calib", "calib_backup"; > + interrupts = <GIC_SPI 178 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "uplow"; > + > + #qcom,sensors = <5>; > + #thermal-sensor-cells = <1>; > + }; > }; > > lcc: clock-controller@28000000 { > > --- > base-commit: ffd294d346d185b70e28b1a28abe367bbfe53c04 > change-id: 20250225-expressatt-tsens-06d46587a584 > > Best regards, > -- > Rudraksha Gupta <guptarud@gmail.com> >
On Tue, 25 Feb 2025 01:19:44 -0800, Rudraksha Gupta wrote: > Copy tsens node from ap8064 and adjust some values > > Co-developed-by: wctrl <wctrl@proton.me> > Signed-off-by: wctrl <wctrl@proton.me> > Signed-off-by: Rudraksha Gupta <guptarud@gmail.com> > --- > arch/arm/boot/dts/qcom/qcom-msm8960.dtsi | 62 +++++++++++++++++++++++++++++++- > 1 file changed, 61 insertions(+), 1 deletion(-) > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/qcom/' for 20250225-expressatt-tsens-v1-1-024bee5f2047@gmail.com: arch/arm/boot/dts/qcom/qcom-msm8960-cdp.dtb: efuse@700000: compatible:0: 'qcom,qfprom' is not one of ['qcom,apq8064-qfprom', 'qcom,apq8084-qfprom', 'qcom,ipq5332-qfprom', 'qcom,ipq6018-qfprom', 'qcom,ipq8064-qfprom', 'qcom,ipq8074-qfprom', 'qcom,ipq9574-qfprom', 'qcom,msm8226-qfprom', 'qcom,msm8916-qfprom', 'qcom,msm8974-qfprom', 'qcom,msm8976-qfprom', 'qcom,msm8996-qfprom', 'qcom,msm8998-qfprom', 'qcom,qcm2290-qfprom', 'qcom,qcs404-qfprom', 'qcom,sc7180-qfprom', 'qcom,sc7280-qfprom', 'qcom,sc8280xp-qfprom', 'qcom,sdm630-qfprom', 'qcom,sdm670-qfprom', 'qcom,sdm845-qfprom', 'qcom,sm6115-qfprom', 'qcom,sm6350-qfprom', 'qcom,sm6375-qfprom', 'qcom,sm8150-qfprom', 'qcom,sm8250-qfprom', 'qcom,sm8450-qfprom', 'qcom,sm8550-qfprom', 'qcom,sm8650-qfprom'] from schema $id: http://devicetree.org/schemas/nvmem/qcom,qfprom.yaml# arch/arm/boot/dts/qcom/qcom-msm8960-cdp.dtb: efuse@700000: compatible: ['qcom,qfprom'] is too short from schema $id: http://devicetree.org/schemas/nvmem/qcom,qfprom.yaml# arch/arm/boot/dts/qcom/qcom-msm8960-cdp.dtb: efuse@700000: Unevaluated properties are not allowed ('compatible' was unexpected) from schema $id: http://devicetree.org/schemas/nvmem/qcom,qfprom.yaml# arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dtb: efuse@700000: compatible:0: 'qcom,qfprom' is not one of ['qcom,apq8064-qfprom', 'qcom,apq8084-qfprom', 'qcom,ipq5332-qfprom', 'qcom,ipq6018-qfprom', 'qcom,ipq8064-qfprom', 'qcom,ipq8074-qfprom', 'qcom,ipq9574-qfprom', 'qcom,msm8226-qfprom', 'qcom,msm8916-qfprom', 'qcom,msm8974-qfprom', 'qcom,msm8976-qfprom', 'qcom,msm8996-qfprom', 'qcom,msm8998-qfprom', 'qcom,qcm2290-qfprom', 'qcom,qcs404-qfprom', 'qcom,sc7180-qfprom', 'qcom,sc7280-qfprom', 'qcom,sc8280xp-qfprom', 'qcom,sdm630-qfprom', 'qcom,sdm670-qfprom', 'qcom,sdm845-qfprom', 'qcom,sm6115-qfprom', 'qcom,sm6350-qfprom', 'qcom,sm6375-qfprom', 'qcom,sm8150-qfprom', 'qcom,sm8250-qfprom', 'qcom,sm8450-qfprom', 'qcom,sm8550-qfprom', 'qcom,sm8650-qfprom'] from schema $id: http://devicetree.org/schemas/nvmem/qcom,qfprom.yaml# arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dtb: efuse@700000: compatible: ['qcom,qfprom'] is too short from schema $id: http://devicetree.org/schemas/nvmem/qcom,qfprom.yaml# arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dtb: efuse@700000: Unevaluated properties are not allowed ('compatible' was unexpected) from schema $id: http://devicetree.org/schemas/nvmem/qcom,qfprom.yaml#
diff --git a/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi index 865fe7cc39511d7cb9ec5c4b12100404f77e2989..167953605447bfaa0d33b0e41b581220f86c72e6 100644 --- a/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi +++ b/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi @@ -52,6 +52,40 @@ memory@80000000 { reg = <0x80000000 0>; }; + thermal-zones { + cpu0-thermal { + polling-delay-passive = <250>; + polling-delay = <1000>; + + thermal-sensors = <&tsens 0>; + coefficients = <1199 0>; + + trips { + cpu_alert0: trip0 { + temperature = <60000>; + hysteresis = <10000>; + type = "passive"; + }; + }; + }; + + cpu1-thermal { + polling-delay-passive = <250>; + polling-delay = <1000>; + + thermal-sensors = <&tsens 1>; + coefficients = <1132 0>; + + trips { + cpu_alert1: trip0 { + temperature = <60000>; + hysteresis = <10000>; + type = "passive"; + }; + }; + }; + }; + cpu-pmu { compatible = "qcom,krait-pmu"; interrupts = <GIC_PPI 10 0x304>; @@ -115,6 +149,20 @@ timer@200a000 { cpu-offset = <0x80000>; }; + qfprom: efuse@700000 { + compatible = "qcom,qfprom"; + reg = <0x00700000 0x1000>; + #address-cells = <1>; + #size-cells = <1>; + + tsens_calib: calib@404 { + reg = <0x404 0x10>; + }; + tsens_backup: backup-calib@414 { + reg = <0x414 0x10>; + }; + }; + msmgpio: pinctrl@800000 { compatible = "qcom,msm8960-pinctrl"; gpio-controller; @@ -127,7 +175,7 @@ msmgpio: pinctrl@800000 { }; gcc: clock-controller@900000 { - compatible = "qcom,gcc-msm8960"; + compatible = "qcom,gcc-msm8960", "syscon"; #clock-cells = <1>; #reset-cells = <1>; reg = <0x900000 0x4000>; @@ -135,6 +183,18 @@ gcc: clock-controller@900000 { <&pxo_board>, <&lcc PLL4>; clock-names = "cxo", "pxo", "pll4"; + + tsens: thermal-sensor { + compatible = "qcom,msm8960-tsens"; + + nvmem-cells = <&tsens_calib>, <&tsens_backup>; + nvmem-cell-names = "calib", "calib_backup"; + interrupts = <GIC_SPI 178 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "uplow"; + + #qcom,sensors = <5>; + #thermal-sensor-cells = <1>; + }; }; lcc: clock-controller@28000000 {