| Message ID | 20250224061717.1095226-10-ankit.k.nautiyal@intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Use VRR timing generator for fixed refresh rate modes | expand |
On Mon, Feb 24, 2025 at 11:47:06AM +0530, Ankit Nautiyal wrote: > Add support for using VRR Timing generator for HDMI panels. Please provide actual justification for this. And some kind of explanation what kind of timings this will give us and why. > > Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com> > Reviewed-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com> > --- > drivers/gpu/drm/i915/display/intel_hdmi.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c > index ed017d9de920..28130436735f 100644 > --- a/drivers/gpu/drm/i915/display/intel_hdmi.c > +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c > @@ -64,6 +64,7 @@ > #include "intel_panel.h" > #include "intel_pfit.h" > #include "intel_snps_phy.h" > +#include "intel_vrr.h" > > static void > assert_hdmi_port_disabled(struct intel_hdmi *intel_hdmi) > @@ -2384,6 +2385,8 @@ int intel_hdmi_compute_config(struct intel_encoder *encoder, > } > } > > + intel_vrr_compute_config(pipe_config, conn_state); > + > intel_hdmi_compute_gcp_infoframe(encoder, pipe_config, > conn_state); > > -- > 2.45.2
On 2/26/2025 7:00 PM, Ville Syrjälä wrote: > On Mon, Feb 24, 2025 at 11:47:06AM +0530, Ankit Nautiyal wrote: >> Add support for using VRR Timing generator for HDMI panels. > Please provide actual justification for this. And some kind of > explanation what kind of timings this will give us and why. You are right. The commit message is giving an impression that the patch will enable VRR for HDMI which is incorrect. Will provide proper explanation/justification here and for MST case too in the next patch. Regards, Ankit > >> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com> >> Reviewed-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com> >> --- >> drivers/gpu/drm/i915/display/intel_hdmi.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c >> index ed017d9de920..28130436735f 100644 >> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c >> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c >> @@ -64,6 +64,7 @@ >> #include "intel_panel.h" >> #include "intel_pfit.h" >> #include "intel_snps_phy.h" >> +#include "intel_vrr.h" >> >> static void >> assert_hdmi_port_disabled(struct intel_hdmi *intel_hdmi) >> @@ -2384,6 +2385,8 @@ int intel_hdmi_compute_config(struct intel_encoder *encoder, >> } >> } >> >> + intel_vrr_compute_config(pipe_config, conn_state); >> + >> intel_hdmi_compute_gcp_infoframe(encoder, pipe_config, >> conn_state); >> >> -- >> 2.45.2
diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c index ed017d9de920..28130436735f 100644 --- a/drivers/gpu/drm/i915/display/intel_hdmi.c +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c @@ -64,6 +64,7 @@ #include "intel_panel.h" #include "intel_pfit.h" #include "intel_snps_phy.h" +#include "intel_vrr.h" static void assert_hdmi_port_disabled(struct intel_hdmi *intel_hdmi) @@ -2384,6 +2385,8 @@ int intel_hdmi_compute_config(struct intel_encoder *encoder, } } + intel_vrr_compute_config(pipe_config, conn_state); + intel_hdmi_compute_gcp_infoframe(encoder, pipe_config, conn_state);