| Message ID | 20250212195656.69528-2-slavine@d3embedded.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | media: i2c: Add driver for Sony IMX728 | expand |
On 12/02/2025 20:56, Sebastian LaVine wrote: > + > + reset-gpios: > + maxItems: 1 > + description: > + Specifier for the GPIO connected to the XCLR (System Reset) pin. s/Specifier for the GPIO connected to the// But you could say that it is active low, for example. > + > + error0-gpios: > + maxItems: 1 > + description: > + Specifier for the GPIO connected to the XWRN pin. The same. > + > + error1-gpios: > + maxItems: 1 > + description: > + Specifier for the GPIO connected to the XERR pin. > + > + port: > + $ref: /schemas/graph.yaml#/properties/port > + additionalProperties: false > + > + properties: > + endpoint: > + $ref: ../video-interfaces.yaml# > + unevaluatedProperties: false > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - port > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + > + i2c { > + clock-frequency = <400000>; Drop, not really relevant. > + #address-cells = <1>; > + #size-cells = <0>; > + > + camera@1a { > + compatible = "sony,imx728"; > + reg = <0x1a>; > + > + clocks = <&fixed_clock>; > + clock-names = "inck"; > + > + reset-gpios = <&gpio4 17 GPIO_ACTIVE_LOW>; > + error0-gpios = <&sens_exp 1 GPIO_ACTIVE_HIGH>; > + error1-gpios = <&sens_exp 2 GPIO_ACTIVE_HIGH>; > + > + port { > + camera1: endpoint { > + remote-endpoint = <&vin1a_ep>; > + }; > + }; > + }; > + }; > + > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index 575f0e6f0532..50bff3558d7d 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -21885,6 +21885,12 @@ T: git git://linuxtv.org/media.git > F: Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml > F: drivers/media/i2c/imx415.c > > +SONY IMX728 SENSOR DRIVER > +M: Stuart Burtner <sburtner@d3embedded.com> > +L: linux-media@vger.kernel.org > +S: Odd Fixes Hm, why only odd fixes? If you don't care about driver, we also kind of might not care and remove it soon. > +F: Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml > + > SONY MEMORYSTICK SUBSYSTEM > M: Maxim Levitsky <maximlevitsky@gmail.com> > M: Alex Dubov <oakad@yahoo.com> > -- > 2.34.1 > > Please be aware that this email includes email addresses outside of the organization. Obviously. Please drop it. You can use b4 relay if you need to escape corporate junk. Best regards, Krzysztof
On Wed, Feb 12, 2025 at 02:56:53PM -0500, Sebastian LaVine wrote: > Adds bindings for the Sony IMX728. > > Signed-off-by: Sebastian LaVine <slavine@d3embedded.com> > Mentored-by: Stuart Burtner <sburtner@d3embedded.com> > --- Please run scripts/checkpatch.pl and fix reported warnings. After that, run also 'scripts/checkpatch.pl --strict' and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. Best regards, Krzysztof
Hello Krzysztof, On Thu Feb 13, 2025 at 4:26 AM EST, Krzysztof Kozlowski wrote: > On Wed, Feb 12, 2025 at 02:56:53PM -0500, Sebastian LaVine wrote: >> Adds bindings for the Sony IMX728. >> >> Signed-off-by: Sebastian LaVine <slavine@d3embedded.com> >> Mentored-by: Stuart Burtner <sburtner@d3embedded.com> >> --- > > Please run scripts/checkpatch.pl and fix reported warnings. After that, > run also 'scripts/checkpatch.pl --strict' and (probably) fix more > warnings. Some warnings can be ignored, especially from --strict run, > but the code here looks like it needs a fix. Feel free to get in touch > if the warning is not clear. The only output I get from scripts/checkpatch.pl for this patch is the following: > next$ scripts/checkpatch.pl --strict patches/outgoing/0001-media-dt-bindings-Add-Sony-IMX728.patch > WARNING: Non-standard signature: Mentored-by: > #9: > Mentored-by: Stuart Burtner <sburtner@d3embedded.com> > > total: 0 errors, 1 warnings, 0 checks, 108 lines checked > > ... I can change this to a Signed-off-by from Stuart if you would like, though I feel that Mentored-by is applicable to this case. Thanks, -- Sebastian Please be aware that this email includes email addresses outside of the organization.
I'll put Stuart as Acked-By in future patches. Thanks, -- Sebastian Please be aware that this email includes email addresses outside of the organization.
On Wed Feb 12, 2025 at 3:07 PM EST, Krzysztof Kozlowski wrote: > On 12/02/2025 20:56, Sebastian LaVine wrote: >> + >> + reset-gpios: >> + maxItems: 1 >> + description: >> + Specifier for the GPIO connected to the XCLR (System Reset) pin. > > s/Specifier for the GPIO connected to the// > But you could say that it is active low, for example. > >> + >> + error0-gpios: >> + maxItems: 1 >> + description: >> + Specifier for the GPIO connected to the XWRN pin. > > The same. > Thanks, I'll make this change in v4. >> >> ... >> >> + >> +examples: >> + - | >> + #include <dt-bindings/gpio/gpio.h> >> + >> + i2c { >> + clock-frequency = <400000>; > > Drop, not really relevant. Ack, I'll remove in v4. >> >> ... >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 575f0e6f0532..50bff3558d7d 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -21885,6 +21885,12 @@ T: git git://linuxtv.org/media.git >> F: Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml >> F: drivers/media/i2c/imx415.c >> >> +SONY IMX728 SENSOR DRIVER >> +M: Stuart Burtner <sburtner@d3embedded.com> >> +L: linux-media@vger.kernel.org >> +S: Odd Fixes > > > Hm, why only odd fixes? If you don't care about driver, we also kind of > might not care and remove it soon. > Understood -- we've discussed this and Stuart will be able to commit to "Maintained" status going forward. I'll update this for v4. > > ... > > Obviously. Please drop it. You can use b4 relay if you need to escape > corporate junk. > Sorry about that. I can look into using `b4 relay` going forward to prevent that message from being added to patches. Unfortunately I'm not sure of a way to remove it from my normal mail (like this message). Thanks, -- Sebastian Please be aware that this email includes email addresses outside of the organization.
On 26/02/2025 18:50, Sebastian LaVine wrote: > Hello Krzysztof, > > On Thu Feb 13, 2025 at 4:26 AM EST, Krzysztof Kozlowski wrote: >> On Wed, Feb 12, 2025 at 02:56:53PM -0500, Sebastian LaVine wrote: >>> Adds bindings for the Sony IMX728. >>> >>> Signed-off-by: Sebastian LaVine <slavine@d3embedded.com> >>> Mentored-by: Stuart Burtner <sburtner@d3embedded.com> >>> --- >> >> Please run scripts/checkpatch.pl and fix reported warnings. After that, >> run also 'scripts/checkpatch.pl --strict' and (probably) fix more >> warnings. Some warnings can be ignored, especially from --strict run, >> but the code here looks like it needs a fix. Feel free to get in touch >> if the warning is not clear. > > The only output I get from scripts/checkpatch.pl for this patch is the > following: > >> next$ scripts/checkpatch.pl --strict patches/outgoing/0001-media-dt-bindings-Add-Sony-IMX728.patch >> WARNING: Non-standard signature: Mentored-by: >> #9: >> Mentored-by: Stuart Burtner <sburtner@d3embedded.com> >> >> total: 0 errors, 1 warnings, 0 checks, 108 lines checked >> >> ... > > I can change this to a Signed-off-by from Stuart if you would like, > though I feel that Mentored-by is applicable to this case. It has been two weeks, so I don't remember what warning I saw (countless of patches in between). It's possible I had in mind the "mentored-by", because it's nowhere explained in Linux. Does it mean part of DCO chain? Does it mean reviews or suggestions? This should be one of standard tags, IMO, with all its effects (because tags have meaning, e.g. DCO or reviewer's statement of oversight). Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml new file mode 100644 index 000000000000..f76000ed7bff --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml @@ -0,0 +1,96 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/sony,imx728.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Sony IMX728 Camera Sensor + +maintainers: + - Stuart Burtner <sburtner@d3embedded.com> + +description: + The Sony IMX728 is a 1/1.72-Inch CMOS Solid-state image sensor with a + color square pixel array and 8.39M active pixels. It is programmed + through an I2C interface. + + The sensor can output up to 3840x2160 at a maximum of 45 frames/s over + a CSI-2 serial interface. It supports RAW24/20/16/12 and 10. + +properties: + compatible: + enum: + - sony,imx728 + + reg: + maxItems: 1 + + clocks: + description: Clock frequency from 18 to 30MHz + maxItems: 1 + + clock-names: + const: inck + + reset-gpios: + maxItems: 1 + description: + Specifier for the GPIO connected to the XCLR (System Reset) pin. + + error0-gpios: + maxItems: 1 + description: + Specifier for the GPIO connected to the XWRN pin. + + error1-gpios: + maxItems: 1 + description: + Specifier for the GPIO connected to the XERR pin. + + port: + $ref: /schemas/graph.yaml#/properties/port + additionalProperties: false + + properties: + endpoint: + $ref: ../video-interfaces.yaml# + unevaluatedProperties: false + +required: + - compatible + - reg + - clocks + - clock-names + - port + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + i2c { + clock-frequency = <400000>; + #address-cells = <1>; + #size-cells = <0>; + + camera@1a { + compatible = "sony,imx728"; + reg = <0x1a>; + + clocks = <&fixed_clock>; + clock-names = "inck"; + + reset-gpios = <&gpio4 17 GPIO_ACTIVE_LOW>; + error0-gpios = <&sens_exp 1 GPIO_ACTIVE_HIGH>; + error1-gpios = <&sens_exp 2 GPIO_ACTIVE_HIGH>; + + port { + camera1: endpoint { + remote-endpoint = <&vin1a_ep>; + }; + }; + }; + }; + +... diff --git a/MAINTAINERS b/MAINTAINERS index 575f0e6f0532..50bff3558d7d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -21885,6 +21885,12 @@ T: git git://linuxtv.org/media.git F: Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml F: drivers/media/i2c/imx415.c +SONY IMX728 SENSOR DRIVER +M: Stuart Burtner <sburtner@d3embedded.com> +L: linux-media@vger.kernel.org +S: Odd Fixes +F: Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml + SONY MEMORYSTICK SUBSYSTEM M: Maxim Levitsky <maximlevitsky@gmail.com> M: Alex Dubov <oakad@yahoo.com>
Adds bindings for the Sony IMX728. Signed-off-by: Sebastian LaVine <slavine@d3embedded.com> Mentored-by: Stuart Burtner <sburtner@d3embedded.com> --- .../bindings/media/i2c/sony,imx728.yaml | 96 +++++++++++++++++++ MAINTAINERS | 6 ++ 2 files changed, 102 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml -- 2.34.1 Please be aware that this email includes email addresses outside of the organization.