| Message ID | 20250222095028.48818-1-wahrenst@gmx.net (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 95032938c7c9b2e5ebb69f0ee10ebe340fa3af53 |
| Headers | show |
| Series | [RESEND] dmaengine: bcm2835-dma: fix warning when CONFIG_PM=n | expand |
On 2/22/2025 1:50 AM, Stefan Wahren wrote: > The old SET_LATE_SYSTEM_SLEEP_PM_OPS macro cause a build warning > when CONFIG_PM is disabled: > > warning: 'bcm2835_dma_suspend_late' defined but not used [-Wunused-function] > > Change this to the modern replacement. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202501071533.yrFb156H-lkp@intel.com/ > Signed-off-by: Stefan Wahren <wahrenst@gmx.net> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
On Sat, 22 Feb 2025 10:50:28 +0100, Stefan Wahren wrote: > The old SET_LATE_SYSTEM_SLEEP_PM_OPS macro cause a build warning > when CONFIG_PM is disabled: > > warning: 'bcm2835_dma_suspend_late' defined but not used [-Wunused-function] > > Change this to the modern replacement. > > [...] Applied, thanks! [1/1] dmaengine: bcm2835-dma: fix warning when CONFIG_PM=n commit: 95032938c7c9b2e5ebb69f0ee10ebe340fa3af53 Best regards,
diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c index 20b10c15c696..0117bb2e8591 100644 --- a/drivers/dma/bcm2835-dma.c +++ b/drivers/dma/bcm2835-dma.c @@ -893,7 +893,7 @@ static int bcm2835_dma_suspend_late(struct device *dev) } static const struct dev_pm_ops bcm2835_dma_pm_ops = { - SET_LATE_SYSTEM_SLEEP_PM_OPS(bcm2835_dma_suspend_late, NULL) + LATE_SYSTEM_SLEEP_PM_OPS(bcm2835_dma_suspend_late, NULL) }; static int bcm2835_dma_probe(struct platform_device *pdev)
The old SET_LATE_SYSTEM_SLEEP_PM_OPS macro cause a build warning when CONFIG_PM is disabled: warning: 'bcm2835_dma_suspend_late' defined but not used [-Wunused-function] Change this to the modern replacement. Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202501071533.yrFb156H-lkp@intel.com/ Signed-off-by: Stefan Wahren <wahrenst@gmx.net> --- drivers/dma/bcm2835-dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.34.1