| Message ID | 20250226-max77759-mfd-v2-1-a65ebe2bc0a9@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Maxim Integrated MAX77759 PMIC MFD-based drivers | expand |
On Wed, 26 Feb 2025 17:51:20 +0000, André Draszik wrote: > The Maxim MAX77759 is a companion PMIC for USB Type-C applications and > includes Battery Charger, Fuel Gauge, temperature sensors, USB Type-C > Port Controller (TCPC), NVMEM, and a GPIO expander. > > This describes its GPIO module. > > Signed-off-by: André Draszik <andre.draszik@linaro.org> > > --- > v2: > * drop 'interrupts' property and sort properties alphabetically > --- > .../bindings/gpio/maxim,max77759-gpio.yaml | 44 ++++++++++++++++++++++ > MAINTAINERS | 6 +++ > 2 files changed, 50 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): Warning: Documentation/devicetree/bindings/gpio/maxim,max77759-gpio.yaml references a file that doesn't exist: Documentation/devicetree/bindings/mfd/maxim,max77759.yaml Documentation/devicetree/bindings/gpio/maxim,max77759-gpio.yaml: Documentation/devicetree/bindings/mfd/maxim,max77759.yaml See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250226-max77759-mfd-v2-1-a65ebe2bc0a9@linaro.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Wed, 2025-02-26 at 14:30 -0600, Rob Herring (Arm) wrote: > > On Wed, 26 Feb 2025 17:51:20 +0000, André Draszik wrote: > > The Maxim MAX77759 is a companion PMIC for USB Type-C applications and > > includes Battery Charger, Fuel Gauge, temperature sensors, USB Type-C > > Port Controller (TCPC), NVMEM, and a GPIO expander. > > > > This describes its GPIO module. > > > > Signed-off-by: André Draszik <andre.draszik@linaro.org> > > > > --- > > v2: > > * drop 'interrupts' property and sort properties alphabetically > > --- > > .../bindings/gpio/maxim,max77759-gpio.yaml | 44 ++++++++++++++++++++++ > > MAINTAINERS | 6 +++ > > 2 files changed, 50 insertions(+) > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > > > doc reference errors (make refcheckdocs): > Warning: Documentation/devicetree/bindings/gpio/maxim,max77759-gpio.yaml references a file that doesn't exist: > Documentation/devicetree/bindings/mfd/maxim,max77759.yaml > Documentation/devicetree/bindings/gpio/maxim,max77759-gpio.yaml: Documentation/devicetree/bindings/mfd/maxim,max77759.yaml > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250226-max77759-mfd-v2-1-a65ebe2bc0a9@linaro.org > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: 'make dt_binding_check' doesn't invoke 'make refcheckdocs', unless I'm doing something wrong - and therefore 'make dt_binding_check' doesn't print any warning, contrary to what seems to be implied by the paragraph above, If I run 'make refcheckdocs', I do get the error, too, sure enough. I've never come across refcheckdocs, and it wasn't on my radar. The error is because the binding's 'description:' references the mfd binding using the complete path and the mfd binding is added in a later patch only in this version of the series: > ... For additional information, see > Documentation/devicetree/bindings/mfd/maxim,max77759.yaml. the error goes away if a relative path is used instead: > ... For additional information, see > ../mfd/maxim,max77759.yaml. I'd like to keep the reference to the mfd binding, and keep refcheckdocs working as intended (i.e. keep using the full path), so I'll split the gpio binding patch into two, the first one without the path and a 2nd one to add the full mfd binding path, to be applied after the mfd binding. Same for the similar nvmem binding. Unless there is a different preference? Cheers, Andre'
On Thu, Feb 27, 2025 at 11:19:55AM +0000, André Draszik wrote: > On Wed, 2025-02-26 at 14:30 -0600, Rob Herring (Arm) wrote: > > > > On Wed, 26 Feb 2025 17:51:20 +0000, André Draszik wrote: > > > The Maxim MAX77759 is a companion PMIC for USB Type-C applications and > > > includes Battery Charger, Fuel Gauge, temperature sensors, USB Type-C > > > Port Controller (TCPC), NVMEM, and a GPIO expander. > > > > > > This describes its GPIO module. > > > > > > Signed-off-by: André Draszik <andre.draszik@linaro.org> > > > > > > --- > > > v2: > > > * drop 'interrupts' property and sort properties alphabetically > > > --- > > > .../bindings/gpio/maxim,max77759-gpio.yaml | 44 ++++++++++++++++++++++ > > > MAINTAINERS | 6 +++ > > > 2 files changed, 50 insertions(+) > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > > > > > doc reference errors (make refcheckdocs): > > Warning: Documentation/devicetree/bindings/gpio/maxim,max77759-gpio.yaml references a file that doesn't exist: > > Documentation/devicetree/bindings/mfd/maxim,max77759.yaml > > Documentation/devicetree/bindings/gpio/maxim,max77759-gpio.yaml: Documentation/devicetree/bindings/mfd/maxim,max77759.yaml > > > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250226-max77759-mfd-v2-1-a65ebe2bc0a9@linaro.org > > > > The base for the series is generally the latest rc1. A different dependency > > should be noted in *this* patch. > > > > If you already ran 'make dt_binding_check' and didn't see the above > > error(s), then make sure 'yamllint' is installed and dt-schema is up to > > date: > > 'make dt_binding_check' doesn't invoke 'make refcheckdocs', unless > I'm doing something wrong - and therefore 'make dt_binding_check' > doesn't print any warning, contrary to what seems to be implied by > the paragraph above, If I run 'make refcheckdocs', I do get the > error, too, sure enough. > > I've never come across refcheckdocs, and it wasn't on my radar. Or anyone elses until Mauro started sending out 10s of fixes every cycle for it. I think he got tired of that thankless job. > > The error is because the binding's 'description:' references the > mfd binding using the complete path and the mfd binding is added > in a later patch only in this version of the series: > > > ... For additional information, see > > Documentation/devicetree/bindings/mfd/maxim,max77759.yaml. > > the error goes away if a relative path is used instead: > > > ... For additional information, see > > ../mfd/maxim,max77759.yaml. No, just ignore the error. I believe it gets fixed with the mfd binding applied. I'm not too concerned if refcheckdocs is bisectable. Rob
On Thu, 2025-02-27 at 06:51 -0600, Rob Herring wrote: > On Thu, Feb 27, 2025 at 11:19:55AM +0000, André Draszik wrote: > > > The error is because the binding's 'description:' references the > > mfd binding using the complete path and the mfd binding is added > > in a later patch only in this version of the series: > > > > > ... For additional information, see > > > Documentation/devicetree/bindings/mfd/maxim,max77759.yaml. > > > > the error goes away if a relative path is used instead: > > > > > ... For additional information, see > > > ../mfd/maxim,max77759.yaml. > > No, just ignore the error. I believe it gets fixed with the mfd binding > applied. I'm not too concerned if refcheckdocs is bisectable. Thanks Rob, and yes, it does go away then. Cheers, Andre'
On Wed, 26 Feb 2025 17:51:20 +0000, André Draszik wrote: > The Maxim MAX77759 is a companion PMIC for USB Type-C applications and > includes Battery Charger, Fuel Gauge, temperature sensors, USB Type-C > Port Controller (TCPC), NVMEM, and a GPIO expander. > > This describes its GPIO module. > > Signed-off-by: André Draszik <andre.draszik@linaro.org> > > --- > v2: > * drop 'interrupts' property and sort properties alphabetically > --- > .../bindings/gpio/maxim,max77759-gpio.yaml | 44 ++++++++++++++++++++++ > MAINTAINERS | 6 +++ > 2 files changed, 50 insertions(+) > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/gpio/maxim,max77759-gpio.yaml b/Documentation/devicetree/bindings/gpio/maxim,max77759-gpio.yaml new file mode 100644 index 0000000000000000000000000000000000000000..55734190d5ebdbc351e1f91675dddd8a9db80cd7 --- /dev/null +++ b/Documentation/devicetree/bindings/gpio/maxim,max77759-gpio.yaml @@ -0,0 +1,44 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/gpio/maxim,max77759-gpio.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Maxim Integrated MAX77759 GPIO + +maintainers: + - André Draszik <andre.draszik@linaro.org> + +description: | + This module is part of the MAX77759 PMIC. For additional information, see + Documentation/devicetree/bindings/mfd/maxim,max77759.yaml. + + The MAX77759 is a PMIC integrating, amongst others, a GPIO controller + including interrupt support for 2 GPIO lines. + +properties: + compatible: + const: maxim,max77759-gpio + + "#gpio-cells": + const: 2 + + gpio-controller: true + + gpio-line-names: + minItems: 1 + maxItems: 2 + + "#interrupt-cells": + const: 2 + + interrupt-controller: true + +required: + - compatible + - "#gpio-cells" + - gpio-controller + - "#interrupt-cells" + - interrupt-controller + +additionalProperties: false diff --git a/MAINTAINERS b/MAINTAINERS index 86fa62154d3b23bf84ce2d53cbbdc33f3d43006e..a45d1bd64d116d14bc05a64fa3da852a41e1de7f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -14347,6 +14347,12 @@ F: Documentation/devicetree/bindings/mfd/maxim,max77714.yaml F: drivers/mfd/max77714.c F: include/linux/mfd/max77714.h +MAXIM MAX77759 PMIC MFD DRIVER +M: André Draszik <andre.draszik@linaro.org> +L: linux-kernel@vger.kernel.org +S: Maintained +F: Documentation/devicetree/bindings/*/maxim,max77759*.yaml + MAXIM MAX77802 PMIC REGULATOR DEVICE DRIVER M: Javier Martinez Canillas <javier@dowhile0.org> L: linux-kernel@vger.kernel.org
The Maxim MAX77759 is a companion PMIC for USB Type-C applications and includes Battery Charger, Fuel Gauge, temperature sensors, USB Type-C Port Controller (TCPC), NVMEM, and a GPIO expander. This describes its GPIO module. Signed-off-by: André Draszik <andre.draszik@linaro.org> --- v2: * drop 'interrupts' property and sort properties alphabetically --- .../bindings/gpio/maxim,max77759-gpio.yaml | 44 ++++++++++++++++++++++ MAINTAINERS | 6 +++ 2 files changed, 50 insertions(+)