| Message ID | E1tnfRo-0057SL-Dz@rmk-PC.armlinux.org.uk (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | net: stmmac: fix setting RE and TE inappropriately | expand |
On Thu, Feb 27, 2025 at 03:05:12PM +0000, Russell King (Oracle) wrote: > stmmac_release() calls phylink_stop() and then goes on to call > stmmac_mac_set(, false). However, phylink_stop() will call > stmmac_mac_link_down() before returning, which will do this work. > Remove this unnecessary call. > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On Thu, 27 Feb 2025 15:05:12 +0000 "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk> wrote: > stmmac_release() calls phylink_stop() and then goes on to call > stmmac_mac_set(, false). However, phylink_stop() will call > stmmac_mac_link_down() before returning, which will do this work. > Remove this unnecessary call. > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > index 9462d05c40c8..e47b702fb9f9 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > @@ -4120,9 +4120,6 @@ static int stmmac_release(struct net_device *dev) > /* Release and free the Rx/Tx resources */ > free_dma_desc_resources(priv, &priv->dma_conf); > > - /* Disable the MAC Rx/Tx */ > - stmmac_mac_set(priv, priv->ioaddr, false); > - > /* Powerdown Serdes if there is */ > if (priv->plat->serdes_powerdown) > priv->plat->serdes_powerdown(dev, priv->plat->bsp_priv); Tested-by: Furong Xu <0x1207@gmail.com>
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 9462d05c40c8..e47b702fb9f9 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -4120,9 +4120,6 @@ static int stmmac_release(struct net_device *dev) /* Release and free the Rx/Tx resources */ free_dma_desc_resources(priv, &priv->dma_conf); - /* Disable the MAC Rx/Tx */ - stmmac_mac_set(priv, priv->ioaddr, false); - /* Powerdown Serdes if there is */ if (priv->plat->serdes_powerdown) priv->plat->serdes_powerdown(dev, priv->plat->bsp_priv);
stmmac_release() calls phylink_stop() and then goes on to call stmmac_mac_set(, false). However, phylink_stop() will call stmmac_mac_link_down() before returning, which will do this work. Remove this unnecessary call. Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3 --- 1 file changed, 3 deletions(-)