| Message ID | 20250227094226.2380930-1-quic_varada@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v1] arm64: dts: qcom: ipq5424: Enable MMC | expand |
On Thu, Feb 27, 2025 at 03:12:26PM +0530, Varadarajan Narayanan wrote: > Enable MMC and relevant pinctrl entries. > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > --- > arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts b/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts > index b6e4bb3328b3..252687be9dc3 100644 > --- a/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts > +++ b/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts > @@ -69,6 +69,14 @@ &qusb_phy_1 { > status = "okay"; > }; > > +&sdhc { > + pinctrl-0 = <&sdc_default_state>; Where is it defined? > + pinctrl-names = "default"; > + supports-cqe; This property should be a part of the SoC dtsi. > + > + status = "okay"; > +}; > + > &sleep_clk { > clock-frequency = <32000>; > }; > -- > 2.34.1 >
On Thu, Feb 27, 2025 at 05:03:10PM +0200, Dmitry Baryshkov wrote: > On Thu, Feb 27, 2025 at 03:12:26PM +0530, Varadarajan Narayanan wrote: > > Enable MMC and relevant pinctrl entries. > > > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > > --- > > arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts b/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts > > index b6e4bb3328b3..252687be9dc3 100644 > > --- a/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts > > +++ b/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts > > @@ -69,6 +69,14 @@ &qusb_phy_1 { > > status = "okay"; > > }; > > > > +&sdhc { > > + pinctrl-0 = <&sdc_default_state>; > > Where is it defined? Few lines below [1] in the same dts file. > > > + pinctrl-names = "default"; > > + supports-cqe; > > This property should be a part of the SoC dtsi. Will move it. Thanks Varada 1 - https://web.git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts#n128 > > + > > + status = "okay"; > > +}; > > + > > &sleep_clk { > > clock-frequency = <32000>; > > }; > > -- > > 2.34.1 > > > > -- > With best wishes > Dmitry
On Fri, Feb 28, 2025 at 10:39:06AM +0530, Varadarajan Narayanan wrote: > On Thu, Feb 27, 2025 at 05:03:10PM +0200, Dmitry Baryshkov wrote: > > On Thu, Feb 27, 2025 at 03:12:26PM +0530, Varadarajan Narayanan wrote: > > > Enable MMC and relevant pinctrl entries. > > > > > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > > > --- > > > arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts | 8 ++++++++ > > > 1 file changed, 8 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts b/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts > > > index b6e4bb3328b3..252687be9dc3 100644 > > > --- a/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts > > > +++ b/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts > > > @@ -69,6 +69,14 @@ &qusb_phy_1 { > > > status = "okay"; > > > }; > > > > > > +&sdhc { > > > + pinctrl-0 = <&sdc_default_state>; > > > > Where is it defined? > > Few lines below [1] in the same dts file. Ack, I missed it somehow. > > > > > > + pinctrl-names = "default"; > > > + supports-cqe; > > > > This property should be a part of the SoC dtsi. > > Will move it. > > Thanks > Varada > > 1 - https://web.git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts#n128 > > > + > > > + status = "okay"; > > > +}; > > > + > > > &sleep_clk { > > > clock-frequency = <32000>; > > > }; > > > -- > > > 2.34.1 > > > > > > > -- > > With best wishes > > Dmitry
diff --git a/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts b/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts index b6e4bb3328b3..252687be9dc3 100644 --- a/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts +++ b/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts @@ -69,6 +69,14 @@ &qusb_phy_1 { status = "okay"; }; +&sdhc { + pinctrl-0 = <&sdc_default_state>; + pinctrl-names = "default"; + supports-cqe; + + status = "okay"; +}; + &sleep_clk { clock-frequency = <32000>; };
Enable MMC and relevant pinctrl entries. Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> --- arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts | 8 ++++++++ 1 file changed, 8 insertions(+)