| Message ID | 20250228150210.34404-1-jiashengjiangcool@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 39e912a959c19338855b768eaaee2917d7841f71 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v4,net-next] dpll: Add an assertion to check freq_supported_num | expand |
Fri, Feb 28, 2025 at 04:02:10PM +0100, jiashengjiangcool@gmail.com wrote: >Since the driver is broken in the case that src->freq_supported is not >NULL but src->freq_supported_num is 0, add an assertion for it. > >Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com> Reviewed-by: Jiri Pirko <jiri@nvidia.com>
On 28/02/2025 15:02, Jiasheng Jiang wrote: > Since the driver is broken in the case that src->freq_supported is not > NULL but src->freq_supported_num is 0, add an assertion for it. > > Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com> Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
>From: Jiasheng Jiang <jiashengjiangcool@gmail.com> >Sent: Friday, February 28, 2025 4:02 PM > >Since the driver is broken in the case that src->freq_supported is not >NULL but src->freq_supported_num is 0, add an assertion for it. > >Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com> LGTM, thanks! Reviewed-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com> [..]
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Fri, 28 Feb 2025 15:02:10 +0000 you wrote: > Since the driver is broken in the case that src->freq_supported is not > NULL but src->freq_supported_num is 0, add an assertion for it. > > Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com> > --- > Changelog: > > [...] Here is the summary with links: - [v4,net-next] dpll: Add an assertion to check freq_supported_num https://git.kernel.org/netdev/net-next/c/39e912a959c1 You are awesome, thank you!
diff --git a/drivers/dpll/dpll_core.c b/drivers/dpll/dpll_core.c index 32019dc33cca..940c26b9dd53 100644 --- a/drivers/dpll/dpll_core.c +++ b/drivers/dpll/dpll_core.c @@ -443,8 +443,11 @@ static void dpll_pin_prop_free(struct dpll_pin_properties *prop) static int dpll_pin_prop_dup(const struct dpll_pin_properties *src, struct dpll_pin_properties *dst) { + if (WARN_ON(src->freq_supported && !src->freq_supported_num)) + return -EINVAL; + memcpy(dst, src, sizeof(*dst)); - if (src->freq_supported && src->freq_supported_num) { + if (src->freq_supported) { size_t freq_size = src->freq_supported_num * sizeof(*src->freq_supported); dst->freq_supported = kmemdup(src->freq_supported,
Since the driver is broken in the case that src->freq_supported is not NULL but src->freq_supported_num is 0, add an assertion for it. Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com> --- Changelog: v3 -> v4: 1. Add return after WARN_ON(). v2 -> v3: 1. Add "net-next" to the subject. 2. Remove the "Fixes" tag and "Cc: stable". 3. Replace BUG_ON with WARN_ON. v1 -> v2: 1. Replace the check with an assertion. --- drivers/dpll/dpll_core.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)