mbox series

[V4,0/4] Bluetooth: btusb: Fix regression in the initialization of fake Bluetooth controllers

Message ID 20250301062301.18029-1-nishiyama.pedro@gmail.com (mailing list archive)
Headers show
Series Bluetooth: btusb: Fix regression in the initialization of fake Bluetooth controllers | expand

Message

Pedro Nishiyama March 1, 2025, 6:22 a.m. UTC
These fake controllers cannot be initialized because they return a smaller 
report than expected for READ_VOICE_SETTING and READ_PAGE_SCAN_TYPE.

This affects fake controllers reusing the 0A12:0001 VID/PID.

Fixes: c8992cffbe74 ("Bluetooth: hci_event: Use of a function table to handle Command Complete")
Signed-off-by: Pedro Nishiyama <nishiyama.pedro@gmail.com>
---
Changes in v4:
- Check commands for READ_VOICE_SETTING.
- Disable SCO support if READ_VOICE_SETTING is unsupported/broken. 

Changes in v3:
- Correct the fixes commit. 

Changes in v2:
- Separate the driver changes from the quirks changes.

---
Pedro Nishiyama (4):
  Bluetooth: Add quirk for broken READ_VOICE_SETTING
  Bluetooth: Add quirk for broken READ_PAGE_SCAN_TYPE
  Bluetooth: Disable SCO support if READ_VOICE_SETTING is
    unsupported/broken
  Bluetooth: btusb: Fix regression in the initialization of fake
    Bluetooth controllers

 drivers/bluetooth/btusb.c        |  2 ++
 include/net/bluetooth/hci.h      | 16 ++++++++++++++++
 include/net/bluetooth/hci_core.h |  4 ++++
 net/bluetooth/hci_event.c        |  4 ++++
 net/bluetooth/hci_sync.c         |  6 +++++-
 5 files changed, 31 insertions(+), 1 deletion(-)

Comments

patchwork-bot+bluetooth@kernel.org March 4, 2025, 3 p.m. UTC | #1
Hello:

This series was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Sat,  1 Mar 2025 03:22:57 -0300 you wrote:
> These fake controllers cannot be initialized because they return a smaller
> report than expected for READ_VOICE_SETTING and READ_PAGE_SCAN_TYPE.
> 
> This affects fake controllers reusing the 0A12:0001 VID/PID.
> 
> Fixes: c8992cffbe74 ("Bluetooth: hci_event: Use of a function table to handle Command Complete")
> Signed-off-by: Pedro Nishiyama <nishiyama.pedro@gmail.com>
> 
> [...]

Here is the summary with links:
  - [V4,1/4] Bluetooth: Add quirk for broken READ_VOICE_SETTING
    https://git.kernel.org/bluetooth/bluetooth-next/c/173b1b3e9d6c
  - [V4,2/4] Bluetooth: Add quirk for broken READ_PAGE_SCAN_TYPE
    https://git.kernel.org/bluetooth/bluetooth-next/c/700ef3e1674a
  - [V4,3/4] Bluetooth: Disable SCO support if READ_VOICE_SETTING is unsupported/broken
    https://git.kernel.org/bluetooth/bluetooth-next/c/d8cba796e61f
  - [V4,4/4] Bluetooth: btusb: Fix regression in the initialization of fake Bluetooth controllers
    https://git.kernel.org/bluetooth/bluetooth-next/c/c2fe96fc96f7

You are awesome, thank you!