diff mbox series

[f2fs-dev] f2fs: set highest IO priority for checkpoint thread

Message ID 20250303221730.1284822-1-jaegeuk@kernel.org (mailing list archive)
State Accepted
Commit 8a2d9f00d502e6ef68c6d52f0863856040ddd2db
Headers show
Series [f2fs-dev] f2fs: set highest IO priority for checkpoint thread | expand

Commit Message

Jaegeuk Kim March 3, 2025, 10:17 p.m. UTC
The checkpoint is the top priority thread which can stop all the filesystem
operations. Let's make it RT priority.

Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
 fs/f2fs/checkpoint.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Daeho Jeong March 4, 2025, 6:23 p.m. UTC | #1
On Mon, Mar 3, 2025 at 2:19 PM Jaegeuk Kim via Linux-f2fs-devel
<linux-f2fs-devel@lists.sourceforge.net> wrote:
>
> The checkpoint is the top priority thread which can stop all the filesystem
> operations. Let's make it RT priority.
>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
>  fs/f2fs/checkpoint.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
> index bd890738b94d..8dbb815a35c0 100644
> --- a/fs/f2fs/checkpoint.c
> +++ b/fs/f2fs/checkpoint.c
> @@ -21,7 +21,7 @@
>  #include "iostat.h"
>  #include <trace/events/f2fs.h>
>
> -#define DEFAULT_CHECKPOINT_IOPRIO (IOPRIO_PRIO_VALUE(IOPRIO_CLASS_BE, 3))
> +#define DEFAULT_CHECKPOINT_IOPRIO (IOPRIO_PRIO_VALUE(IOPRIO_CLASS_RT, 3))
>
>  static struct kmem_cache *ino_entry_slab;
>  struct kmem_cache *f2fs_inode_entry_slab;
> --
> 2.48.1.711.g2feabab25a-goog
>

Reviewed-by: Daeho Jeong <daehojeong@google.com>

>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Chao Yu March 5, 2025, 1:28 a.m. UTC | #2
On 3/4/25 06:17, Jaegeuk Kim via Linux-f2fs-devel wrote:
> The checkpoint is the top priority thread which can stop all the filesystem
> operations. Let's make it RT priority.
> 
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,
patchwork-bot+f2fs--- via Linux-f2fs-devel March 5, 2025, 2:50 p.m. UTC | #3
Hello:

This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <jaegeuk@kernel.org>:

On Mon,  3 Mar 2025 22:17:30 +0000 you wrote:
> The checkpoint is the top priority thread which can stop all the filesystem
> operations. Let's make it RT priority.
> 
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
>  fs/f2fs/checkpoint.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - [f2fs-dev] f2fs: set highest IO priority for checkpoint thread
    https://git.kernel.org/jaegeuk/f2fs/c/8a2d9f00d502

You are awesome, thank you!
diff mbox series

Patch

diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
index bd890738b94d..8dbb815a35c0 100644
--- a/fs/f2fs/checkpoint.c
+++ b/fs/f2fs/checkpoint.c
@@ -21,7 +21,7 @@ 
 #include "iostat.h"
 #include <trace/events/f2fs.h>
 
-#define DEFAULT_CHECKPOINT_IOPRIO (IOPRIO_PRIO_VALUE(IOPRIO_CLASS_BE, 3))
+#define DEFAULT_CHECKPOINT_IOPRIO (IOPRIO_PRIO_VALUE(IOPRIO_CLASS_RT, 3))
 
 static struct kmem_cache *ino_entry_slab;
 struct kmem_cache *f2fs_inode_entry_slab;