| Message ID | 20250304-b4-linux-media-comitters-sc8280xp-venus-v1-0-279c7ea55493@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Reup: SM8350 and SC8280XP venus support | expand |
On 3/4/2025 6:37 PM, Bryan O'Donoghue wrote: > This series is a re-up of Konrad's original venus series for sc8280xp and > sm8350.Why this is enabled on venus driver ? Why not iris driver ? This needs an explanation on was this even tried to bring up on iris driver. How different is this from sm8250 which is already enabled on iris driver ? > Link: https://lore.kernel.org/all/20230731-topic-8280_venus-v1-0-8c8bbe1983a5@linaro.org/ > > The main obstacle to merging that series at the time was the longstanding > but invalid usage of "video-encoder" and "video-decoder" which is a > driver level configuration option not a description of hardware. > > Following on from that discussion a backwards compatible means of > statically selecting transcoder mode was upstreamed > > commit: 687bfbba5a1c ("media: venus: Add support for static video encoder/decoder declarations") > > Reworking this series from Konrad to incorporate this simple change > > - Removing dts dependencies/declarations on the offending compat strings > - Inclusion of necessary static configuration in the 8350/8280xp driver > config > - A small update to interconnect tags which Konrad pointed out on IRC to me > - Fixed author and SOB on first patch to match > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > Konrad Dybcio (8): > media: dt-bindings: Document SC8280XP/SM8350 Venus > media: venus: core: Remove trailing commas from of match entries > media: venus: hfi_venus: Support only updating certain bits with presets > media: platform: venus: Add optional LLCC path > media: venus: core: Add SM8350 resource struct > media: venus: core: Add SC8280XP resource struct > arm64: dts: qcom: sc8280xp: Add Venus > arm64: dts: qcom: sc8280xp-x13s: Enable Venus > > .../bindings/media/qcom,sm8350-venus.yaml | 119 ++++++++++++++++++++ > .../dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 5 + > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 82 ++++++++++++++ > drivers/media/platform/qcom/venus/core.c | 125 +++++++++++++++++++-- > drivers/media/platform/qcom/venus/core.h | 4 + > drivers/media/platform/qcom/venus/hfi_venus.c | 15 ++- > drivers/media/platform/qcom/venus/pm_helpers.c | 3 + > 7 files changed, 341 insertions(+), 12 deletions(-) > --- > base-commit: d98e9213a768a3cc3a99f5e1abe09ad3baff2104 > change-id: 20250301-b4-linux-media-comitters-sc8280xp-venus-e2cad579b4f0 > > Best regards, Regards, Vikash
On 05/03/2025 03:19, Vikash Garodia wrote: >> This series is a re-up of Konrad's original venus series for sc8280xp and >> sm8350.Why this is enabled on venus driver ? Why not iris driver ? This needs an > explanation on was this even tried to bring up on iris driver. > > How different is this from sm8250 which is already enabled on iris driver ? Ah let me parse the previous feedback, I don't have the full context of this series in my head yet. thx --- bod
This series is a re-up of Konrad's original venus series for sc8280xp and sm8350. Link: https://lore.kernel.org/all/20230731-topic-8280_venus-v1-0-8c8bbe1983a5@linaro.org/ The main obstacle to merging that series at the time was the longstanding but invalid usage of "video-encoder" and "video-decoder" which is a driver level configuration option not a description of hardware. Following on from that discussion a backwards compatible means of statically selecting transcoder mode was upstreamed commit: 687bfbba5a1c ("media: venus: Add support for static video encoder/decoder declarations") Reworking this series from Konrad to incorporate this simple change - Removing dts dependencies/declarations on the offending compat strings - Inclusion of necessary static configuration in the 8350/8280xp driver config - A small update to interconnect tags which Konrad pointed out on IRC to me - Fixed author and SOB on first patch to match Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- Konrad Dybcio (8): media: dt-bindings: Document SC8280XP/SM8350 Venus media: venus: core: Remove trailing commas from of match entries media: venus: hfi_venus: Support only updating certain bits with presets media: platform: venus: Add optional LLCC path media: venus: core: Add SM8350 resource struct media: venus: core: Add SC8280XP resource struct arm64: dts: qcom: sc8280xp: Add Venus arm64: dts: qcom: sc8280xp-x13s: Enable Venus .../bindings/media/qcom,sm8350-venus.yaml | 119 ++++++++++++++++++++ .../dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 5 + arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 82 ++++++++++++++ drivers/media/platform/qcom/venus/core.c | 125 +++++++++++++++++++-- drivers/media/platform/qcom/venus/core.h | 4 + drivers/media/platform/qcom/venus/hfi_venus.c | 15 ++- drivers/media/platform/qcom/venus/pm_helpers.c | 3 + 7 files changed, 341 insertions(+), 12 deletions(-) --- base-commit: d98e9213a768a3cc3a99f5e1abe09ad3baff2104 change-id: 20250301-b4-linux-media-comitters-sc8280xp-venus-e2cad579b4f0 Best regards,