| Message ID | 20250228201533.23836-12-ericwouds@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | bridge-fastpath and related improvements | expand |
On 2/28/25 22:15, Eric Woudstra wrote: > In case of using mediatek wireless, in nft_dev_fill_forward_path(), the > forward path is filled, ending with mediatek wlan1. > > Because DEV_PATH_MTK_WDMA is unknown inside nft_dev_path_info() it returns > with info.indev = NULL. Then nft_dev_forward_path() returns without > setting the direct transmit parameters. > > This results in a neighbor transmit, and direct transmit not possible. > But we want to use it for flow between bridged interfaces. > > So this patch adds DEV_PATH_MTK_WDMA to nft_dev_path_info() and makes > direct transmission possible. > > Signed-off-by: Eric Woudstra <ericwouds@gmail.com> > --- > net/netfilter/nft_flow_offload.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/net/netfilter/nft_flow_offload.c b/net/netfilter/nft_flow_offload.c > index 323c531c7046..b9e6d9e6df66 100644 > --- a/net/netfilter/nft_flow_offload.c > +++ b/net/netfilter/nft_flow_offload.c > @@ -105,6 +105,7 @@ static void nft_dev_path_info(const struct net_device_path_stack *stack, > switch (path->type) { > case DEV_PATH_ETHERNET: > case DEV_PATH_DSA: > + case DEV_PATH_MTK_WDMA: > case DEV_PATH_VLAN: > case DEV_PATH_PPPOE: > info->indev = path->dev; > @@ -117,6 +118,10 @@ static void nft_dev_path_info(const struct net_device_path_stack *stack, > i = stack->num_paths; > break; > } > + if (path->type == DEV_PATH_MTK_WDMA) { > + i = stack->num_paths; > + break; > + } > > /* DEV_PATH_VLAN and DEV_PATH_PPPOE */ > if (info->num_encaps >= NF_FLOW_TABLE_ENCAP_MAX) { Reviewed-by: Nikolay Aleksandrov <razor@blackwall.org>
diff --git a/net/netfilter/nft_flow_offload.c b/net/netfilter/nft_flow_offload.c index 323c531c7046..b9e6d9e6df66 100644 --- a/net/netfilter/nft_flow_offload.c +++ b/net/netfilter/nft_flow_offload.c @@ -105,6 +105,7 @@ static void nft_dev_path_info(const struct net_device_path_stack *stack, switch (path->type) { case DEV_PATH_ETHERNET: case DEV_PATH_DSA: + case DEV_PATH_MTK_WDMA: case DEV_PATH_VLAN: case DEV_PATH_PPPOE: info->indev = path->dev; @@ -117,6 +118,10 @@ static void nft_dev_path_info(const struct net_device_path_stack *stack, i = stack->num_paths; break; } + if (path->type == DEV_PATH_MTK_WDMA) { + i = stack->num_paths; + break; + } /* DEV_PATH_VLAN and DEV_PATH_PPPOE */ if (info->num_encaps >= NF_FLOW_TABLE_ENCAP_MAX) {
In case of using mediatek wireless, in nft_dev_fill_forward_path(), the forward path is filled, ending with mediatek wlan1. Because DEV_PATH_MTK_WDMA is unknown inside nft_dev_path_info() it returns with info.indev = NULL. Then nft_dev_forward_path() returns without setting the direct transmit parameters. This results in a neighbor transmit, and direct transmit not possible. But we want to use it for flow between bridged interfaces. So this patch adds DEV_PATH_MTK_WDMA to nft_dev_path_info() and makes direct transmission possible. Signed-off-by: Eric Woudstra <ericwouds@gmail.com> --- net/netfilter/nft_flow_offload.c | 5 +++++ 1 file changed, 5 insertions(+)