| Message ID | 20250305085646.26472-1-jgross@suse.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | xen/public: remove some unused defines from xs_wire.h | expand |
On 05.03.2025 09:56, Juergen Gross wrote: > xs_wire.h contains some defines XS_WRITE_* which seem to be leftovers > from some decades ago. They haven't been used in the Xen tree since at > least Xen 2.0 and they make no sense anyway. > > Remove them, as they seem not to be related to any Xen interface we > have today. How sure are you/we that there are no out-of-tree uses of them? They aren't in e.g. a __XEN_TOOLS__ protected region after all. (I don't mind their removal, but in public headers I think we need to be double careful.) Jan
On 05.03.25 10:14, Jan Beulich wrote: > On 05.03.2025 09:56, Juergen Gross wrote: >> xs_wire.h contains some defines XS_WRITE_* which seem to be leftovers >> from some decades ago. They haven't been used in the Xen tree since at >> least Xen 2.0 and they make no sense anyway. >> >> Remove them, as they seem not to be related to any Xen interface we >> have today. > > How sure are you/we that there are no out-of-tree uses of them? They > aren't in e.g. a __XEN_TOOLS__ protected region after all. (I don't > mind their removal, but in public headers I think we need to be > double careful.) The reasoning is all in the commit message: those macros haven't made any sense since ages. In case someone is using them, the usage is either wrong or not related to Xen. I have checked Mini-OS, Qemu and Linux kernel for uses and didn't find any. Juergen
On 05.03.2025 10:27, Jürgen Groß wrote: > On 05.03.25 10:14, Jan Beulich wrote: >> On 05.03.2025 09:56, Juergen Gross wrote: >>> xs_wire.h contains some defines XS_WRITE_* which seem to be leftovers >>> from some decades ago. They haven't been used in the Xen tree since at >>> least Xen 2.0 and they make no sense anyway. >>> >>> Remove them, as they seem not to be related to any Xen interface we >>> have today. >> >> How sure are you/we that there are no out-of-tree uses of them? They >> aren't in e.g. a __XEN_TOOLS__ protected region after all. (I don't >> mind their removal, but in public headers I think we need to be >> double careful.) > > The reasoning is all in the commit message: those macros haven't made > any sense since ages. Well, the reason I asked is that I consider "makes sense" as pretty subjective. > In case someone is using them, the usage is either wrong or not related > to Xen. I have checked Mini-OS, Qemu and Linux kernel for uses and > didn't find any. Okay, probably fair enough then: Acked-by: Jan Beulich <jbeulich@suse.com> Jan
diff --git a/xen/include/public/io/xs_wire.h b/xen/include/public/io/xs_wire.h index 04e6849feb..0d9f49ac89 100644 --- a/xen/include/public/io/xs_wire.h +++ b/xen/include/public/io/xs_wire.h @@ -41,10 +41,6 @@ enum xsd_sockmsg_type XS_INVALID = 0xffff /* Guaranteed to remain an invalid type */ }; -#define XS_WRITE_NONE "NONE" -#define XS_WRITE_CREATE "CREATE" -#define XS_WRITE_CREATE_EXCL "CREATE|EXCL" - /* We hand errors as strings, for portability. */ struct xsd_errors {
xs_wire.h contains some defines XS_WRITE_* which seem to be leftovers from some decades ago. They haven't been used in the Xen tree since at least Xen 2.0 and they make no sense anyway. Remove them, as they seem not to be related to any Xen interface we have today. Signed-off-by: Juergen Gross <jgross@suse.com> --- xen/include/public/io/xs_wire.h | 4 ---- 1 file changed, 4 deletions(-)