diff mbox series

[XEN,v2,2/3] xen/rt: address violation of MISRA C Rule 8.2

Message ID e3c6457e50d61daa05fd9c3a7c71b06d912216a0.1740476096.git.nicola.vetrini@bugseng.com (mailing list archive)
State New
Headers show
Series Move Xen ECLAIR configuration to analyze.yaml | expand

Commit Message

Nicola Vetrini Feb. 25, 2025, 9:38 a.m. UTC 
Rule 8.2 states: "Function types shall be in prototype form with
named parameters".

The parameter name is missing from the function pointer type
that constitutes the first parameter.

No functional change.

Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Reviewed-by: Juergen Gross <jgross@suse.com>
---
Changes in v2:
- renamed function parameter name to "elem"
- changed prefix to xen/rt since only that scheduler is touched
---
 xen/common/sched/rt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jan Beulich March 5, 2025, 2:17 p.m. UTC | #1 
On 25.02.2025 10:38, Nicola Vetrini wrote:
> Rule 8.2 states: "Function types shall be in prototype form with
> named parameters".
> 
> The parameter name is missing from the function pointer type
> that constitutes the first parameter.
> 
> No functional change.
> 
> Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> Reviewed-by: Juergen Gross <jgross@suse.com>
> ---
> Changes in v2:
> - renamed function parameter name to "elem"
> - changed prefix to xen/rt since only that scheduler is touched

Looks like you committed v1 of this, and without a maintainer ack?

Jan
Stefano Stabellini March 5, 2025, 11:24 p.m. UTC | #2 
On Wed, 5 Mar 2025, Jan Beulich wrote:
> On 25.02.2025 10:38, Nicola Vetrini wrote:
> > Rule 8.2 states: "Function types shall be in prototype form with
> > named parameters".
> > 
> > The parameter name is missing from the function pointer type
> > that constitutes the first parameter.
> > 
> > No functional change.
> > 
> > Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com>
> > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> > Reviewed-by: Juergen Gross <jgross@suse.com>
> > ---
> > Changes in v2:
> > - renamed function parameter name to "elem"
> > - changed prefix to xen/rt since only that scheduler is touched
> 
> Looks like you committed v1 of this, and without a maintainer ack?

Hi Jan, I took Juergen's comment and his maintainer ack, making the
change on commit: https://marc.info/?l=xen-devel&m=173978187314898
Nicola Vetrini March 6, 2025, 7:43 a.m. UTC | #3 
On 2025-03-06 00:24, Stefano Stabellini wrote:
> On Wed, 5 Mar 2025, Jan Beulich wrote:
>> On 25.02.2025 10:38, Nicola Vetrini wrote:
>> > Rule 8.2 states: "Function types shall be in prototype form with
>> > named parameters".
>> >
>> > The parameter name is missing from the function pointer type
>> > that constitutes the first parameter.
>> >
>> > No functional change.
>> >
>> > Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com>
>> > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
>> > Reviewed-by: Juergen Gross <jgross@suse.com>
>> > ---
>> > Changes in v2:
>> > - renamed function parameter name to "elem"
>> > - changed prefix to xen/rt since only that scheduler is touched
>> 
>> Looks like you committed v1 of this, and without a maintainer ack?
> 
> Hi Jan, I took Juergen's comment and his maintainer ack, making the
> change on commit: https://marc.info/?l=xen-devel&m=173978187314898

I think Jan's comment is due to the subject prefix of the commit being 
xen/sched, rather than xen/rt, as I touched only the rt scheduler, but 
that's too late to change.
Jan Beulich March 6, 2025, 8:18 a.m. UTC | #4 
On 06.03.2025 00:24, Stefano Stabellini wrote:
> On Wed, 5 Mar 2025, Jan Beulich wrote:
>> On 25.02.2025 10:38, Nicola Vetrini wrote:
>>> Rule 8.2 states: "Function types shall be in prototype form with
>>> named parameters".
>>>
>>> The parameter name is missing from the function pointer type
>>> that constitutes the first parameter.
>>>
>>> No functional change.
>>>
>>> Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com>
>>> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
>>> Reviewed-by: Juergen Gross <jgross@suse.com>
>>> ---
>>> Changes in v2:
>>> - renamed function parameter name to "elem"
>>> - changed prefix to xen/rt since only that scheduler is touched
>>
>> Looks like you committed v1 of this, and without a maintainer ack?
> 
> Hi Jan, I took Juergen's comment and his maintainer ack, making the
> change on commit: https://marc.info/?l=xen-devel&m=173978187314898

Except that aiui Jürgen isn't formally a maintainer of the RT scheduler.
Nor did you change the patch subject (as requested by me, and as reflected
in v2) to properly express that it's an RT scheduler change (only). (Less
formally, with the lack of response by the actual maintainers, taking
Jürgen's R-b to fill in for the missing maintainer ack is likely okay, but
probably should have been mentioned explicitly. Recurring lack of response
by maintainers ought to perhaps result in reconsideration of their
maintainership.)

Jan
diff mbox series

Patch

diff --git a/xen/common/sched/rt.c b/xen/common/sched/rt.c
index f368e0fdd5a5..7b1f64a779ea 100644
--- a/xen/common/sched/rt.c
+++ b/xen/common/sched/rt.c
@@ -500,7 +500,7 @@  deadline_queue_remove(struct list_head *queue, struct list_head *elem)
 }
 
 static inline bool
-deadline_queue_insert(struct rt_unit * (*qelem)(struct list_head *),
+deadline_queue_insert(struct rt_unit * (*qelem)(struct list_head *elem),
                       struct rt_unit *svc, struct list_head *elem,
                       struct list_head *queue)
 {