| Message ID | 20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | a few rtc driver cleanups | expand |
On Tue, 04 Mar 2025 17:05:28 +0000, André Draszik wrote: > While looking at RTC, I noticed that various drivers are keeping > pointers to data that they're not using themselves throughout their > lifetime. > > So I took the liberty to drop these pointers and this series is the > result. > > [...] Applied, thanks! [01/16] rtc: max77686: drop needless struct max77686_rtc_info::rtc member https://git.kernel.org/abelloni/c/6c9405fd2581 [02/16] rtc: s5m: drop needless struct s5m_rtc_info::i2c member https://git.kernel.org/abelloni/c/afe5f9f94d11 [03/16] rtc: aspeed: drop needless struct aspeed_rtc::rtc_dev member https://git.kernel.org/abelloni/c/d19111dff9c2 [04/16] rtc: ds2404: drop needless struct ds2404::rtc member https://git.kernel.org/abelloni/c/1b625aaf335a [05/16] rtc: ep93xx: drop needless struct ep93xx_rtc::rtc member https://git.kernel.org/abelloni/c/5d0ad519f503 [06/16] rtc: ftrtc010: drop needless struct ftrtc010_rtc::rtc_dev member https://git.kernel.org/abelloni/c/a55d44807b63 [07/16] rtc: m48t86: drop needless struct m48t86_rtc_info::rtc member https://git.kernel.org/abelloni/c/013df5bdf8b4 [08/16] rtc: meson: drop needless struct meson_rtc::rtc member https://git.kernel.org/abelloni/c/a0470062748f [09/16] rtc: meson-vrtc: drop needless struct meson_vrtc_data::rtc member https://git.kernel.org/abelloni/c/38c7aaeab8b8 [10/16] rtc: pl030: drop needless struct pl030_rtc::rtc member https://git.kernel.org/abelloni/c/3d5d0fe1cb82 [11/16] rtc: rx8581: drop needless struct rx8581 https://git.kernel.org/abelloni/c/3b87c6872aed [12/16] rtc: s35390a: drop needless struct s35390a::rtc member https://git.kernel.org/abelloni/c/cd2a7052482e [13/16] rtc: sd2405al: drop needless struct sd2405al::rtc member https://git.kernel.org/abelloni/c/d94bc2bbf8d9 [14/16] rtc: sd3078: drop needless struct sd3078 https://git.kernel.org/abelloni/c/6158c6b82444 [15/16] rtc: max77686: use dev_err_probe() where appropriate https://git.kernel.org/abelloni/c/e6403ae59ce1 [16/16] rtc: s5m: convert to dev_err_probe() where appropriate https://git.kernel.org/abelloni/c/0c57c2e72c5d Best regards,
Hi, While looking at RTC, I noticed that various drivers are keeping pointers to data that they're not using themselves throughout their lifetime. So I took the liberty to drop these pointers and this series is the result. The last two patches also convert two drivers to using dev_err_probe(), as I looked slightly closer into those two. They don't exactly fit the general subject of removal of unneeded pointers, but I wanted to share them anyway, since they're ready. Drivers other than s5m were compile-tested only. Cheers, Andre' Signed-off-by: André Draszik <andre.draszik@linaro.org> --- Changes in v2: - s5m: fix arguments to devm_i2c_new_dummy_device() - merge two rx8581 & sd3078 patches into one each (Alexandre) - Link to v1: https://lore.kernel.org/r/20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org --- André Draszik (16): rtc: max77686: drop needless struct max77686_rtc_info::rtc member rtc: s5m: drop needless struct s5m_rtc_info::i2c member rtc: aspeed: drop needless struct aspeed_rtc::rtc_dev member rtc: ds2404: drop needless struct ds2404::rtc member rtc: ep93xx: drop needless struct ep93xx_rtc::rtc member rtc: ftrtc010: drop needless struct ftrtc010_rtc::rtc_dev member rtc: m48t86: drop needless struct m48t86_rtc_info::rtc member rtc: meson: drop needless struct meson_rtc::rtc member rtc: meson-vrtc: drop needless struct meson_vrtc_data::rtc member rtc: pl030: drop needless struct pl030_rtc::rtc member rtc: rx8581: drop needless struct rx8581 rtc: s35390a: drop needless struct s35390a::rtc member rtc: sd2405al: drop needless struct sd2405al::rtc member rtc: sd3078: drop needless struct sd3078 rtc: max77686: use dev_err_probe() where appropriate rtc: s5m: convert to dev_err_probe() where appropriate drivers/rtc/rtc-aspeed.c | 16 ++++----- drivers/rtc/rtc-ds2404.c | 14 ++++---- drivers/rtc/rtc-ep93xx.c | 16 ++++----- drivers/rtc/rtc-ftrtc010.c | 17 +++++---- drivers/rtc/rtc-m48t86.c | 14 ++++---- drivers/rtc/rtc-max77686.c | 37 +++++++++---------- drivers/rtc/rtc-meson-vrtc.c | 12 +++---- drivers/rtc/rtc-meson.c | 16 ++++----- drivers/rtc/rtc-pl030.c | 14 ++++---- drivers/rtc/rtc-rx8581.c | 85 +++++++++++++++++++------------------------- drivers/rtc/rtc-s35390a.c | 22 ++++++------ drivers/rtc/rtc-s5m.c | 58 +++++++++++++----------------- drivers/rtc/rtc-sd2405al.c | 16 ++++----- drivers/rtc/rtc-sd3078.c | 71 +++++++++++++++--------------------- 14 files changed, 183 insertions(+), 225 deletions(-) --- base-commit: 0226d0ce98a477937ed295fb7df4cc30b46fc304 change-id: 20250228-rtc-cleanups-12c0b5123ea4 Best regards,