diff mbox series

EDAC: fix dev_set_name() format string

Message ID 20250304143603.995820-1-arnd@kernel.org (mailing list archive)
State New
Headers show
Series EDAC: fix dev_set_name() format string | expand

Commit Message

Arnd Bergmann March 4, 2025, 2:35 p.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

Passing a variable string as the format to dev_set_name() causes a W=1 warning:

drivers/edac/edac_device.c:736:9: error: format not a string literal and no format arguments [-Werror=format-security]
  736 |         ret = dev_set_name(&ctx->dev, name);
      |         ^~~

Use a literal "%s" instead so the name can be the argument.

Fixes: db99ea5f2c03 ("EDAC: Add support for EDAC device features control")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/edac/edac_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Borislav Petkov March 5, 2025, 10:51 p.m. UTC | #1 
On Tue, Mar 04, 2025 at 03:35:58PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Passing a variable string as the format to dev_set_name() causes a W=1 warning:
> 
> drivers/edac/edac_device.c:736:9: error: format not a string literal and no format arguments [-Werror=format-security]
>   736 |         ret = dev_set_name(&ctx->dev, name);
>       |         ^~~
> 
> Use a literal "%s" instead so the name can be the argument.
> 
> Fixes: db99ea5f2c03 ("EDAC: Add support for EDAC device features control")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/edac/edac_device.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.
diff mbox series

Patch

diff --git a/drivers/edac/edac_device.c b/drivers/edac/edac_device.c
index 16611515ab34..0734909b08a4 100644
--- a/drivers/edac/edac_device.c
+++ b/drivers/edac/edac_device.c
@@ -733,7 +733,7 @@  int edac_dev_register(struct device *parent, char *name,
 	ctx->private = private;
 	dev_set_drvdata(&ctx->dev, ctx);
 
-	ret = dev_set_name(&ctx->dev, name);
+	ret = dev_set_name(&ctx->dev, "%s", name);
 	if (ret)
 		goto data_mem_free;