| Message ID | 20250305104335.3629945-6-quic_dikshita@quicinc.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | Add support for HEVC and VP9 codecs in decoder | expand |
On Wed, Mar 05, 2025 at 04:13:28PM +0530, Dikshita Agarwal wrote: > Firmware might hold the DPB buffers for reference in case of sequence > change, so skip destroying buffers for which QUEUED flag is not removed. > > Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com> Please add FIxes tag and move closer to the top. > --- > drivers/media/platform/qcom/iris/iris_buffer.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/media/platform/qcom/iris/iris_buffer.c b/drivers/media/platform/qcom/iris/iris_buffer.c > index 8c9d5b7fe75c..305b630ca269 100644 > --- a/drivers/media/platform/qcom/iris/iris_buffer.c > +++ b/drivers/media/platform/qcom/iris/iris_buffer.c > @@ -399,6 +399,13 @@ int iris_destroy_internal_buffers(struct iris_inst *inst, u32 plane) > for (i = 0; i < len; i++) { > buffers = &inst->buffers[internal_buf_type[i]]; > list_for_each_entry_safe(buf, next, &buffers->list, list) { > + /* > + * skip destroying internal(DPB) buffer if firmware > + * did not return it. > + */ > + if (buf->attr & BUF_ATTR_QUEUED) > + continue; > + > ret = iris_destroy_internal_buffer(inst, buf); > if (ret) > return ret; > -- > 2.34.1 >
On 3/6/2025 2:14 AM, Dmitry Baryshkov wrote: > On Wed, Mar 05, 2025 at 04:13:28PM +0530, Dikshita Agarwal wrote: >> Firmware might hold the DPB buffers for reference in case of sequence >> change, so skip destroying buffers for which QUEUED flag is not removed. >> >> Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com> > > Please add FIxes tag and move closer to the top. > Noted. >> --- >> drivers/media/platform/qcom/iris/iris_buffer.c | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/drivers/media/platform/qcom/iris/iris_buffer.c b/drivers/media/platform/qcom/iris/iris_buffer.c >> index 8c9d5b7fe75c..305b630ca269 100644 >> --- a/drivers/media/platform/qcom/iris/iris_buffer.c >> +++ b/drivers/media/platform/qcom/iris/iris_buffer.c >> @@ -399,6 +399,13 @@ int iris_destroy_internal_buffers(struct iris_inst *inst, u32 plane) >> for (i = 0; i < len; i++) { >> buffers = &inst->buffers[internal_buf_type[i]]; >> list_for_each_entry_safe(buf, next, &buffers->list, list) { >> + /* >> + * skip destroying internal(DPB) buffer if firmware >> + * did not return it. >> + */ >> + if (buf->attr & BUF_ATTR_QUEUED) >> + continue; >> + >> ret = iris_destroy_internal_buffer(inst, buf); >> if (ret) >> return ret; >> -- >> 2.34.1 >> >
diff --git a/drivers/media/platform/qcom/iris/iris_buffer.c b/drivers/media/platform/qcom/iris/iris_buffer.c index 8c9d5b7fe75c..305b630ca269 100644 --- a/drivers/media/platform/qcom/iris/iris_buffer.c +++ b/drivers/media/platform/qcom/iris/iris_buffer.c @@ -399,6 +399,13 @@ int iris_destroy_internal_buffers(struct iris_inst *inst, u32 plane) for (i = 0; i < len; i++) { buffers = &inst->buffers[internal_buf_type[i]]; list_for_each_entry_safe(buf, next, &buffers->list, list) { + /* + * skip destroying internal(DPB) buffer if firmware + * did not return it. + */ + if (buf->attr & BUF_ATTR_QUEUED) + continue; + ret = iris_destroy_internal_buffer(inst, buf); if (ret) return ret;
Firmware might hold the DPB buffers for reference in case of sequence change, so skip destroying buffers for which QUEUED flag is not removed. Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com> --- drivers/media/platform/qcom/iris/iris_buffer.c | 7 +++++++ 1 file changed, 7 insertions(+)