| Message ID | 20250304052450.465445-3-xiaoyao.li@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | i386: Adjust CPUID_EXT_PDCM based on enable_pmu at realization | expand |
On Tue, Mar 04, 2025 at 12:24:50AM -0500, Xiaoyao Li wrote: > Date: Tue, 4 Mar 2025 00:24:50 -0500 > From: Xiaoyao Li <xiaoyao.li@intel.com> > Subject: [PATCH 2/2] i386/cpu: Warn about why CPUID_EXT_PDCM is not > available > X-Mailer: git-send-email 2.34.1 > > When user requests PDCM explicitly via "+pdcm" without PMU enabled, emit > a warning to inform the user. > > Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com> > --- > target/i386/cpu.c | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 2bf6495140a0..2aa2bab12100 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -7682,6 +7682,9 @@ void x86_cpu_expand_features(X86CPU *cpu, Error **errp) } if (!cpu->enable_pmu) { + mark_unavailable_features(cpu, FEAT_1_ECX, + env->user_features[FEAT_1_ECX] & CPUID_EXT_PDCM, + "This feature is not available due to PMU disabled"); env->features[FEAT_1_ECX] &= ~CPUID_EXT_PDCM; }
When user requests PDCM explicitly via "+pdcm" without PMU enabled, emit a warning to inform the user. Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com> --- target/i386/cpu.c | 3 +++ 1 file changed, 3 insertions(+)