| Message ID | 20250304075846.66563-5-louis@kragniz.eu (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/5] tools/nolibc: add support for openat(2) | expand |
On 2025-03-04 07:58:19+0000, Louis Taylor wrote: > It was mentioned that a new test_ function should be static, so go back > over existing functions and mark those static as well. Actually Willy wants these non-static for debugging purposes. I can't seem to get that into my head -.- Let's drop this one. > Signed-off-by: Louis Taylor <louis@kragniz.eu> > --- > tools/testing/selftests/nolibc/nolibc-test.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/tools/testing/selftests/nolibc/nolibc-test.c b/tools/testing/selftests/nolibc/nolibc-test.c > index 2a1629938dd6..b5464ca8d050 100644 > --- a/tools/testing/selftests/nolibc/nolibc-test.c > +++ b/tools/testing/selftests/nolibc/nolibc-test.c > @@ -807,7 +807,7 @@ static int test_dirent(void) > return 0; > } > > -int test_getpagesize(void) > +static int test_getpagesize(void) > { > int x = getpagesize(); > int c; > @@ -836,7 +836,7 @@ int test_getpagesize(void) > return !c; > } > > -int test_fork(void) > +static int test_fork(void) > { > int status; > pid_t pid; > @@ -861,7 +861,7 @@ int test_fork(void) > } > } > > -int test_stat_timestamps(void) > +static int test_stat_timestamps(void) > { > struct stat st; > > @@ -883,7 +883,7 @@ int test_stat_timestamps(void) > return 0; > } > > -int test_uname(void) > +static int test_uname(void) > { > struct utsname buf; > char osrelease[sizeof(buf.release)]; > @@ -922,7 +922,7 @@ int test_uname(void) > return 0; > } > > -int test_mmap_munmap(void) > +static int test_mmap_munmap(void) > { > int ret, fd, i, page_size; > void *mem; > @@ -980,7 +980,7 @@ int test_mmap_munmap(void) > return !!ret; > } > > -int test_pipe(void) > +static int test_pipe(void) > { > const char *const msg = "hello, nolibc"; > int pipefd[2]; > @@ -1001,7 +1001,7 @@ int test_pipe(void) > return !!memcmp(buf, msg, len); > } > > -int test_rlimit(void) > +static int test_rlimit(void) > { > struct rlimit rlim = { > .rlim_cur = 1 << 20, > -- > 2.45.2 >
On Thu, Mar 06, 2025 at 06:00:17PM +0100, Thomas Weißschuh wrote: > On 2025-03-04 07:58:19+0000, Louis Taylor wrote: > > It was mentioned that a new test_ function should be static, so go back > > over existing functions and mark those static as well. > > Actually Willy wants these non-static for debugging purposes. > I can't seem to get that into my head -.- > Let's drop this one. I don't remember but it was probably to be able to break into them with gdb and/or to check the disassembled code when in doubt about anything. Willy
diff --git a/tools/testing/selftests/nolibc/nolibc-test.c b/tools/testing/selftests/nolibc/nolibc-test.c index 2a1629938dd6..b5464ca8d050 100644 --- a/tools/testing/selftests/nolibc/nolibc-test.c +++ b/tools/testing/selftests/nolibc/nolibc-test.c @@ -807,7 +807,7 @@ static int test_dirent(void) return 0; } -int test_getpagesize(void) +static int test_getpagesize(void) { int x = getpagesize(); int c; @@ -836,7 +836,7 @@ int test_getpagesize(void) return !c; } -int test_fork(void) +static int test_fork(void) { int status; pid_t pid; @@ -861,7 +861,7 @@ int test_fork(void) } } -int test_stat_timestamps(void) +static int test_stat_timestamps(void) { struct stat st; @@ -883,7 +883,7 @@ int test_stat_timestamps(void) return 0; } -int test_uname(void) +static int test_uname(void) { struct utsname buf; char osrelease[sizeof(buf.release)]; @@ -922,7 +922,7 @@ int test_uname(void) return 0; } -int test_mmap_munmap(void) +static int test_mmap_munmap(void) { int ret, fd, i, page_size; void *mem; @@ -980,7 +980,7 @@ int test_mmap_munmap(void) return !!ret; } -int test_pipe(void) +static int test_pipe(void) { const char *const msg = "hello, nolibc"; int pipefd[2]; @@ -1001,7 +1001,7 @@ int test_pipe(void) return !!memcmp(buf, msg, len); } -int test_rlimit(void) +static int test_rlimit(void) { struct rlimit rlim = { .rlim_cur = 1 << 20,
It was mentioned that a new test_ function should be static, so go back over existing functions and mark those static as well. Signed-off-by: Louis Taylor <louis@kragniz.eu> --- tools/testing/selftests/nolibc/nolibc-test.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)