mbox series

[v2,0/2] Fix native cursors with vmwgfx

Message ID 20250306041222.2776379-1-zack.rusin@broadcom.com (mailing list archive)
Headers show
Series Fix native cursors with vmwgfx | expand

Message

Zack Rusin March 6, 2025, 4:11 a.m. UTC 
vmwgfx had a number of cursor issues that related both to our handling
of dumb buffers and general detection when a cursor has actually changed.
Fix those issues and bump the kernel module version to allow userspace
to recognize fixed versions of the driver.

v2: Include the fix for leaked dirty trackers in kms fb surface
cleanup code.

Zack Rusin (2):
  drm/vmwgfx: Refactor cursor handling
  drm/vmwgfx: Bump the minor version

 drivers/gpu/drm/vmwgfx/Makefile              |   2 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_bo.c           |   6 +
 drivers/gpu/drm/vmwgfx/vmwgfx_bo.h           |   2 +
 drivers/gpu/drm/vmwgfx/vmwgfx_cursor_plane.c | 844 ++++++++++++++++++
 drivers/gpu/drm/vmwgfx/vmwgfx_cursor_plane.h |  81 ++
 drivers/gpu/drm/vmwgfx/vmwgfx_drv.c          |   3 -
 drivers/gpu/drm/vmwgfx/vmwgfx_drv.h          |  12 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c      |   2 -
 drivers/gpu/drm/vmwgfx/vmwgfx_kms.c          | 851 +------------------
 drivers/gpu/drm/vmwgfx/vmwgfx_kms.h          |  49 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c          |  10 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_page_dirty.c   |  40 +
 drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c         |  10 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c         |  11 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_surface.c      |  25 +-
 15 files changed, 1031 insertions(+), 917 deletions(-)
 create mode 100644 drivers/gpu/drm/vmwgfx/vmwgfx_cursor_plane.c
 create mode 100644 drivers/gpu/drm/vmwgfx/vmwgfx_cursor_plane.h

Comments

Martin Krastev March 6, 2025, 6:33 p.m. UTC | #1 
On Thu, Mar 6, 2025 at 6:12 AM Zack Rusin <zack.rusin@broadcom.com> wrote:
>
> vmwgfx had a number of cursor issues that related both to our handling
> of dumb buffers and general detection when a cursor has actually changed.
> Fix those issues and bump the kernel module version to allow userspace
> to recognize fixed versions of the driver.
>
> v2: Include the fix for leaked dirty trackers in kms fb surface
> cleanup code.
>
> Zack Rusin (2):
>   drm/vmwgfx: Refactor cursor handling
>   drm/vmwgfx: Bump the minor version
>
>  drivers/gpu/drm/vmwgfx/Makefile              |   2 +-
>  drivers/gpu/drm/vmwgfx/vmwgfx_bo.c           |   6 +
>  drivers/gpu/drm/vmwgfx/vmwgfx_bo.h           |   2 +
>  drivers/gpu/drm/vmwgfx/vmwgfx_cursor_plane.c | 844 ++++++++++++++++++
>  drivers/gpu/drm/vmwgfx/vmwgfx_cursor_plane.h |  81 ++
>  drivers/gpu/drm/vmwgfx/vmwgfx_drv.c          |   3 -
>  drivers/gpu/drm/vmwgfx/vmwgfx_drv.h          |  12 +-
>  drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c      |   2 -
>  drivers/gpu/drm/vmwgfx/vmwgfx_kms.c          | 851 +------------------
>  drivers/gpu/drm/vmwgfx/vmwgfx_kms.h          |  49 +-
>  drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c          |  10 +-
>  drivers/gpu/drm/vmwgfx/vmwgfx_page_dirty.c   |  40 +
>  drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c         |  10 +-
>  drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c         |  11 +-
>  drivers/gpu/drm/vmwgfx/vmwgfx_surface.c      |  25 +-
>  15 files changed, 1031 insertions(+), 917 deletions(-)
>  create mode 100644 drivers/gpu/drm/vmwgfx/vmwgfx_cursor_plane.c
>  create mode 100644 drivers/gpu/drm/vmwgfx/vmwgfx_cursor_plane.h
>
> --
> 2.45.2
>

LGTM to the series.

Reviewed-by: Martin Krastev <martin.krastev@broadcom.com>

Regards,
Martin
Maaz Mombasawala March 7, 2025, 12:10 a.m. UTC | #2 
On 3/5/25 20:11, Zack Rusin wrote:
> vmwgfx had a number of cursor issues that related both to our handling
> of dumb buffers and general detection when a cursor has actually changed.
> Fix those issues and bump the kernel module version to allow userspace
> to recognize fixed versions of the driver.
> 
> v2: Include the fix for leaked dirty trackers in kms fb surface
> cleanup code.
> 
> Zack Rusin (2):
>   drm/vmwgfx: Refactor cursor handling
>   drm/vmwgfx: Bump the minor version
> 
>  drivers/gpu/drm/vmwgfx/Makefile              |   2 +-
>  drivers/gpu/drm/vmwgfx/vmwgfx_bo.c           |   6 +
>  drivers/gpu/drm/vmwgfx/vmwgfx_bo.h           |   2 +
>  drivers/gpu/drm/vmwgfx/vmwgfx_cursor_plane.c | 844 ++++++++++++++++++
>  drivers/gpu/drm/vmwgfx/vmwgfx_cursor_plane.h |  81 ++
>  drivers/gpu/drm/vmwgfx/vmwgfx_drv.c          |   3 -
>  drivers/gpu/drm/vmwgfx/vmwgfx_drv.h          |  12 +-
>  drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c      |   2 -
>  drivers/gpu/drm/vmwgfx/vmwgfx_kms.c          | 851 +------------------
>  drivers/gpu/drm/vmwgfx/vmwgfx_kms.h          |  49 +-
>  drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c          |  10 +-
>  drivers/gpu/drm/vmwgfx/vmwgfx_page_dirty.c   |  40 +
>  drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c         |  10 +-
>  drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c         |  11 +-
>  drivers/gpu/drm/vmwgfx/vmwgfx_surface.c      |  25 +-
>  15 files changed, 1031 insertions(+), 917 deletions(-)
>  create mode 100644 drivers/gpu/drm/vmwgfx/vmwgfx_cursor_plane.c
>  create mode 100644 drivers/gpu/drm/vmwgfx/vmwgfx_cursor_plane.h
> 


Should update the year in the copyright to 2025, looks good otherwise.

Reviewed-by: Maaz Mombasawala <maaz.mombasawala@broadcom.com>