| Message ID | 20250307034454.12243-13-guangjie.song@mediatek.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | pmdomain: mediatek: Add MT8196 power domain | expand |
On Fri, 07 Mar 2025 11:44:36 +0800, Guangjie Song wrote: > Add the binding documentation for power domain on MediaTek MT8196. > > Signed-off-by: Guangjie Song <guangjie.song@mediatek.com> > --- > .../mediatek,mt8196-power-controller.yaml | 74 +++++++++++++++++++ > include/dt-bindings/power/mt8196-power.h | 57 ++++++++++++++ > 2 files changed, 131 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/mediatek,mt8196-power-controller.yaml > create mode 100644 include/dt-bindings/power/mt8196-power.h > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/mediatek,mt8196-power-controller.example.dtb: power-controller@1c004000: compatible: ['mediatek,mt8196-scpsys', 'syscon'] is too long from schema $id: http://devicetree.org/schemas/power/mediatek,mt8196-power-controller.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/mediatek,mt8196-power-controller.example.dtb: power-controller@1c004000: reg: [[0, 469778432], [0, 4096]] is too long from schema $id: http://devicetree.org/schemas/mfd/syscon-common.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250307034454.12243-13-guangjie.song@mediatek.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Fri, Mar 07, 2025 at 11:44:36AM +0800, Guangjie Song wrote: > Add the binding documentation for power domain on MediaTek MT8196. > > Signed-off-by: Guangjie Song <guangjie.song@mediatek.com> > --- > .../mediatek,mt8196-power-controller.yaml | 74 +++++++++++++++++++ > include/dt-bindings/power/mt8196-power.h | 57 ++++++++++++++ You keep sending multiple patchsets and none of them are tested. > 2 files changed, 131 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/mediatek,mt8196-power-controller.yaml > create mode 100644 include/dt-bindings/power/mt8196-power.h Comments from other patches apply. > > diff --git a/Documentation/devicetree/bindings/power/mediatek,mt8196-power-controller.yaml b/Documentation/devicetree/bindings/power/mediatek,mt8196-power-controller.yaml > new file mode 100644 > index 000000000000..6c2867b25967 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/mediatek,mt8196-power-controller.yaml > @@ -0,0 +1,74 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/power/mediatek,mt8196-power-controller.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Mediatek MT8196 Power Domains Controller > + > +maintainers: > + - Guangjie Song <guangjie.song@mediatek.com> > + > +description: | > + Mediatek processors include support for multiple power domains which can be > + powered up/down by software based on different application scenes to save power. > + > +properties: > + $nodename: > + pattern: '^power-controller(@[0-9a-f]+)?$' How unit address can be optional? > + > + compatible: > + enum: > + - mediatek,mt8196-scpsys > + - mediatek,mt8196-hfrpsys > + > + '#power-domain-cells': > + const: 1 > + > + reg: > + description: Address range of the power controller. No, look how other bindings do it. > + > + clocks: > + description: | Look at other bindings. > + A number of phandles to clocks that need to be enabled during domain > + power-up sequencing. Look at other bindings. > + > + clock-names: > + description: | > + List of names of clock. > + > + domain-supply: > + description: domain regulator supply. > + > + spm: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: phandle to the device containing the spm register range. > + > + mmpc: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: phandle to the device containing the mmpc register range. > + > + vote-regmap: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: phandle to the device containing the vote register range. > + > + mm-vote-regmap: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: phandle to the device containing the mm-vote register range. None of these are correct. > + > +required: > + - compatible That's just incomplete. This binding is really incomplete and with multiple issues. Considering this was never tested, please first consult some internal folks to do proper internal review. > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/power/mt8196-power.h> > + > + scpsys: power-controller@1c004000 { > + compatible = "mediatek,mt8196-scpsys", "syscon"; > + reg = <0 0x1c004000 0 0x1000>; > + #power-domain-cells = <1>; > + spm = <&scpsys_bus>; > + vote-regmap = <&vote>; > + }; > diff --git a/include/dt-bindings/power/mt8196-power.h b/include/dt-bindings/power/mt8196-power.h > new file mode 100644 > index 000000000000..b0db89cc435d > --- /dev/null > +++ b/include/dt-bindings/power/mt8196-power.h > @@ -0,0 +1,57 @@ > +/* SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause */ > +/* > + * Copyright (c) 2023 MediaTek Inc. We have 2025. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/power/mediatek,mt8196-power-controller.yaml b/Documentation/devicetree/bindings/power/mediatek,mt8196-power-controller.yaml new file mode 100644 index 000000000000..6c2867b25967 --- /dev/null +++ b/Documentation/devicetree/bindings/power/mediatek,mt8196-power-controller.yaml @@ -0,0 +1,74 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/power/mediatek,mt8196-power-controller.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Mediatek MT8196 Power Domains Controller + +maintainers: + - Guangjie Song <guangjie.song@mediatek.com> + +description: | + Mediatek processors include support for multiple power domains which can be + powered up/down by software based on different application scenes to save power. + +properties: + $nodename: + pattern: '^power-controller(@[0-9a-f]+)?$' + + compatible: + enum: + - mediatek,mt8196-scpsys + - mediatek,mt8196-hfrpsys + + '#power-domain-cells': + const: 1 + + reg: + description: Address range of the power controller. + + clocks: + description: | + A number of phandles to clocks that need to be enabled during domain + power-up sequencing. + + clock-names: + description: | + List of names of clock. + + domain-supply: + description: domain regulator supply. + + spm: + $ref: /schemas/types.yaml#/definitions/phandle + description: phandle to the device containing the spm register range. + + mmpc: + $ref: /schemas/types.yaml#/definitions/phandle + description: phandle to the device containing the mmpc register range. + + vote-regmap: + $ref: /schemas/types.yaml#/definitions/phandle + description: phandle to the device containing the vote register range. + + mm-vote-regmap: + $ref: /schemas/types.yaml#/definitions/phandle + description: phandle to the device containing the mm-vote register range. + +required: + - compatible + +additionalProperties: false + +examples: + - | + #include <dt-bindings/power/mt8196-power.h> + + scpsys: power-controller@1c004000 { + compatible = "mediatek,mt8196-scpsys", "syscon"; + reg = <0 0x1c004000 0 0x1000>; + #power-domain-cells = <1>; + spm = <&scpsys_bus>; + vote-regmap = <&vote>; + }; diff --git a/include/dt-bindings/power/mt8196-power.h b/include/dt-bindings/power/mt8196-power.h new file mode 100644 index 000000000000..b0db89cc435d --- /dev/null +++ b/include/dt-bindings/power/mt8196-power.h @@ -0,0 +1,57 @@ +/* SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause */ +/* + * Copyright (c) 2023 MediaTek Inc. + * Author: Chong-ming Wei <chong-ming.wei@mediatek.com> + */ + +#ifndef _DT_BINDINGS_POWER_MT8196_POWER_H +#define _DT_BINDINGS_POWER_MT8196_POWER_H + +/* SPM */ +#define MT8196_POWER_DOMAIN_CONN 0 +#define MT8196_POWER_DOMAIN_SSUSB_P0 1 +#define MT8196_POWER_DOMAIN_SSUSB_DP_PHY_P0 2 +#define MT8196_POWER_DOMAIN_SSUSB_P1 3 +#define MT8196_POWER_DOMAIN_SSUSB_P23 4 +#define MT8196_POWER_DOMAIN_SSUSB_PHY_P2 5 +#define MT8196_POWER_DOMAIN_PEXTP_MAC0 6 +#define MT8196_POWER_DOMAIN_PEXTP_MAC1 7 +#define MT8196_POWER_DOMAIN_PEXTP_MAC2 8 +#define MT8196_POWER_DOMAIN_PEXTP_PHY0 9 +#define MT8196_POWER_DOMAIN_PEXTP_PHY1 10 +#define MT8196_POWER_DOMAIN_PEXTP_PHY2 11 +#define MT8196_POWER_DOMAIN_ADSP_AO 12 +#define MT8196_POWER_DOMAIN_ADSP_INFRA 13 +#define MT8196_POWER_DOMAIN_AUDIO 14 +#define MT8196_POWER_DOMAIN_ADSP_TOP_DORMANT 15 +#define MT8196_POWER_DOMAIN_MM_PROC_DORMANT 16 +#define MT8196_POWER_DOMAIN_SSR 17 +#define MT8196_SPM_POWER_DOMAIN_NR 18 + +/* MMPC */ +#define MT8196_POWER_DOMAIN_MM_INFRA_AO 0 +#define MT8196_POWER_DOMAIN_MM_INFRA0 1 +#define MT8196_POWER_DOMAIN_MM_INFRA1 2 +#define MT8196_POWER_DOMAIN_VDE_VCORE0 3 +#define MT8196_POWER_DOMAIN_VDE0 4 +#define MT8196_POWER_DOMAIN_VDE1 5 +#define MT8196_POWER_DOMAIN_VEN0 6 +#define MT8196_POWER_DOMAIN_VEN1 7 +#define MT8196_POWER_DOMAIN_VEN2 8 +#define MT8196_POWER_DOMAIN_DISP_VCORE 9 +#define MT8196_POWER_DOMAIN_DIS0_DORMANT 10 +#define MT8196_POWER_DOMAIN_DIS1_DORMANT 11 +#define MT8196_POWER_DOMAIN_OVL0_DORMANT 12 +#define MT8196_POWER_DOMAIN_OVL1_DORMANT 13 +#define MT8196_POWER_DOMAIN_DISP_EDPTX_DORMANT 14 +#define MT8196_POWER_DOMAIN_DISP_DPTX_DORMANT 15 +#define MT8196_POWER_DOMAIN_MML0_SHUTDOWN 16 +#define MT8196_POWER_DOMAIN_MML1_SHUTDOWN 17 +#define MT8196_POWER_DOMAIN_CSI_BS_RX 18 +#define MT8196_POWER_DOMAIN_CSI_LS_RX 19 +#define MT8196_POWER_DOMAIN_DSI_PHY0 20 +#define MT8196_POWER_DOMAIN_DSI_PHY1 21 +#define MT8196_POWER_DOMAIN_DSI_PHY2 22 +#define MT8196_MMPC_POWER_DOMAIN_NR 23 + +#endif /* _DT_BINDINGS_POWER_MT8196_POWER_H */
Add the binding documentation for power domain on MediaTek MT8196. Signed-off-by: Guangjie Song <guangjie.song@mediatek.com> --- .../mediatek,mt8196-power-controller.yaml | 74 +++++++++++++++++++ include/dt-bindings/power/mt8196-power.h | 57 ++++++++++++++ 2 files changed, 131 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/mediatek,mt8196-power-controller.yaml create mode 100644 include/dt-bindings/power/mt8196-power.h